LHCb merge requestshttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests2024-01-15T11:47:03+01:00https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4410Fixed typo in platform info for clang16 platform2024-01-15T11:47:03+01:00Sebastien PonceFixed typo in platform info for clang16 platformhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4224Fill EventStats for 2022 reprocessing2023-08-07T10:41:30+02:00Marian Stahlmarian.stahl@cern.chFill EventStats for 2022 reprocessingTell the IncidentSvc in MDFWriter when an event is written so that the stats counters of the xml summary are filled.Tell the IncidentSvc in MDFWriter when an event is written so that the stats counters of the xml summary are filled.RTA/2023.07.31Jamie GoodingJamie Goodinghttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4176MDF copy writer for 2022 reprocessing2023-08-07T10:41:30+02:00Marian Stahlmarian.stahl@cern.chMDF copy writer for 2022 reprocessing- Adds `mdf_copy_input_writer` to `PyConf/application.py` for merging step of reprocessing prod
- MDFWriter: let the IncidentSvc know we are closing the file. In this way the XML summary is populated properly. Many thanks to @clemenci fo...- Adds `mdf_copy_input_writer` to `PyConf/application.py` for merging step of reprocessing prod
- MDFWriter: let the IncidentSvc know we are closing the file. In this way the XML summary is populated properly. Many thanks to @clemenci for the fix.RTA/2023.07.31Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukJamie GoodingChristopher Rob Jonesjonesc@hep.phy.cam.ac.ukhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3993Workaround external SyntaxWarning due to LCG 103, see #2922023-03-02T08:31:07+01:00Rosen MatevWorkaround external SyntaxWarning due to LCG 103, see #292Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3991Declare dependency of RichKernel ConfigurableUser on LHCbKenrel2023-03-01T16:00:05+01:00Marco Clemencicmarco.clemencic@cern.chDeclare dependency of RichKernel ConfigurableUser on LHCbKenrelThis fixes the build error seen on some platforms
```
WARNING: Specified module 'LHCbKernel.Configuration' does not contain ConfigurableUser specializations
ERROR: No ConfigurableUser specialization found
```This fixes the build error seen on some platforms
```
WARNING: Specified module 'LHCbKernel.Configuration' does not contain ConfigurableUser specializations
ERROR: No ConfigurableUser specialization found
```Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3979Add some centos7/gcc12 platforms2023-02-22T16:16:29+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukAdd some centos7/gcc12 platformsAdds missing platforms currently being built in `lhcb-head-2`Adds missing platforms currently being built in `lhcb-head-2`https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3931Fix warning suppression for C++20 extension2023-01-20T09:52:00+01:00Marco Clemencicmarco.clemencic@cern.chFix warning suppression for C++20 extensionThis adapts a warning suppression so that it works with gcc 12, similar to what was done already in lhcb/Rec!3230.This adapts a warning suppression so that it works with gcc 12, similar to what was done already in lhcb/Rec!3230.https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3930Fix name collisions in XMLSummaryKernel tests2023-07-27T12:01:29+02:00Marco Clemencicmarco.clemencic@cern.chFix name collisions in XMLSummaryKernel testsFor some reason the name collision only showed up after applying !3903, but it is there so I prepared this to fix it.For some reason the name collision only showed up after applying !3903, but it is there so I prepared this to fix it.https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3925Force test validator to take into account stderr exclusions2023-01-23T10:38:00+01:00Marco Clemencicmarco.clemencic@cern.chForce test validator to take into account stderr exclusionsThis is needed to take into account a new `Info` message from ROOT 6.26 (LCG 102).
Ideally we could suppress the message by changing the message suppression level in ROOT, but it requires further discussion.This is needed to take into account a new `Info` message from ROOT 6.26 (LCG 102).
Ideally we could suppress the message by changing the message suppression level in ROOT, but it requires further discussion.https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3924Add stderr exclusion for switch to Geant4 units2023-01-16T13:02:09+01:00Marco Clemencicmarco.clemencic@cern.chAdd stderr exclusion for switch to Geant4 unitsROOT prints a warning when we select explicitly a system of units. We already had the exclusion for `Changing system of units to ROOT units`, but we didn't have it for `Changing system of units to Geant4 units`.ROOT prints a warning when we select explicitly a system of units. We already had the exclusion for `Changing system of units to ROOT units`, but we didn't have it for `Changing system of units to Geant4 units`.https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3908Add a few new platforms to PlatformInfo2023-01-05T10:42:03+01:00Marco Clemencicmarco.clemencic@cern.chAdd a few new platforms to PlatformInfothis is needed to prepare the switch to new platformsthis is needed to prepare the switch to new platformshttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3905Add missing include needed when building for centos92022-12-19T18:24:50+01:00Marco Clemencicmarco.clemencic@cern.chAdd missing include needed when building for centos9This is meant to fix a problem I found when trying to build on CentOS9:
```
../Event/EventBase/tests/src/test_SOAPacker.cpp:80:3: required from here
../Event/EventBase/include/Event/SOAPacker.h:52:21: error: 'isnan' was not declared in...This is meant to fix a problem I found when trying to build on CentOS9:
```
../Event/EventBase/tests/src/test_SOAPacker.cpp:80:3: required from here
../Event/EventBase/include/Event/SOAPacker.h:52:21: error: 'isnan' was not declared in this scope; did you mean 'std::isnan'?
52 | if ( isnan( dataA[i] ) && isnan( dataB[i] ) ) {
| ~~~~~^~~~~~~~~~~~
| std::isnan
```https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3903Enable DD4hep by default2023-02-08T10:00:59+01:00Marco Clemencicmarco.clemencic@cern.chEnable DD4hep by defaultWe agreed at the latest [Core Software Meeting](https://indico.cern.ch/event/1226798/?note=218840) to switch, as of LCG 102, the default platforms to enable DD4hep and replace the special platforms `+dd4hep` with `+detdesc` equivalent on...We agreed at the latest [Core Software Meeting](https://indico.cern.ch/event/1226798/?note=218840) to switch, as of LCG 102, the default platforms to enable DD4hep and replace the special platforms `+dd4hep` with `+detdesc` equivalent ones for testing.
This MR changes the default of `USE_DD4HEP` to true, while the new platforms are introduce in lcg-toolchains, see lhcb-core/lcg-toolchains!114.
I also switched specialized `dd4hep` reference files with `detdesc` ones.
In principle this should be merged when we switch the default LCG baseline to 102b or 103 (foreseen in January).https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3875Fixes needed to compile with gcc 122024-01-30T14:54:44+01:00Marco Clemencicmarco.clemencic@cern.chFixes needed to compile with gcc 12Part of a series: lhcb/Detector!317 lhcb/LHCb!3875 lhcb/Lbcom!642 lhcb/Rec!3230Part of a series: lhcb/Detector!317 lhcb/LHCb!3875 lhcb/Lbcom!642 lhcb/Rec!3230https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3750loopy unpacking and multi packing2023-05-31T09:57:30+02:00Sevda Esenloopy unpacking and multi packingCurrent implementation of persistency configures a packer and unpacker for each location. This MR changes this to:
* one packer per object type
* each unpacker for a given location also unpacks all linked locations if they are not unpac...Current implementation of persistency configures a packer and unpacker for each location. This MR changes this to:
* one packer per object type
* each unpacker for a given location also unpacks all linked locations if they are not unpacked already. This will allow to request a location to be unpacked individually.
* Packing and unpacking configurations are simplified. PersistRecoConf is removed as most of it's functionality is not needed anymore.
Part of set LHCb!3750 DaVinci!747 MooreAnalysis!92 Analysis!918 Moore!1638Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3519PyConf.tonic: Nicer formatting of function objects2024-03-22T17:02:50+01:00Rosen MatevPyConf.tonic: Nicer formatting of function objectsThis is purely cosmetic change that is improving debug/warning messages.
Let's only test in the nightliesThis is purely cosmetic change that is improving debug/warning messages.
Let's only test in the nightliesRosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3442Explicitly find PkgConfig2022-03-07T08:41:19+01:00Rosen MatevExplicitly find PkgConfigIn a super project build the PkgConfig module must be found in every
subdirectory (project in this case).
The change here is not really needed but it just makes the configuration less misleading. OTOH the explicit find_package in Online...In a super project build the PkgConfig module must be found in every
subdirectory (project in this case).
The change here is not really needed but it just makes the configuration less misleading. OTOH the explicit find_package in Online is needed: https://gitlab.cern.ch/lhcb/Online/-/merge_requests/615Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3419SOAPackers2022-05-17T16:05:57+02:00Arthur Marius HennequinSOAPackersThis MR adds automatic packing and unpacking functionalities to SOACollections.
Goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2761
@gravenThis MR adds automatic packing and unpacking functionalities to SOACollections.
Goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2761
@gravenRosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3415Add specific track types for the study of tracking efficiency2022-02-21T16:57:26+01:00Peilian LiAdd specific track types for the study of tracking efficiencyAdd specific track types (`SeedMuon`, `VeloMuon` and `MuonUT`) for the study of tracking efficiency
To go with Rec!2721Add specific track types (`SeedMuon`, `VeloMuon` and `MuonUT`) for the study of tracking efficiency
To go with Rec!2721Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3361Fix clang warning (follow up !3355)2021-12-13T11:33:22+01:00Rosen MatevFix clang warning (follow up !3355)Rosen MatevRosen Matev