LHCb merge requestshttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests2024-03-28T08:53:37+01:00https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4501prefer `DataHandle::setKey` over `DataHandle::updateKey`2024-03-28T08:53:37+01:00Gerhard Ravenprefer `DataHandle::setKey` over `DataHandle::updateKey`both `DataHandle::setKey` and `DataHandle::updateKey` do the exact same thing, so standardize on one of them (so that the other can be removed subsequently)both `DataHandle::setKey` and `DataHandle::updateKey` do the exact same thing, so standardize on one of them (so that the other can be removed subsequently)https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4498truth matching fix for neutrals2024-03-28T00:03:50+01:00Sevda Esentruth matching fix for neutralsPort the truth matching fix from LHCb!4453
Related to Moore#738Port the truth matching fix from LHCb!4453
Related to Moore#738RTA/2024.04.04-MC2023Christina AgapopoulouChristina Agapopoulouhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4497Draft: Disable decoding of a couple of SelRep sub-banks if no object is saved...2024-03-22T19:35:15+01:00Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chDraft: Disable decoding of a couple of SelRep sub-banks if no object is saved to the ObjType sub-bankCurrent MR addresses the issue DaVinci#162. It disables decoding of a couple of `SelRep` sub-banks, named `StdInfo` and `Substr`, for the case, if no object is present in the `ObjTyp` sub-bank.
Disabling decoding of such sub-banks shoul...Current MR addresses the issue DaVinci#162. It disables decoding of a couple of `SelRep` sub-banks, named `StdInfo` and `Substr`, for the case, if no object is present in the `ObjTyp` sub-bank.
Disabling decoding of such sub-banks should be completely safe, as the only places where they are used have a condition `nObj > 0` anyway.
The reason why this is required is the fact, that these sub-banks are not written by HLT1 for non-triggered events. As for the HLT1 efficiency studies, non-triggered events are important for the correct computation of the denominator, such cases should be handled correctly by a decoder.
Goes with: DaVinci!1052, Rec!3801.
FYI: @jzhuo @adeoyanghttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4494make PyConf.reading functions usable as RecoConf.reco_objects_from_spruce2024-03-27T16:05:15+01:00Sevda Esenmake PyConf.reading functions usable as RecoConf.reco_objects_from_spruceUnpacking of reco objects are duplicated in RecoConf.reco_objects_for_spruce and PyConf.reading. Make PyConf.reading functions usable as RecoConf.reco_objects_from_spruce so latter can be removed.
Needed for Moore!3203 DaVinci!1059
Clo...Unpacking of reco objects are duplicated in RecoConf.reco_objects_for_spruce and PyConf.reading. Make PyConf.reading functions usable as RecoConf.reco_objects_from_spruce so latter can be removed.
Needed for Moore!3203 DaVinci!1059
Closing Moore#625 DaVinci#172Anfeng LiAnfeng Lihttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4493Added tae support in PyConf2024-03-21T14:26:10+01:00Sebastien PonceAdded tae support in PyConfhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4492add code to reset m_cBad and m_tBad for each event2024-03-29T00:14:28+01:00Marco Cattaneoadd code to reset m_cBad and m_tBad for each eventCherry-picked from LHCb!4484. Goes with Rec!3825Cherry-picked from LHCb!4484. Goes with Rec!3825https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4491add code to reset m_cBad and m_tBad for each event2024-03-29T00:14:12+01:00Marco Cattaneoadd code to reset m_cBad and m_tBad for each eventCherry-picked from LHCb!4484. Goes with Rec!3824Cherry-picked from LHCb!4484. Goes with Rec!3824https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4490add code to reset m_cBad and m_tBad for each event2024-03-28T00:10:56+01:00Marco Cattaneoadd code to reset m_cBad and m_tBad for each eventCherry-picked from LHCb!4484. Goes with Rec!3823Cherry-picked from LHCb!4484. Goes with Rec!3823https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4489Add code to reset m_cBad and m_tBad for each event2024-03-28T00:12:12+01:00Marco CattaneoAdd code to reset m_cBad and m_tBad for each eventCherry-picked from LHCb!4484. Goes with Rec!3822Cherry-picked from LHCb!4484. Goes with Rec!3822https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4488Add code to reset m_cBad and m_tBad for each event2024-03-28T00:03:50+01:00Marco CattaneoAdd code to reset m_cBad and m_tBad for each eventCherry-picked from LHCb!4484. Goes with Rec!3821Cherry-picked from LHCb!4484. Goes with Rec!3821https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4486add 2 new run3 raw DAQ error bank types2024-03-25T14:21:32+01:00Guillaume Voutersadd 2 new run3 raw DAQ error bank typesSebastien PonceRosen MatevSebastien Poncehttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4485decayLength rename in ParticleParams2024-03-28T21:53:21+01:00Andrea Villaandrea.villa@cern.chdecayLength rename in ParticleParamsRenaming the `decayLength` attribute of the `ParticleParams` module to make it consistent with the DaVinci functor that computes the flight distance.
Corresponding changes are put in place in https://gitlab.cern.ch/lhcb/Rec/-/merge_requ...Renaming the `decayLength` attribute of the `ParticleParams` module to make it consistent with the DaVinci functor that computes the flight distance.
Corresponding changes are put in place in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3815 and https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1057Anfeng LiAnfeng Lihttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4483Draft: Adapt to Detector!4422024-03-23T11:58:53+01:00Louis Henrylouis.henry@cern.chDraft: Adapt to Detector!442See Detector!442
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationSee Detector!442
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4482add code to reset m_cBad and m_tBad for each event2024-03-28T00:13:10+01:00Marco Cattaneoadd code to reset m_cBad and m_tBad for each eventCherry-pick of !4252 and !4477. Goes with Rec!3816Cherry-pick of !4252 and !4477. Goes with Rec!3816https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4476Update References for: LHCb!2993, Rec!2735, Allen!1370, Moore!927, Alignment!...2024-03-17T10:15:00+01:00Software for LHCbUpdate References for: LHCb!2993, Rec!2735, Allen!1370, Moore!927, Alignment!439, MooreOnline!325, Panoptes!304, DaVinci!1002 based on lhcb-master-mr/11099https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4474Draft: Add an the Detector build type to the DD4hepSvc2024-03-15T17:13:54+01:00Ben CouturierDraft: Add an the Detector build type to the DD4hepSvcAdd an the Detector build type to the DD4hepSvc.
Requires https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/512Add an the Detector build type to the DD4hepSvc.
Requires https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/512https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4473add `hlt_decisions` for HLT1 to `do_unpacking`2024-03-25T10:43:49+01:00Nicole Skidmoreadd `hlt_decisions` for HLT1 to `do_unpacking`Minor additionMinor additionNicole SkidmoreAnfeng LiNicole Skidmorehttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4472Use pre-commit for formatting and flake8 checks2024-03-19T10:18:47+01:00Marco Clemencicmarco.clemencic@cern.chUse pre-commit for formatting and flake8 checksThis is a partial version of !4346 in the sense that it adds support for checking the formatting with pre-commit, but does not require a full reformatting (since clang-format-8 is now available for pre-commit).
This can be merged any ti...This is a partial version of !4346 in the sense that it adds support for checking the formatting with pre-commit, but does not require a full reformatting (since clang-format-8 is now available for pre-commit).
This can be merged any time as it does not require file changes and the reformatting can happen another time (e.g. YETS).https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4471add get_flavourtags function and missing flavour tag selection unpacker2024-03-27T15:28:50+01:00Sevda Esenadd get_flavourtags function and missing flavour tag selection unpackerFlavourTags are now packed as ```SharedObjectsContainer<FlavourTag>``` instead of ```KeyedContainer<FlavourTag>``` but the unpacking for the ```SharedObjectsContainer<FlavourTag>``` was missing. This is added now, as well as a ``get_flav...FlavourTags are now packed as ```SharedObjectsContainer<FlavourTag>``` instead of ```KeyedContainer<FlavourTag>``` but the unpacking for the ```SharedObjectsContainer<FlavourTag>``` was missing. This is added now, as well as a ``get_flavourtags``` function.
@cprouve @gravenAnfeng LiAnfeng Lihttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4470PackedCaloHypo simple warning message modification2024-03-28T18:39:02+01:00Miroslav Saurmiroslav.saur@cern.chPackedCaloHypo simple warning message modificationPackedCaloHypo simple warning message modification
Part of the set: Moore!2907 lhcb-datapkg/PRConfig!386 MooreOnline!326 Alignment!458 Panoptes!317 DaVinci!1038PackedCaloHypo simple warning message modification
Part of the set: Moore!2907 lhcb-datapkg/PRConfig!386 MooreOnline!326 Alignment!458 Panoptes!317 DaVinci!1038Miroslav Saurmiroslav.saur@cern.chMiroslav Saurmiroslav.saur@cern.ch