Skip to content

Fix event number initialisation in LoKi::AuxFunBase

Olli Lupton requested to merge olupton-LoKiAuxFunBase into master

As briefly discussed with @graven here it seems there is a bug in LoKi::AuxFunBase where the m_event member is not always initialised. This also shows up in the coverity results here.

A symptom of this was that some functors, such as LoKi::Particles::MinImpParChi2WithSource, which contain a if ( !sameEvent() ) { /* ... */ } block would sometimes fail to execute this block when they should, leading to strange warnings (e.g. LoKi::Particles::MinImpParDV: Empty list of vertices, return 'InvalidDistance').

Making the MR now and without WIP: at @cattanem's request so it runs in tomorrow's nightlies.

cc: @ibelyaev, please take a look!

Merge request reports