Moore issueshttps://gitlab.cern.ch/lhcb/Moore/-/issues2024-03-29T10:16:15+01:00https://gitlab.cern.ch/lhcb/Moore/-/issues/740Failing assert in Hlt1Conf.persistency.mdf_write on v2-dbg platforms2024-03-29T10:16:15+01:00Miroslav Saurmiroslav.saur@cern.chFailing assert in Hlt1Conf.persistency.mdf_write on v2-dbg platformsA crash has been observed at Moore!2907 in [Hlt1Conf_persistency_mdf_write](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-master-mr/11286/Moore/x86_64_v2-el9-gcc13+detdesc-dbg/tests#Hlt1Conf_persistency_mdf_write):
```
python3: ../Even...A crash has been observed at Moore!2907 in [Hlt1Conf_persistency_mdf_write](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-master-mr/11286/Moore/x86_64_v2-el9-gcc13+detdesc-dbg/tests#Hlt1Conf_persistency_mdf_write):
```
python3: ../Event/RecEvent/src/PrimaryVertices.cpp:129: LHCb::Event::PV::Chi2Accumulator LHCb::Event::PV::accumulate(ExtendedPrimaryVertex&, PVTracks&, float) [with bool UpdateWeightMatrix = true; bool UpdateWeight = true]: Assertion `none( ( abs( Vx ) <= std::numeric_limits<decltype( Vx )>::min() ) || abs( Vy ) <= std::numeric_limits<decltype( Vy )>::min() )' failed.
*** Break *** abort
```
This error is triggered by assert at [PrimaryVertices.cpp#L129](https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Event/RecEvent/src/PrimaryVertices.cpp#L129)
Observed only on v2-dbg platfroms (both DD4hep and DetDesc), no problem observed on v3 platform or regular v2 (both DD4hep and DetDesc).
Original comment: https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2907#note_7797647Wouter Hulsbergenwouterh@nikhef.nlMiroslav Saurmiroslav.saur@cern.chWouter Hulsbergenwouterh@nikhef.nlhttps://gitlab.cern.ch/lhcb/Moore/-/issues/739Test for line names following regex conventions2024-03-28T21:29:17+01:00Nicole SkidmoreTest for line names following regex conventionsTURBO lines are streamed in Sprucing passthrough by regex eg.
```
turbolinedict = {
"b2oc": ["Hlt2B2OC.*Decision"], #B2OC Calib lines do not have `Hlt2B2OC`
#bandq also has charmonium_to_dimuon_lines
"bandq": [
"^(?!...TURBO lines are streamed in Sprucing passthrough by regex eg.
```
turbolinedict = {
"b2oc": ["Hlt2B2OC.*Decision"], #B2OC Calib lines do not have `Hlt2B2OC`
#bandq also has charmonium_to_dimuon_lines
"bandq": [
"^(?!.*Full)Hlt2BandQ.*Decision", 'Hlt2_JpsiToMuMuDecision',
'Hlt2_Psi2SToMuMuDecision', 'Hlt2_DiMuonPsi2STightDecision',
'Hlt2_DiMuonJPsiTightDecision' # have latter 2 gone to FULL?
],
"b2cc": ["Hlt2B2CC.*Decision"],
##No SL as is in Full
"charm": ["Hlt2Charm.*Decision"],
#Note DiMuon lines will now be caught by "Hlt2QEE"
"qee": ["^(?!.*Full)Hlt2QEE.*Decision"],
"rd": ["^(?!.*Gamma.*Incl)Hlt2RD.*Decision"], #confirm this will not omit any turbo lines
"bnoc": ["^(?!.*Full)Hlt2BnoC.*Decision"],
"ift": ["Hlt2IFT_Femtoscopy.*Decision"] #ift turbo lines all have `Hlt2IFT_Femtoscopy`?
}
```
It is very important the TURBO lines are selected by this regex and FULL lines are excluded from this regex
QEE has already implemented this for their WG but it would be fantastic to have a test in Moore that does this for all WGs
cc @erodriguLuke GrazetteLuke Grazette2024-04-12https://gitlab.cern.ch/lhcb/Moore/-/issues/738MC-matching fixes for 2023 MC central productions2024-03-27T19:39:44+01:00Carla Marin Benitocarla.marin.benito@cern.chMC-matching fixes for 2023 MC central productionsMoore v54r16p4 was released for running HLT2 centrally on 2022 and 2023 MC productions.
However, some fixes are needed on top for MC matching. They are all already included in master but need to be ported to `2023-hlt2pp-patches`
- [ ] ...Moore v54r16p4 was released for running HLT2 centrally on 2022 and 2023 MC productions.
However, some fixes are needed on top for MC matching. They are all already included in master but need to be ported to `2023-hlt2pp-patches`
- [ ] use Retina full clusters for mc-matching. MR open in https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3154
- [ ] truth matching fix for persistreco, added to master in https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2781 Ported to `2023-hlt2pp-patches` in https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3222
- [ ] truth matching fix in persistency, mostly affecting neutral objects. Added to master in https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4453 Ported to `2023-hlt2pp-patches` in https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4498
FYI @cagapopo @sesen @kreps @decianm
Thanks to @lugrazet for reporting.RTA/2024.04.04-MC2023Sevda EsenCarla Marin Benitocarla.marin.benito@cern.chSevda Esenhttps://gitlab.cern.ch/lhcb/Moore/-/issues/737Follow-up from "added exception for "WARNING Suppressing message: 'Too many c...2024-03-26T12:26:21+01:00Andre GuntherFollow-up from "added exception for "WARNING Suppressing message: 'Too many candidates. Stopping the combination.'""
- [ ] remove warning exclusion when fixed
The following discussion from !3201 should be addressed:
- [ ] @msaur started a [discussion](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3201#note_7773720): (+3 comments)
> @gunth...
- [ ] remove warning exclusion when fixed
The following discussion from !3201 should be addressed:
- [ ] @msaur started a [discussion](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3201#note_7773720): (+3 comments)
> @gunther @wouter This is a symptom that some ParticleCombiner/Hlt2line is trying to create too many combinations which will be anyway nonsensical, so it is a bug (or highly inefficient selection, which is also a bug in Turbo-based approach) in some ParticleCombiner/Hlt2line than anything else. Better to investigate what is happening, i.e. what selection is buggy, than just suppress this warning.
>
> Could you give some more details what you observed or pass the log? Thanks.Mika Anton VesterinenMiguel Ramos PernasMika Anton Vesterinenhttps://gitlab.cern.ch/lhcb/Moore/-/issues/736Truth matching bug: particles incorrectly matching to electrons2024-03-26T11:23:05+01:00Izaac SanderswoodTruth matching bug: particles incorrectly matching to electronsI think LHCb!4453 may have caused a new truth matching bug incorrectly matching tracks to electrons (not yet confirmed).
If I compare master with an older version (Moore v54r22p6) for 1000 events in the same sample, we now have a sudden...I think LHCb!4453 may have caused a new truth matching bug incorrectly matching tracks to electrons (not yet confirmed).
If I compare master with an older version (Moore v54r22p6) for 1000 events in the same sample, we now have a sudden increase in the number of tracks truth matched as electron (by a factor of more than 13). The effect is has a charge asymmetry, in that the increase only appears to be for e- and not e+. Most of these seem to be coming from tracks previously matched to pions, but not exclusively.
I only notice because I am working on the Calo PID for T tracks, and the long track ECALPIDE distribution looks very wrong, with almost all "true electron" long tracks having a very low score, meaning this is probably a truth matching error and these are not really electrons. (The sample is a BSM $`B\to KH'(\to\mu\mu)`$ so the electrons are not signal but coming from the rest of the event, hence the low stats.)
The issue only seems have a small effect on T tracks, if any, so it is only Longs (I didn't check Downstream).
![image](https://gitlab.cern.ch/lhcb/LHCb/uploads/6702a6d3a77e79757d0d3f242c066168/image.png)
![image](https://gitlab.cern.ch/lhcb/LHCb/uploads/33ea8ee17239134ad94f7d4946f23e54/True_electrons__long___master__.png)RTA/2024.03.27Jiahui ZhuoJiahui Zhuohttps://gitlab.cern.ch/lhcb/Moore/-/issues/735Separate any `Hlt1PassthroughLargeEventDecision` from other streams2024-03-25T16:09:57+01:00Andre GuntherSeparate any `Hlt1PassthroughLargeEventDecision` from other streamsWhen Allen!1492 is merged, HLT2 needs to be able to handle large events passed-through by HLT1. One solution could be to add a default [`hlt1_filter_code`](https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Moore/python/Moore/lines.py?r...When Allen!1492 is merged, HLT2 needs to be able to handle large events passed-through by HLT1. One solution could be to add a default [`hlt1_filter_code`](https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Moore/python/Moore/lines.py?ref_type=heads#L382) rejecting these events.RTA/2024.03.27Sascha StahlSascha Stahlhttps://gitlab.cern.ch/lhcb/Moore/-/issues/734Fix ParticleVertexFitter in charm/cbaryon_to_ph0_btag.py2024-03-27T15:11:48+01:00Tommaso PajeroFix ParticleVertexFitter in charm/cbaryon_to_ph0_btag.pyThe ParticleVertexFitter in
https://gitlab.cern.ch/lhcb/Moore/-/blob/8fcd82d7783f3190790709d909ca278bc0239477/Hlt/Hlt2Conf/python/Hlt2Conf/lines/charm/cbaryon_to_ph0_btag.py#L723
will try to combine the proton from the Lc+ and the pion...The ParticleVertexFitter in
https://gitlab.cern.ch/lhcb/Moore/-/blob/8fcd82d7783f3190790709d909ca278bc0239477/Hlt/Hlt2Conf/python/Hlt2Conf/lines/charm/cbaryon_to_ph0_btag.py#L723
will try to combine the proton from the Lc+ and the pion from the Lb into a single vertex, hence selecting only Lc mesons with flight distance compatible with zero, while the desired behaviour is probably different. ParticleAdder probably wouldn't solve the problem due to huge combinatorics. This looks like a good place to use DecayTreeFitter (to be tested). Otherwise, the trigger line should probably be removed.
@lpica @aanelli @cacochat @fbettiYangjie SuYangjie Suhttps://gitlab.cern.ch/lhcb/Moore/-/issues/733Follow-up from "Checks of persistency of extra outputs in sprucing stage"2024-03-19T15:10:53+01:00Nicole SkidmoreFollow-up from "Checks of persistency of extra outputs in sprucing stage"`test_spruce_hlt2filter` is failing and do not know why... stdout checked manually and is fine. To follow up...
The following discussion from !3133 should be addressed:
- [ ] @anfeng started a [discussion](https://gitlab.cern.ch/lhcb/M...`test_spruce_hlt2filter` is failing and do not know why... stdout checked manually and is fine. To follow up...
The following discussion from !3133 should be addressed:
- [ ] @anfeng started a [discussion](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3133#note_7742266): (+4 comments)Nicole SkidmoreNicole Skidmorehttps://gitlab.cern.ch/lhcb/Moore/-/issues/732Improve selection in Charm_D0ToHHHH_BuilderD0ToKmPimPipPip_untight"2024-03-22T13:46:55+01:00Andre GuntherImprove selection in Charm_D0ToHHHH_BuilderD0ToKmPimPipPip_untight"The following discussion from !3142 should be addressed:
- [ ] @cacochat started a [discussion](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3142#note_7741956): (+1 comment)
> @gunther or @yitang could we proceed by merging ...The following discussion from !3142 should be addressed:
- [ ] @cacochat started a [discussion](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3142#note_7741956): (+1 comment)
> @gunther or @yitang could we proceed by merging this?Carlos Eduardo Cocha ToapaxiCarlos Eduardo Cocha Toapaxihttps://gitlab.cern.ch/lhcb/Moore/-/issues/730RTA Shift Logs and Notes 18/03/2024 - 01/04/20242024-03-28T19:46:28+01:00Anfeng LiRTA Shift Logs and Notes 18/03/2024 - 01/04/2024RTA Shift Logs and Notes 18/03/2024 - 01/04/2024
An issue to help me (current RTA software shifter @anfeng) track and organize shifter activity. At the end of the shift, this will be converted into the Shift Summary for my shift.
## Sh...RTA Shift Logs and Notes 18/03/2024 - 01/04/2024
An issue to help me (current RTA software shifter @anfeng) track and organize shifter activity. At the end of the shift, this will be converted into the Shift Summary for my shift.
## Shift Personnel
RTA software maintainer: Christina Agapopoulou (@cagapopo)
RTA software shifter: Anfeng Li (@anfeng)
Next RTA software shifter:
## Shift Summaries in RTA-DPA General Meetings
[RTA-DPA general meeting 20240322](https://indico.cern.ch/event/1395756/)
## Open MRs
See the [milestone](https://gitlab.cern.ch/groups/lhcb/-/milestones/17#tab-merge-requests) and the following MRs
In MR sets, the one in **bold** indicates the MR from which most recent tests have been launched.
| MR | Description | Status |
|----|-------------|--------|
| **Detector MRs** | | |
| https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3519, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1017 | Access to LHC condition information | in development |
| https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/470, https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4389, https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/118 | UT ChannelID to provide subsector and asic info | under review |
| **LHCb MRs** | | |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4458 | consistently use LHCb::span instead of gsl::span | resolving test failures |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4244, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3520, https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1313, ** https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2522** | Adapt the SOA converter to allow an arbitrary set of states to be added to tracks | Awaiting input file updates |
| **https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/2993**, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2735, https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1370, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/927, https://gitlab.cern.ch/lhcb/Alignment/-/merge_requests/439, https://gitlab.cern.ch/lhcb/MooreOnline/-/merge_requests/325, https://gitlab.cern.ch/lhcb/Panoptes/-/merge_requests/304, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1002, https://gitlab.cern.ch/lhcb-datapkg/PRConfig/-/merge_requests/388 | Introduced infrastructure to read ROOT files in algorithms (allowing MT) (IOAlg) | In development |
| **https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4313**, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3614, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2693, https://gitlab.cern.ch/lhcb/MooreOnline/-/merge_requests/290 | add plot for Links In Error | In development, exact relationship among MRs may need clarification |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4364, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3708, ** https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2754**, https://gitlab.cern.ch/lhcb/Alignment/-/merge_requests/440, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1047 | Add machinery for cluster persistency | In development |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4463, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3117, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1056 | packer/unpacker cleanup / consolidation | waiting for testing |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4471 | add get_flavourtags function and missing flavour tag selection unpacker | in development |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4473 | add `hlt_decisions` for HLT1 to `do_unpacking` | tests completed with failures |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4485, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3815 | decayLength rename in ParticleParams | tests completed with failures |
| **Rec MRs** | | |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3650 | Optimise the FIND_DECAY and FIND_MCDECAY functors | test completed |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3738, https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4429, https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1433, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3045 | Fix state sets among Pr <-> v1 <-> v3 conversion | in development |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3770, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1040 | New functors for estimation of helicity angle | in development |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3774, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3036 | Rich U2 Studies Update | Undergoing CI test |
| **https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3756**, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2975, https://gitlab.cern.ch/lhcb-datapkg/ParamFiles/-/merge_requests/67 | Add functors to get the number of hits in regions of the muon stations | Undergoing review |
| **Allen MRs** | | |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1461 | Prefer filters over selections | Undergoing pipeline tests, ref update required. |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1457 | Tune LambdaLLDetachedTrack and XiOmegaLLL lines | Code review |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1198 | Downstream vertexing and two-track downstream lines for Lambda -\> P Pi and Ks0 -\> Pi Pi | In development |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1246 | Allen ecal llt decoding and ecal llt eTot lumi counter | Awaiting a test dataset, relationship of MRs not explicit in descriptions |
| **https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1258**, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2462 | Run Allen checkers in Moore | In development |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1467 | HLT1 DiLambda Line | in development |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1468 | Removes MuonFiltered algorithms that were never used | Low priority. Pipeline running and pending code review |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1480 | Sort HLT1 lines by name | in development |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1492 | Re-enable passthrough of events too large to process in Allen | testing |
| **Moore MRs** | | |
| **https://gitlab.cern.ch/lhcb/MooreOnline/-/merge_requests/333** | Upgrading to FTLiteClusterMonitor for ZS_monitor | Under going test |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3006, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3784 | Add TIS/TOS HLT1 filters in HLT2, change pion tracking efficiency lines, move HadInt lines to turbo | Undergoing code review |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3027, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3768 | Jet reconstruction efficiency check | ready for testing |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3078 | 2024 Sprucing config file | Automatic merge when pipeline succeeds |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3045 | Filter on track relations example | New commits being added |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3768 ** https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3027** | Jet reconstruction efficiency check(er) | Undergoing testing |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2757 | Optimized control flow | under review |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2800 | Update HLT2 VDM configuration (cherry-pick !2799) | Inactive for some time |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2829 | Add a unit test to check the persistency of MC relations table for neutral particles | In development, awaiting developer availability |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3129 | Few points for B2CC HLT2 | in development |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3151 | [QEE] branch to collect contributions aiming for April12th | draft |
| **https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3156** | Changing the prescale value to 0.5 for 6 lines in hexaquarks | test launched |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3157 | RD developments towards April | draft |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3169 | Change directory to look in for expected_2024 min bias in tests | in development |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3180 | Add vertexmonitor to hlt2lines | tests completed with failures |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3203, https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4494, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3836, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1059 | use PyConf.reading for sprucing reco | waiting for testing |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3208 | Add make_pvs argument in particle maker | waiting for testing |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3211 | Reduce rates and bandwidth of IFT HLT2 lines with SMOG | tests completed |
| **https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3234** | WZrd turbo lines have `Full` in the name. -> Won't be selected by regex correctly | testing |
| **Alignment MRs** | | |
| https://gitlab.cern.ch/lhcb/Alignment/-/merge_requests/387 | Added a Resetting Sink to AlignmenTrTools | In development |
| **https://gitlab.cern.ch/lhcb/Alignment/-/merge_requests/468** | Setup for global Alignment of VELO and SciFi | test completed with failures |
| **LHCbIntegrationTests MRs** | | |
| https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/61 | integration test for PV checking | waiting for testing |
## MRs that are ready for maintainer review and merging
| MR | Description | Status |
|----|-------------|--------|
| **Detector MRs** | | |
| https://gitlab.cern.ch/lhcb-datapkg/PRConfig/-/merge_requests/396 | Remove obsolete Run 2 code for testing Moore and Alignment in an online-like setup | CI test unavailable, waiting for maintainer review and merging |
| **Rec MRs** | | |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3805 | Add fstream include to beam spot monitor | ready for maintainer review and merging |
| **Allen MRs** | | |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1414 | Add algorithms to filter charged or brem calo clusters | ready for maintainer review and merging |
| **Moore MRs** | | |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3104 | Add isolation information to B2VV lines | ready for maintainer review and merging |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3133 | Checks of persistency of extra outputs in sprucing stage | ready for maintainer review and merging |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3206 | Rename charmless baryonic lines to match naming convention | ready for maintainer review and merging |
## Merged MRs
| MR | Description |
|----|-------------|
| **LHCb MRs** | | |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4299, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3665, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2658, https://gitlab.cern.ch/lhcb/Alignment/-/merge_requests/445, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1013 | add PV pointer to particle, update PV event model and persistency |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4479 | Fix compilation of LHCbMath/VectorizedML headers |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4481 | VectorizedML/Sequence fix const return type warning |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4480 | set the reserved bits to 31 for hlt raw banks |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4454, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3054 | decreports filter without functors |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4361 | Give RelationTable1D a version of add that checks entry is not already added |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4338, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3740, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3149, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1050, https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/63 | Adds persistency of PID objects |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4457, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3783, https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/549 | remove obsolete `context()` |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4444 | Support zstd compressed MDF reading in old-style IO |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4467 | Fixed packing of particle covariance matrix |
| **Rec MRs** | |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3556, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2665 | Update the VPHitEfficiencyMonitor |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3803 | Remove not-used non-thread-safe GaudiHistos |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3797 | Fixed compilation of PrCloneKiller.cpp in d0 mode |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3781, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3201 | Update of TBLV for smog reconstruction |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4495, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3675 | InteractionRegion information in additional algorithms |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3830 | Fix broken docstring for REQUIRE_CLOSE functor |
| https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3837 | Fix Moore docs after !3812 - dont use Indico anchor |
| **Allen MRs** | |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1491 | Enable SMOG2 flag |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1436 | Adds detached JPsi->mumu tag&probe line |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1500 | Fix data initialization if SciFi is not included |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1446 | Muon Chi2Corr implementation |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1496 | Closes Allen ci cleanup issue #518 |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1506, https://gitlab.cern.ch/lhcb/MooreOnline/-/merge_requests/366 | Fix TAE filter when there are multiple events in the batch |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1499 | Change 5 most significant bits of raw bank source IDs |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1504 | Add routing bit for CalibMon |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1511 | HLT1 updates for 2024 pp startup |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1497 | Reduce SMOG rate impact |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1501, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3190 | [Muon decoding] Remove special treatement of first hit |
| https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1519 | Fix muon decoding sizes |
| **Moore MRs** | |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3142 | fix the Charm_D0ToHHHH_BuilderD0ToKmPimPipPip_untight |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3103 | Set pv_tracks=True for persistreco=True |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3146 | Update BandQ inclusive line data processing flow |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3087 | Charm HLT2 rate reduction |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3122, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3792 | Remove use of TISTOS getters in B-tracking lines |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3155 | Improve naming of some QEE HLT2 lines |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3158 | using expected 2024 as MDF input |
| https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3223, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3835 | Option of default ProbNN value filling |
| **Alignment MRs** | |
| https://gitlab.cern.ch/lhcb/Alignment/-/merge_requests/466 | Update D0 selection for SciFi alignment |
| https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4475, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3693, https://gitlab.cern.ch/lhcb/Alignment/-/merge_requests/453 | Mat calibration monitor in SciFi alignment |
| https://gitlab.cern.ch/lhcb/Alignment/-/merge_requests/478 | Add rotations back in online VELO monitoring |
| **Panoptes MRs** | |
| https://gitlab.cern.ch/lhcb/Panoptes/-/merge_requests/218 | Towards automation of the mirror and panel alignment procedures |
| https://gitlab.cern.ch/lhcb/Panoptes/-/merge_requests/326 | Update magnification factors and add Monet histograms for Rich Alignment |Anfeng LiAnfeng Lihttps://gitlab.cern.ch/lhcb/Moore/-/issues/728Packing test failure for CaloNeutralEcal, CaloCluster and NeutralPID using ex...2024-03-28T14:11:48+01:00Miroslav Saurmiroslav.saur@cern.chPacking test failure for CaloNeutralEcal, CaloCluster and NeutralPID using expected 2024 MCFollowing observed issue at [lhcb/Moore!2907](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2907), [test_hlt2_check_packed_data_check](https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Hlt2Conf/tests/qmtest/test_hlt2_check_packed_...Following observed issue at [lhcb/Moore!2907](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2907), [test_hlt2_check_packed_data_check](https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Hlt2Conf/tests/qmtest/test_hlt2_check_packed_data_check.qmt) is failing following change to expected 2024 MC input sample
After running over 5000 events locally it seems that failed checks are rather consistent, largest observed difference observed for CaloNeutralEcal:
```
LHCb__SelectivePacker_e5a29b25 WARNING Fraction10 comparison failed :-
LHCb__SelectivePacker_e5a29b25 WARNING Original = 0.0261436
LHCb__SelectivePacker_e5a29b25 WARNING Unpacked = 0.0258833
LHCb__SelectivePacker_e5a29b25 WARNING Diff = 0.000260307 > 0.0002
LHCb__SelectivePacker_e5a29b25 WARNING CaloNeutralEcal comparison failed :-
LHCb__SelectivePacker_e5a29b25 WARNING Original = 65590.8
LHCb__SelectivePacker_e5a29b25 WARNING Unpacked = 65590.8
LHCb__SelectivePacker_e5a29b25 WARNING Diff = 0.0078125 > 0.0051
```
For CaloCluster:
```
LHCb__SelectivePacker_e5a29b25 WARNING Entry-Fraction comparison failed :-
LHCb__SelectivePacker_e5a29b25 WARNING Original = 1.03493
LHCb__SelectivePacker_e5a29b25 WARNING Unpacked = 1
LHCb__SelectivePacker_e5a29b25 WARNING Diff = 0.0349255 > 1.7e-05
LHCb__SelectivePacker_e5a29b25 WARNING Problem with CaloCluster data packing :-
```
and for RICH (observed only locally, not in ci-test):
```
LHCb__SelectivePacker_e5a29b25 WARNING Delta(LL) comparison failed :-
LHCb__SelectivePacker_e5a29b25 WARNING Original = -64.6796
LHCb__SelectivePacker_e5a29b25 WARNING Unpacked = -64.6796
LHCb__SelectivePacker_e5a29b25 WARNING Diff = 5.34058e-05 > 5.1e-05
LHCb__SelectivePacker_e5a29b25 WARNING Problem with RichPID data packing :-
LHCb__SelectivePacker_e5a29b25 WARNING Original PID key=114 in '/Event/RichPIDsWriterLong_3adbbadb/RichPIDsLocation'
LHCb__SelectivePacker_e5a29b25 WARNING 0x7f5a37952690
LHCb__SelectivePacker_e5a29b25 WARNING Unpacked PID
LHCb__SelectivePacker_e5a29b25 WARNING 0x7f5a2c596eb0
LHCb__SelectivePacker_e5a29b25 ERROR Packing check failed for /Event/RichPIDsWriterLong_3adbbadb/RichPIDsLocation: FAILURE
```
Observed discrepancies are currently excluded in the test, but to be investigated and later removed from the exclusions.
FYI: @sesen @graven @jonrobMiroslav Saurmiroslav.saur@cern.chMiroslav Saurmiroslav.saur@cern.chhttps://gitlab.cern.ch/lhcb/Moore/-/issues/727Add Velo track index to v1 track2024-03-11T16:23:29+01:00Wouter Hulsbergenwouterh@nikhef.nlAdd Velo track index to v1 trackThe 'PV unbiasing' needs a method to match a track in a particle to a track used in the PV. The tracks can be of different types. Furthermore, the matching also needs to work after tracks are read back from a dst.
Currently, the matchin...The 'PV unbiasing' needs a method to match a track in a particle to a track used in the PV. The tracks can be of different types. Furthermore, the matching also needs to work after tracks are read back from a dst.
Currently, the matching is essentially done by comparing LHCbIDs. To make this reasonably fast a unique number ('VeloSegmendID') is computed from Velo LHCbIDs. For the tracks in the PV this is computed once, either when the PVs are created or when they are read back from file. The ID for the track ins the particle is computed when it is needed.
The current solution is expensive:
- when making the PVs it takes time to compute the number from the LHCbIDs
- the number doesn't allow for random access, so to identify a track in the track list assigned to the PV, a search is required
An alternative solution is to assign a unique segment ID when the velo segments are created. The id could for instance be defined as:
- index in PrVeloForward container for forward segment
- index in PrBackwardContainer + size(PrVeloForward) for backward segments
For backward segments the ID is less important since we will probably never unbias wrt backward tracks.
This ID could then be copied to ancestors. The advantages are:
- in terms of storage it is much cheaper than storing LHCbIDs
- since it is a consecutive index, the 'search' in the PV can just be done by looking up an index in a table
For the v3 track such an index, called `trackVP` [already exists](https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Event/TrackEvent/include/Event/Track_v3.h?ref_type=heads#L174).
If we stick to the v1 Track event model, there are two ways forward:
- we can add `trackVP` to the v1 track model. This is relatively easy to do.
- we can add the number as an extrainfo field. This has the advantage that the track model class doesn't need to be changed. However, it is a little more expensive in term of persistence, in terms of creation and lookup, and it is more error prone.
In both cases some extra code is needed to copy the identifier from the Pr tracks to the v1 tracks.
Both solutions are not backward compatible: If tracks are saved without the identifier, it cannot be retrieved.https://gitlab.cern.ch/lhcb/Moore/-/issues/726Enabling Hlt1Conf and Hlt2Conf tests on DD4hep platform2024-03-28T10:19:50+01:00Miroslav Saurmiroslav.saur@cern.chEnabling Hlt1Conf and Hlt2Conf tests on DD4hep platformThe default input test files are updated in Moore!2907. Following this update, Hlt1Conf and Hlt2Conf tests should be checked and re-enabled on DD4hep builds where possible and investigated which tests are not possible to be enabled or co...The default input test files are updated in Moore!2907. Following this update, Hlt1Conf and Hlt2Conf tests should be checked and re-enabled on DD4hep builds where possible and investigated which tests are not possible to be enabled or could be removed.
Several tests are still using obsolete `ldst` files, these tests have to be ported to use updated samples
- [ ] Check of Hlt1Conf tests
- [ ] Check of Hlt2Conf tests
- [ ] Check of Moore tests
- [ ] Updating all tests to use the latest available input files
(See specifically
The following discussion from !3133 should be addressed:
- [ ] @sesen started a [discussion](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3133#note_7739712): (+4 comments)
> Ideally we shouldn't be adding new tests with these old files. Maybe we can use one of the new samples: /lhcb/MC/Dev/DIGI/00205202/0000/00205202_00000008_1.digi
and
https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2829#note_7753388
)
Bonus:
- Remove obsolete global bind of SciFi decoding (FT banks)
FYI @dovombru @mveghelMiroslav Saurmiroslav.saur@cern.chMiroslav Saurmiroslav.saur@cern.chhttps://gitlab.cern.ch/lhcb/Moore/-/issues/725Clean up BandQ dimuon triggers2024-03-28T09:12:34+01:00Mengzhen WangClean up BandQ dimuon triggersThere are several different dimuon triggers in BandQ Hlt2 area, including a lot of "Inc", "Soft", "SameSign" triggers. Not sure if they are all useful for physics analysis.
I also see a Z->MuMu trigger, which looks to be a QEE project....There are several different dimuon triggers in BandQ Hlt2 area, including a lot of "Inc", "Soft", "SameSign" triggers. Not sure if they are all useful for physics analysis.
I also see a Z->MuMu trigger, which looks to be a QEE project.
Need to clean a bit these lines.
@yajing @gtonani @squ @zexuMengzhen WangMengzhen Wanghttps://gitlab.cern.ch/lhcb/Moore/-/issues/724Track fit differences in DD4HEP versus DetDesc2024-03-27T11:38:52+01:00Maarten Van VeghelTrack fit differences in DD4HEP versus DetDescCurrently we use parametrized scattering covariance / corrections in the default track fit. For a direct geometry-based full track fits with e.g. `TrackMasterFitter` we see large differences (e.g. in efficiency, momentum pulls, ...) both...Currently we use parametrized scattering covariance / corrections in the default track fit. For a direct geometry-based full track fits with e.g. `TrackMasterFitter` we see large differences (e.g. in efficiency, momentum pulls, ...) both between DD4HEP and DetDesc and between different versions of the geometry within both DD4HEP and DetDesc.
Errors in the configurations of materials in the geometries have been spotted (especially in DD4HEP) that could lead to such differences. It clearly shows we should keep track of changes in the geometry and have a feedback handle for work on the geometry.
To do
- [ ] add parametrized scatter parameters to ParamFiles, see https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3780, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3808, https://gitlab.cern.ch/lhcb-datapkg/ParamFiles/-/merge_requests/73, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3686, https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/471
- [ ] add qmtest to track determination of scatter parameters, using above functionality
- [ ] recover efficiency in full direct geometry-based track fit (use above test for feedback to sub-detectors / simulation?)
Follow up from !2907, to keep track of issues on differences in DD4HEP/DetDesc versions
The following discussion from !2907 should be addressed:
- [ ] @dovombru started a [discussion](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2907#note_7641564): (+16 comments)
> @msaur do I understand correctly that you are in the process of following up on some test failures? I.e. it makes sense to take another look at the reconstruction changes maybe early next week?Maarten Van VeghelAndrii UsachovMaarten Van Veghelhttps://gitlab.cern.ch/lhcb/Moore/-/issues/723Update tests for expected 2024 MC2024-03-12T09:05:05+01:00Agnieszka DziurdaUpdate tests for expected 2024 MCAs discussed in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3612 and Rec!3631 the PV tests, namely:
[hlt1_hlt2_pvs_vertex_compare.py ](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3118/diffs#diff-content-69185f69a94dbe1f0765...As discussed in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3612 and Rec!3631 the PV tests, namely:
[hlt1_hlt2_pvs_vertex_compare.py ](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3118/diffs#diff-content-69185f69a94dbe1f07651b6458cccb281535d42f) and [hlt1_pvs_PatPV3DFuture.py ](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2686/diffs#diff-content-560b496bb5a00f1c75260c494d3825594c19b5d7)
need to be updated to MC 2024 when possible.
Most likely go together or just after gitlab.cern.ch/lhcb/Moore/-/merge_requests/2907
cc: @mgiza @guntherMiroslav Saurmiroslav.saur@cern.chMiroslav Saurmiroslav.saur@cern.chhttps://gitlab.cern.ch/lhcb/Moore/-/issues/722Particle gun simulation2024-03-04T13:28:18+01:00Hendrik JageParticle gun simulationProduction of particle gun simulation (of some signal decay) in Run3 seems not be fully supported at the moment. The Gauss and Boole steps can be run as in Run2, but for Moore there don't seem to be dedicated pGun options. The problem th...Production of particle gun simulation (of some signal decay) in Run3 seems not be fully supported at the moment. The Gauss and Boole steps can be run as in Run2, but for Moore there don't seem to be dedicated pGun options. The problem that has to be addressed is how the **PV** simulated in Gauss by [`PGPrimaryVertex`](https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Sim/SimComponents/src/PGPrimaryVertex.cpp) that is then propagated through Boole, can be read in/used by Moore.
In Run2, one could directly go to Brunel after Boole, and the Moore step could be skipped. In Brunel it seems like the only thing that was done differently for pGun simulation is to remove the vertexing from the reconstruction sequence, see [here](https://gitlab.cern.ch/lhcb/Rec/-/blob/2018-patches/Rec/RecConf/python/RecConf/Configuration.py?ref_type=heads#L144).
In Run3 the reconstruction happens already in Moore, so something similar would have to be implemented.https://gitlab.cern.ch/lhcb/Moore/-/issues/721Clean up standalone HLT2-like reco sequences2024-03-04T11:20:47+01:00Titus MombaecherClean up standalone HLT2-like reco sequencesAs discussed during https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3081/diffs#note_7658889 It would be good to clean up `standalone.py` to make as much use as possible of the nominal reconstruction sequence in `hlt2_global_reco.py` t...As discussed during https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3081/diffs#note_7658889 It would be good to clean up `standalone.py` to make as much use as possible of the nominal reconstruction sequence in `hlt2_global_reco.py` to make sure that the standalone and the nominal sequence do the same thing.
There are several use cases for this sequence that need to be kept in mind:
- MC checking
- standalone HLT2 reco
- data monitoring
Now to fix this we need to
- [ ] see whether we can adapt the monitoring such that it can run with the nominal reconstruction sequence (?) but keep access to all tracks that we need
- [ ] have a QMTest (for MooreOnline?) that ensures the monitoring doesn't change with these changes (or any others)
- [ ] finally clean up the `standalone.py` to use the nominal reconstruction sequenceTitus MombaecherTitus Mombaecherhttps://gitlab.cern.ch/lhcb/Moore/-/issues/719switched to from_file=False for hlt2_all_lines test follow-up2024-03-04T10:37:05+01:00Andre Guntherswitched to from_file=False for hlt2_all_lines test follow-upfrom !3106
"When using reconstruction from old brunel files with from_file=True, the unpacking is done using different algorithms than what we use for Moore output. While new unpackers can unpack all dependencies, old unpackers require...from !3106
"When using reconstruction from old brunel files with from_file=True, the unpacking is done using different algorithms than what we use for Moore output. While new unpackers can unpack all dependencies, old unpackers require dependencies to be unpacked explicitly. In this particular case, tracks in the PV are not unpacked but requested to be packed with PVs when pv_tracks=True.
Providing a proper fix will take time and not clear if it's worth it, so this should fix the tests for now."Miroslav Saurmiroslav.saur@cern.chMiroslav Saurmiroslav.saur@cern.chhttps://gitlab.cern.ch/lhcb/Moore/-/issues/718Jet Developments for April Deadline2024-03-27T08:08:19+01:00Nathan Allen Griesernathan.allen.grieser@cern.chJet Developments for April DeadlineGoing to try and document all of the jet-related things that we need to accomplish prior to the April deadline:
* **Code comments from Ross on** !3007
* [ ] this discussion - did you want persistreco=True for all the jet sprucing line...Going to try and document all of the jet-related things that we need to accomplish prior to the April deadline:
* **Code comments from Ross on** !3007
* [ ] this discussion - did you want persistreco=True for all the jet sprucing lines?
* [ ] this discussion - explain commented-out `calo_clusters=True`,
- **Global improvements/changes:**
- [ ] Implement MC jets (**priority number 1**)
- [ ] Finalize inclusive jet line at HLT1 https://gitlab.cern.ch/lhcb/Allen/-/merge_requests/1372
- [ ] Move inclusive single and di-jet lines to use this inclusive trigger rather than HLT1PassThrough
- [ ] Make sure sprucing lines work with all the new things.
- [ ] Edit new and current jet sprucing lines to re-use candidates rather than recreating the candidates again at this stage. **NB: No public directions, instructions to come from Nicole**
- [ ] Finalize tool for jet reconstruction efficiency ( https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3027)
- [ ] **Code cleanup:** centralize the definition of `make_jets` to `standard_jets.py`
- [ ] Implement at least 1 charged particle cut in the `make_jets` definition in `standard_jets.py`
- [ ] Configurable cuts/tags (pass tag object where `make_jets` is called rather than string, flag for jetID cut)
- [ ] Remove definitions of `make_jets` in `lines/qee/jets.py` and `lines/qee/qee_builders.py` (used in `lines/qee/vjets.py`)
- **Targeting new analyses for run-3 (Di-Jet XSec, Inclusive Single Jet, W-\>qq\`, W-\>cX):**
- [ ] Adjust prescales of inclusive lines, adding single-jet pT thresholds. **NB: Aim to cover as low pT as we can for differential di-jet XSec, expanding into regions ATLAS and CMS cannot cover.**
- [ ] Add SVtag+Inclusive jet dijet line, study efficiency of W-\>cX (https://gitlab.cern.ch/lhcb-simulation/mc-requests/-/merge_requests/478). https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3217
- **Targeting improvements from run-2 of di-heavy flavour (Hbb, Hcc, Zbb, etc.) type analyses:**
- [ ] Study impact of adding neutrals but lowering prescales on Hbb/Hcc ( https://gitlab.cern.ch/lhcb-simulation/mc-requests/-/issues/406). **NB: Analysis is significantly stats limited due to Higgs centrality, b/c-tagging efficiencies. Need to improve acceptance over run 2.**
- [ ] Study impact of heavy prescale on dijet SVtag line (at 20 GeV), particularly for Zbb process (this might be quite affected...)
- [ ] Study acceptance rates of Hbb/Hcc on TopoTag vs SVtag lines. Pre-scale the worse one to negligible rates afterwards.
- [ ] Study impact of moving SVtag lines to use HLT1 trigger requirement.Nathan Allen Griesernathan.allen.grieser@cern.chDavide ZulianiNathan Allen Griesernathan.allen.grieser@cern.ch