Skip to content

Should trigger decision names end in "Decision" rather than "Line"?

FYI @rmatev @sstahl @mvesteri

During my development of the HltEfficiencyChecker tool (see https://gitlab.cern.ch/lhcb/mooreanalysis/merge_requests/1 if interested) I had to plumb TupleToolTrigger onto the end of Moore. Currently, the dec reports have strings that end in Line. For instance you'd have a branch in a tuple called {particle}_Hlt1TwoTrackMVALine.

In run 2 this strings had the suffix Decision, and indeed TupleToolTrigger expects to see strings that end in Decision e.g. Hlt1TwoTrackMVADecision (see https://gitlab.cern.ch/lhcb/Analysis/blob/master/Phys/DecayTreeTupleTrigger/src/TupleToolTriggerBase.cpp#L145).

The question is this: should I change TupleToolTrigger to look in the dec reports for Lines, or should we keep the things same the same as run 2 and change the dec report writing to write out Decisions?

Related to Analysis!576 (merged)