Various selections in topological_b/__init__.py miss a vertex chi2 cut or select displaced tracks after the combinatorics
There is an issue with various selections in https://gitlab.cern.ch/lhcb/Moore/-/blob/2024-patches/Hlt/Hlt2Conf/python/Hlt2Conf/lines/topological_b/init.py
For instance:
-
some selections, such as this combine tracks with a requirement on the doca, but without a vertex chi2 requirement. This may be on purpose (B->Dpi?), but if it is not, then it is definitely strongly advised to change this. The doca cut can also be applied BEFORE the vertex fit.
-
quite a few selections apply a cut on the displacement of the daughter tracks /after/ the vertex fit, such as here . It is MUCH faster to apply cuts on daughter tracks as input to the selection (for instance by creating a Filter for the input particles first) or by specifying these cuts as part of the 'CombinationCut'.
-
a similar problem in bnoc/builders/b_builder.py:make_B2PpPmhh: the cut on the displacement of the track must be made BEFORE the vertex fit. There are more selections in this file with this problem.