Fix of PV type in converter

The following discussion from !237 (merged) should be addressed:

• @apiucci started a discussion: (+17 comments)

  @apearce : I see something weird happening here. When applying a IPChi2 cut on the dimuons, none of them are passing the selection. This also happens when requiring a min IPChi2 = 0, so there must be something wrong in the requirement itself, I guess. The sintax is the same used in Run 2. Is it different now?

The interesting messages are the last ones:

LoKiSvc.REPORT WARNING The WARNING message is suppressed : 'LoKi::Vertices::IsPrimary: non-primary LHCb::RecVertex, return 'false' [DiMuonDetachedSoftFilter]' StatusCode=FAILURE

and

In [9]: vx = get('/Event/Rec/Vertex/Primary')

In [10]: for i in vx: ...: print i

The only difference that I can see, is that with Brunel v53r1 the extraInfo of the PVs looks like:

extraInfo : [ ] }{ technique : Primary

while for Brunel v60r1:

extraInfo : [ ] }{ technique : ERROR wrong value 4 for enum LHCb::RecVertex::RecVertexType

The Brunel v53r1 sample is placed here:

/afs/cern.ch/work/a/apiucci/public/trigger/VP_bug/B2KsMuMu_11114100_BrunelReco_Brunelv53r1-10ev.ldst

while the Brunel v60r1 here:

/afs/cern.ch/work/a/apiucci/public/trigger/VP_bug/B2KsMuMu_11114100_BrunelReco_Brunelv60r1-10ev.ldst

I have to confirm but I think the line

        converted_vertex->setTechnique( static_cast<LHCb::RecVertex::RecVertexType>( vertex.technique() ) );

is not doing what it is supposed to do.