From 314bb6c5e29fb6587deae2b8f3a9db956d01a3ce Mon Sep 17 00:00:00 2001
From: Patrick Koppenburg <patrick.koppenburg@cern.ch>
Date: Fri, 28 Aug 2020 15:47:39 +0200
Subject: [PATCH] Replace savannah bugs by corresponding JIRA tasks (@pkoppenb)
---
Phys/LoKiPhys/LoKi/Particles25.h | 2 +-
Phys/LoKiPhys/src/Particles25.cpp | 4 ++--
Phys/ParticleMaker/src/BestPIDParticleMaker.cpp | 7 ++++---
Phys/ParticleMaker/src/CombinedParticleMaker.cpp | 8 ++++----
Phys/ParticleMaker/src/NoPIDsParticleMaker.cpp | 13 +++++++------
5 files changed, 18 insertions(+), 16 deletions(-)
diff --git a/Phys/LoKiPhys/LoKi/Particles25.h b/Phys/LoKiPhys/LoKi/Particles25.h
index c65267605..a965d45af 100644
--- a/Phys/LoKiPhys/LoKi/Particles25.h
+++ b/Phys/LoKiPhys/LoKi/Particles25.h
@@ -31,7 +31,7 @@
* A.Golutvin, P.Koppenburg have been used in the design.
*
* The file contains the functions, requested by Rob Lambert
- * (see <a href="http://savannah.cern.ch/bugs/?47745">LoKi's Savannah portal #47745</a>)
+ * (see <a href="https://its.cern.ch/jira/browse/LHCBPS-1352">LoKi's Savannah portal #47745 - now JIRA 1352</a>)
*
* All these functors are to be used within CombineParticles framework only
* and surely completely useless for the regular Loki or Bender application
diff --git a/Phys/LoKiPhys/src/Particles25.cpp b/Phys/LoKiPhys/src/Particles25.cpp
index 7733b8ddb..2ec9ac5bf 100644
--- a/Phys/LoKiPhys/src/Particles25.cpp
+++ b/Phys/LoKiPhys/src/Particles25.cpp
@@ -35,8 +35,8 @@
* A.Golutvin, P.Koppenburg have been used in the design.
*
* The file contains the functions, requested by Rob Lambert
- * (see <a href="http://savannah.cern.ch/bugs/?47745">LoKi's Savannah portal #47745</a>)
- *
+ * (see <a href="https://its.cern.ch/jira/browse/LHCBPS-1352">LoKi's Savannah portal #47745 - now JIRA 1352</a>)
+ *
* All these functors are to be used within CombineParticles framework only
* and surely completely useless for the regular Loki or Bender application
*
diff --git a/Phys/ParticleMaker/src/BestPIDParticleMaker.cpp b/Phys/ParticleMaker/src/BestPIDParticleMaker.cpp
index de61f0f21..c9a9ce6d9 100644
--- a/Phys/ParticleMaker/src/BestPIDParticleMaker.cpp
+++ b/Phys/ParticleMaker/src/BestPIDParticleMaker.cpp
@@ -137,9 +137,10 @@ StatusCode BestPIDParticleMaker::makeParticles( Particle::Vector & parts ){
if ( !track )
return Error( "Charged ProtoParticle has null track reference !" );
- if (track->states().empty()){
- Warning("Track has empty states. This is likely to be bug https://savannah.cern.ch/bugs/index.php?70979");
- continue ;
+ if ( track->states().empty() ) {
+ Warning( "Track has empty states. This is likely to be bug https://its.cern.ch/jira/browse/LHCBPS-391" )
+ .ignore();
+ continue;
}
TrackTally & tally = trackTally( track->type() );
diff --git a/Phys/ParticleMaker/src/CombinedParticleMaker.cpp b/Phys/ParticleMaker/src/CombinedParticleMaker.cpp
index b289be05d..14034118f 100644
--- a/Phys/ParticleMaker/src/CombinedParticleMaker.cpp
+++ b/Phys/ParticleMaker/src/CombinedParticleMaker.cpp
@@ -167,10 +167,10 @@ StatusCode CombinedParticleMaker::makeParticles( LHCb::Particle::Vector & parts
// Select tracks
if (msgLevel(MSG::VERBOSE)) verbose() << "Trying Track " << track->key() << endmsg;
- if (track->states().empty())
- {
- Warning("Track has empty states. This is likely to be bug https://savannah.cern.ch/bugs/index.php?70979").ignore();
- continue ;
+ if ( track->states().empty() ) {
+ Warning( "Track has empty states. This is likely to be bug https://its.cern.ch/jira/browse/LHCBPS-391" )
+ .ignore();
+ continue;
}
if ( !trSel()->accept(*track) ) continue;
if (msgLevel(MSG::VERBOSE))
diff --git a/Phys/ParticleMaker/src/NoPIDsParticleMaker.cpp b/Phys/ParticleMaker/src/NoPIDsParticleMaker.cpp
index 50da53177..3e33dccfd 100644
--- a/Phys/ParticleMaker/src/NoPIDsParticleMaker.cpp
+++ b/Phys/ParticleMaker/src/NoPIDsParticleMaker.cpp
@@ -100,13 +100,14 @@ StatusCode NoPIDsParticleMaker::makeParticles
if (msgLevel(MSG::VERBOSE)) verbose() << "Trying PP " << *pp << endmsg;
const LHCb::Track* ptrack = pp->track();
- if ( 0==ptrack ) {
- Warning("Charged protoparticle with no Track found. Ignoring.");
- continue ;
+ if ( 0 == ptrack ) {
+ Warning( "Charged protoparticle with no Track found. Ignoring." ).ignore();
+ continue;
}
- if (ptrack->states().empty()){
- Warning("Track has empty states. This is likely to be bug https://savannah.cern.ch/bugs/index.php?70979");
- continue ;
+ if ( ptrack->states().empty() ) {
+ Warning( "Track has empty states. This is likely to be bug https://its.cern.ch/jira/browse/LHCBPS-391" )
+ .ignore();
+ continue;
}
// if ( 0 == pp -> charge () ) { continue ; } // CONTINUE
--
GitLab