Follow-up from "Fix indexing of muon stations in RecSummaryMaker (follow up !3922)"
The numbering of muon stations should be consistent (right now you'd have to remember there is a shift, counting 0-4 instead of 1-5, etc...
In particular https://gitlab.cern.ch/lhcb/LHCb/-/blob/2024-patches/Muon/MuonDAQ/include/MuonDAQ/MuonHitContainer.h?ref_type=heads#L35 should be using enums (already existing) instead of unsigned ints.
The following discussion from !3965 (merged) should be addressed:
-
@rmatev started a discussion: (+6 comments) I guess the enums shouldn't be changed (
nMuonCoordsS0
does exist but I guess corresponds to the removed M1). Please have a look.
Edited by Maarten Van Veghel