Rec merge requestshttps://gitlab.cern.ch/lhcb/Rec/-/merge_requests2024-03-25T10:41:34+01:00https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3829Add StateAt functor and fix CLOSTESTTOBEAM2024-03-25T10:41:34+01:00Andre GuntherAdd StateAt functor and fix CLOSTESTTOBEAMThis adds a functor `STATE_AT` returning the tracks state requested by name from the state location enum. The `CLOSESTTOBEAM` functor utilises this now and thus actually always returns the CTB state or throws if not present. The old beha...This adds a functor `STATE_AT` returning the tracks state requested by name from the state location enum. The `CLOSESTTOBEAM` functor utilises this now and thus actually always returns the CTB state or throws if not present. The old behaviour of `CLOSTESTTOBEAM` is now covered by `TRACKSTATE` which makes it more clear that it is the track defining which state is returned here.
Related to #392Andre GuntherAndre Guntherhttps://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3782Draft: Add basic TAE monitor for Plume2024-03-26T15:57:56+01:00Rosen MatevDraft: Add basic TAE monitor for PlumeGoes with LHCb!4455 lhcb/Rec!3782 lhcb/MooreOnline!328
/cc @fferrariGoes with LHCb!4455 lhcb/Rec!3782 lhcb/MooreOnline!328
/cc @fferrariRTA/2024.03.27Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3758Draft: Adding ThOr functor which assigns a random value to the candidate2024-03-01T15:35:11+01:00Felicia VolleDraft: Adding ThOr functor which assigns a random value to the candidatePURPOSE: Select one random $\pi^\pm$ candidate in the same event as the $\pi^0 \to e^+e^-\gamma$ to be persisted. The Four-vector of the $\pi^\pm$ is needed for the background template.
$1^{st}$ IDEA: Add a Thor functor shuffling the ca...PURPOSE: Select one random $\pi^\pm$ candidate in the same event as the $\pi^0 \to e^+e^-\gamma$ to be persisted. The Four-vector of the $\pi^\pm$ is needed for the background template.
$1^{st}$ IDEA: Add a Thor functor shuffling the candidates in the weighted relation table and select the candidate, which is situated at the front.
EASIER: ThOr functor assigns a random value between 0 and 1 to each candidate. The candidate with the maximum random value is persisted. The corresponding merge request of the HLT2 and sprucing line additions can be found at https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2977 .
FYI: @johndan @tfulghesDaniel JohnsonFelicia VolleDaniel Johnsonhttps://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3738Fix state sets among Pr <-> v1 <-> v3 conversion (+ Add filter on CaloMatch r...2024-03-25T11:53:17+01:00Andre GuntherFix state sets among Pr <-> v1 <-> v3 conversion (+ Add filter on CaloMatch relations)This is best reviewed commit-wise:
1. implements a filter consuming a RelationTable the `from` relation of which are tracks ~"new feature"
2. templates the PrMatchNN such that it can take v3 seed tracks as input (e.g. the output from th...This is best reviewed commit-wise:
1. implements a filter consuming a RelationTable the `from` relation of which are tracks ~"new feature"
2. templates the PrMatchNN such that it can take v3 seed tracks as input (e.g. the output from the relation filter added in 1.)
3. contains the majority of changed files and simplifies/adapts code following LHCb!4429's available state locations ~"bug fix"
<details><summary>Click to expand</summary>
- fixes the conversion from PrSeedTrack -> v1 confusing the EndT state with LastMeasurement (this is causing Calo ref changes!)
- fixes the conversion from v1 Downstream -> v3 Downstream which ignored the BegRich1 and EndRich1 and probably caused undefined behaviour
- fixes states on PrUpstreamTracks: now the tracks actually have a state in the UT which can and is used by the PrKF avoiding unnecessary extrapolation
- fixes loss of information of Ttrack v1 -> v3 conversion
</details>
4. adds two functors working together with the relation filter, namely `GET` and `MIN_ELEMENT_NOTZERO`
Goes with LHCb!4429 and Allen!1433 and Moore!3045
Throughput is not affected :+1: see [HLT2 MR](https://lhcbpr-hlt.web.cern.ch/PerfTests/UpgradeThroughput/Throughput_lhcb-master-mr.10632_Moore_hlt2_fastest_reco_x86_64_v3-el9-gcc13+detdesc-opt+g_2024-02-18_22:13:07_+0100/) vs. [HLT2 master](https://lhcbpr-hlt.web.cern.ch/PerfTests/UpgradeThroughput/Throughput_lhcb-master.2306_Moore_hlt2_fastest_reco_x86_64_v3-el9-gcc13+detdesc-opt+g_2024-02-18_07:21:56_+0100/) and [HLT1(CPU) MR](https://cern.ch/lhcbpr-hlt/PerfTests/UpgradeThroughput/Throughput_lhcb-master-mr.10632_Moore_hlt1_pp_default_x86_64_v3-el9-gcc13+detdesc-opt+g_2024-02-18_22:51:42_+0100) [HLT1(CPU) master](https://cern.ch/lhcbpr-hlt/PerfTests/UpgradeThroughput/Throughput_lhcb-master.2306_Moore_hlt1_pp_default_x86_64_v3-el9-gcc13+detdesc-opt+g_2024-02-18_08:01:47_+0100)
Will close #519 and is related to Moore#657Andre GuntherAnfeng LiAndre Guntherhttps://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3688Draft: add TrackStates Tupler and fix to PrCheatedLongTracking2024-01-24T07:07:07+01:00Renato QuaglianiDraft: add TrackStates Tupler and fix to PrCheatedLongTrackingContext : evaluate the uncertainties of track states assigned to tracks from the kalman fit using cheated long tracks - kalman fitted
TODO :
* Fix scripts / options in Moore tracking developments ( add test with cheated Long tracking ?...Context : evaluate the uncertainties of track states assigned to tracks from the kalman fit using cheated long tracks - kalman fitted
TODO :
* Fix scripts / options in Moore tracking developments ( add test with cheated Long tracking ? )
* Final checks on tuples and analysis of output
* Tupling can be improved using standard services ( but might require special treatment of vector\<vector column storing. More info to store?https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2782Move FSR functionality to LHCb as needed by GenFSR2024-03-28T00:09:03+01:00Michal KrepsMove FSR functionality to LHCb as needed by GenFSR