Run 1/2 code cleanup in Rec master: Rec/Tr
cc @cattanem @rmatev @graven @sstahl
TrackKernel needs to be dealt with last as a lot of the rest of Rec/Tr (and some other parts in Rec) depend on it
PatPV mixes Run 1/2 and upgrade code. It is not trivially obvious if any of the “non-standard” fitters are needed in the upgrade, they may well have offline/monitoring use cases? PatPV, PVOfflineTool (and its dependencies, which are several in this package) PatPV3DFuture and TrackBeamlineVertexFinder are the ones which are definitely needed for the upgrade (some of these operate on track_v1 and some on track_v2 and post the event model cleanup this will all be simplifiable). The options in the python directory are AFAIK quite obsolete. @adudziak what do you think?
PatChecker, TrackCheckers, TrackInterfaces, TrackMonitors, TrackProjectors, TrackTools also mix Run 1/2 and upgrade code, also within individual algorithms when referring to subdetectors (see for example PatChecker/LHCbID2MCParticle). Probably here the simplest is to remove anything with TT/IT/OT/ST/Run2 explicitly in the algorithm/tool name, and then do a second round for the more mixed up cases.
Porting the OTCosmicsProjector to the FT may presumably have relevance for commissioning? @sesen any opinion on this?
TrackAssociators and PatFitParams are Run 1/2 although not all of PatFitParams has been ported to the upgrade (i.e. to Pr/PrFitParams), so prob cleanest to complete that first, then remove. @ldufour any opinion on this?
TrackIdealPR is as written Run 1/2 but we may want something analogous in the upgrade? In any case it could be removed and then resurrected if needed.
TrackMCTools I think is now mainly Run 1/2, the relevant parts having been ported to Pr/PrMCTools. IdealStateCreator is important to keep. The GhostClassification code may logically have some use but would need a complete rewrite, analogous to TrackIdealPR.
ParametarizedKalman, TrackExtrapolators, TrackFitEvent, TrackFitter, TrackVectorFit, TrackUtils are still entirely or almost entirely relevant to the upgrade.