Skip to content

TrackBestTrackCreator Default init TrackData

Christopher Rob Jones requested to merge TrackBestTrackCreator-DefaultInitTrackData into master

Adds missing default member data initialisation to TrackData class.

Addresses undefined behaviour sanitizer error

/workspace/build/REC/REC_HEAD/Tr/TrackUtils/src/TrackBestTrackCreator.h:53:9: runtime error: load of value 192, which is not a valid value for type 'bool'
    #0 0x7f20a1664ce9 in TrackData /workspace/build/REC/REC_HEAD/Tr/TrackUtils/src/TrackBestTrackCreator.h:53
    #1 0x7f20a1664ce9 in construct<(anonymous namespace)::TrackData, (anonymous namespace)::TrackData> /cvmfs/lhcb.cern.ch/lib/lcg/releases/gcc/7.3.0/x86_64-centos7/include/c++/7.3.0/ext/new_allocator.h:136
    #2 0x7f20a1664ce9 in construct<(anonymous namespace)::TrackData, (anonymous namespace)::TrackData> /cvmfs/lhcb.cern.ch/lib/lcg/releases/gcc/7.3.0/x86_64-centos7/include/c++/7.3.0/bits/alloc_traits.h:475
    #3 0x7f20a1664ce9 in emplace_back<(anonymous namespace)::TrackData> /cvmfs/lhcb.cern.ch/lib/lcg/releases/gcc/7.3.0/x86_64-centos7/include/c++/7.3.0/bits/vector.tcc:100
    #4 0x7f20a1664ce9 in push_back /cvmfs/lhcb.cern.ch/lib/lcg/releases/gcc/7.3.0/x86_64-centos7/include/c++/7.3.0/bits/stl_vector.h:954
    #5 0x7f20a1664ce9 in TrackBestTrackCreator::operator()(Gaudi::Functional::details::vector_of_const_<KeyedContainer<LHCb::Event::v1::Track, Containers::KeyedObjectManager<Containers::hashmap> > > const&) const /workspace/build/REC/REC_HEAD/Tr/TrackUtils/src/TrackBestTrackCreator.cpp:140

https://lhcb-nightlies.cern.ch/nightly/lhcb-sanitizers/build/6/

FYI @sstahl @graven @sponce

Merge request reports