Stripping issueshttps://gitlab.cern.ch/lhcb/Stripping/-/issues2018-05-02T17:42:40+02:00https://gitlab.cern.ch/lhcb/Stripping/-/issues/1Update Stripping archive check-hlt-filters2018-05-02T17:42:40+02:00Stefanie ReichertUpdate Stripping archive check-hlt-filtersUpdate reference for StrippingArchive.check-hlt-filters when new TCK becomes available.Update reference for StrippingArchive.check-hlt-filters when new TCK becomes available.Stripping34 pp 2018 data (2018-patches) campaignCarlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/2Update refs after BTagging errors are fixed2018-06-05T10:11:06+02:00Stefanie ReichertUpdate refs after BTagging errors are fixedBTag_Global.BTaggingTool ERROR BTaggingTool:: FlavourTaggingTaggerID info already set: erasing it StatusCode=FAILURE
@kheinick is working on this issue and we will need to update the refernce for the DaVinci tests accordingly aft...BTag_Global.BTaggingTool ERROR BTaggingTool:: FlavourTaggingTaggerID info already set: erasing it StatusCode=FAILURE
@kheinick is working on this issue and we will need to update the refernce for the DaVinci tests accordingly afterwards.Stripping34 pp 2018 data (2018-patches) campaignCarlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/3Import error S34 archives2018-05-02T17:42:24+02:00Stefanie ReichertImport error S34 archivesWhen running make test ARGS='-R StrippingArchive.instantiate-all-strip', we observe the following
[WARNING] Submodule StrippingArchive.Stripping34.StrippingRD.StrippingKshort2eePiPi raises the exception "Name MyVeloProtos has already b...When running make test ARGS='-R StrippingArchive.instantiate-all-strip', we observe the following
[WARNING] Submodule StrippingArchive.Stripping34.StrippingRD.StrippingKshort2eePiPi raises the exception "Name MyVeloProtos has already been used. Pick a new one." and will be skipped !
as the lines are running, we suspect this is not a problem with the line but with the way the test is set up.Stripping34 pp 2018 data (2018-patches) campaignCarlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/4Produce missing documentation for Stripping29r22018-05-17T15:08:06+02:00Carlos Vazquez SierraProduce missing documentation for Stripping29r2Produce documentation for:
* Stripping29r2
Produce documentation for:
* Stripping29r2
Carlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/5Prepare Stripping30r2 and Stripping30r32018-06-27T10:00:17+02:00Carlos Vazquez SierraPrepare Stripping30r2 and Stripping30r3Prepare Stripping 30r2 (Pbp 2016) & Stripping 30r3 (pPb 2016):
* https://its.cern.ch/jira/browse/LBOPG-92
* StrippingIFT selections, Stripping30rx settings, data and test files *ported* from Stripping30 to Stripping-s28 branch.
* Use Rec...Prepare Stripping 30r2 (Pbp 2016) & Stripping 30r3 (pPb 2016):
* https://its.cern.ch/jira/browse/LBOPG-92
* StrippingIFT selections, Stripping30rx settings, data and test files *ported* from Stripping30 to Stripping-s28 branch.
* Use Reco16pLead_Run187018_Pbp and Reco16pLead_Run186558_pPb.
* Use Stripping-s28 and DV v41r4p5:
```
LbLogin -c x86_64-slc6-gcc49-opt
lb-dev DaVinci/v41r4p5
cd DaVinciDev_v41r4p5
git lb-use Stripping
git lb-checkout Stripping/Stripping-s28 Phys/StrippingSelections
make configure && make
```PbPb 2015 & Pbp/pPb 2016 campaigns (Stripping-s28 branch)Carlos Vazquez SierraStefanie ReichertEmilie Amandine MauriceCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/6Prepare Stripping332018-09-14T14:45:15+02:00Carlos Vazquez SierraPrepare Stripping33Prepare Stripping 33 (pNe SMOG 2017):
* https://its.cern.ch/jira/browse/LBOPG-90
* StrippingIFT selections, Stripping33 settings, data and test files *ported* from stripping32-patches to Stripping29 branch.
* Use Reco17aSmog_Run202253.
*...Prepare Stripping 33 (pNe SMOG 2017):
* https://its.cern.ch/jira/browse/LBOPG-90
* StrippingIFT selections, Stripping33 settings, data and test files *ported* from stripping32-patches to Stripping29 branch.
* Use Reco17aSmog_Run202253.
* Use Stripping29 and DV v42r7p2:
```
LbLogin -c x86_64-slc6-gcc62-opt
lb-dev DaVinci/v42r7p2
cd DaVinciDev_v42r7p2
git lb-use Stripping
git lb-checkout Stripping/Stripping29 Phys/StrippingSelections
make configure && make
```
pNe 2017 & pp 5 TeV 2017 campaigns (Stripping29 branch)Carlos Vazquez SierraStefanie ReichertEmilie Amandine MauriceNicole SkidmoreCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/7Prepare Stripping31r22018-06-26T16:18:41+02:00Carlos Vazquez SierraPrepare Stripping31r2Prepare Stripping 31r2 (PbPb 2015):
* https://its.cern.ch/jira/browse/LBOPG-94
* Use Reco15aLead15_Run169106_PbPb.
* Use Stripping-s28 and DV v41r4p5:
```
LbLogin -c x86_64-slc6-gcc49-opt
lb-dev DaVinci/v41r4p5
cd DaVinciDev_v41r4p5
git...Prepare Stripping 31r2 (PbPb 2015):
* https://its.cern.ch/jira/browse/LBOPG-94
* Use Reco15aLead15_Run169106_PbPb.
* Use Stripping-s28 and DV v41r4p5:
```
LbLogin -c x86_64-slc6-gcc49-opt
lb-dev DaVinci/v41r4p5
cd DaVinciDev_v41r4p5
git lb-use Stripping
git lb-checkout Stripping/Stripping-s28 Phys/StrippingSelections
make configure && make
```PbPb 2015 & Pbp/pPb 2016 campaigns (Stripping-s28 branch)Carlos Vazquez SierraStefanie ReichertEmilie Amandine MauriceCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/8Prepare Stripping322018-09-14T14:43:17+02:00Carlos Vazquez SierraPrepare Stripping32Prepare Stripping 32 (5 TeV pp 2017):
* https://its.cern.ch/jira/browse/LBOPG-90
* Stripping32 settings, data and test files *ported* from stripping32-patches to Stripping29 branch.
* Use Reco17_5TeV_Run202214.py
* Use Stripping29 and DV...Prepare Stripping 32 (5 TeV pp 2017):
* https://its.cern.ch/jira/browse/LBOPG-90
* Stripping32 settings, data and test files *ported* from stripping32-patches to Stripping29 branch.
* Use Reco17_5TeV_Run202214.py
* Use Stripping29 and DV v42r7p2:
```
LbLogin -c x86_64-slc6-gcc62-opt
lb-dev DaVinci/v42r7p2
cd DaVinciDev_v42r7p2
git lb-use Stripping
git lb-checkout Stripping/Stripping29 Phys/StrippingSelections
make configure && make
```
* The SL group @ismith have requested only to run the B2DMuNuX module.
* The QEE group @mmarinan have requested to run the ConvertedPhoton lines.pNe 2017 & pp 5 TeV 2017 campaigns (Stripping29 branch)Carlos Vazquez SierraIwan Thomas Smithiwan.smith@cern.chStefanie ReichertAnna LupatoNicole SkidmoreMatthieu MarinangeliCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/9Produce missing documentation for Stripping342018-06-13T17:12:15+02:00Carlos Vazquez SierraProduce missing documentation for Stripping34Produce documentation after campaign completion for:
* Stripping34Produce documentation after campaign completion for:
* Stripping34https://gitlab.cern.ch/lhcb/Stripping/-/issues/10FATAL when testing Stripping342023-03-17T10:21:48+01:00Carlos Vazquez SierraFATAL when testing Stripping34Problems with StdHltJets when testing the Stripping (error below). Actions to be taken:
* Run using a dbg platform and gdb to see if I can sort out the problem.
* If can not be easily sorted out: replace StdHltJets with StdJets.
Try to...Problems with StdHltJets when testing the Stripping (error below). Actions to be taken:
* Run using a dbg platform and gdb to see if I can sort out the problem.
* If can not be easily sorted out: replace StdHltJets with StdJets.
Try to sort out this during the night and run a 100k test.
```
StdHltJetsJetBuilderSeq INFO Member list: HltJetBuilder/StdHltJets
StdHltJets.LoKi::FastJetMaker.MomentumCombiner INFO Only 4-momenta sum will be used (no ParticleTransporter specified)
IOHandler<SmartRefBase>::onWrite> Found invalid smart reference with object having no parent.
BhadronCompleteEvent_OStream FATAL std::exception during createRep for '/Event/BhadronCompleteEvent/Rec/StdHltPF/CaloHypos' KeyedContainer<LHCb::CaloHypo,Containers::KeyedObjectManager<Containers::hashmap> >
BhadronCompleteEvent_OStream FATAL Class:SmartRefBase> Exception in object I/OIOHandler<SmartRefBase>::onWrite> Found invalid smart reference with object having no parent.
BhadronCompleteEvent_OStream FATAL Standard std::exception is caught
BhadronCompleteEvent_OStream ERROR Class:SmartRefBase> Exception in object I/OIOHandler<SmartRefBase>::onWrite> Found invalid smart reference with object having no parent.
DSTWriterBhadronCompleteEvent FATAL Standard std::exception is caught
DSTWriterBhadronCompleteEvent ERROR Class:SmartRefBase> Exception in object I/OIOHandler<SmartRefBase>::onWrite> Found invalid smart reference with object having no parent.
MyDSTWriterMainSeq FATAL Standard std::exception is caught
MyDSTWriterMainSeq ERROR Class:SmartRefBase> Exception in object I/OIOHandler<SmartRefBase>::onWrite> Found invalid smart reference with object having no parent.
StrippingMainSequence FATAL Standard std::exception is caught
```Stripping34 pp 2018 data (2018-patches) campaignCarlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/11Prepare Stripping342022-05-06T13:34:58+02:00Carlos Vazquez SierraPrepare Stripping34Immediate tasks to be completed towards Stripping34:
* [x] Publish retentions and bandwidths using Reco18 data:
* [x] Produce retentions table using Reco18_Run206538.
* [x] Update trigger rates and produce bandwidths table.
* [x] ...Immediate tasks to be completed towards Stripping34:
* [x] Publish retentions and bandwidths using Reco18 data:
* [x] Produce retentions table using Reco18_Run206538.
* [x] Update trigger rates and produce bandwidths table.
* [x] Update references for nightlies.
* [x] Tag 2018-patches and freeze into run2-patches.
* [x] Update DaVinci reference tests for nightlies.
* [x] Prepare StrippingCache and ask for a DV tag.
* [x] Prepare the production steps.
* [x] Test production steps.
* [x] Announce steps and ask for validation sample.
* [x] Wait for feedback from 1st validation.
* [x] Validate FT and proceed to process the full data range.Stripping34 pp 2018 data (2018-patches) campaignCarlos Vazquez SierraStefanie ReichertCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/12New FT calibration2018-06-12T21:57:01+02:00Stefanie ReichertNew FT calibrationThe new FT calibrations should enter S34. FYI @mschille @kheinickThe new FT calibrations should enter S34. FYI @mschille @kheinickhttps://gitlab.cern.ch/lhcb/Stripping/-/issues/13BTagging tool2018-08-28T10:00:04+02:00Stefanie ReichertBTagging toolBTag_Global.BTaggingTool ERROR BTaggingTool:: FlavourTaggingTaggerID info already set: erasing it StatusCode=FAILURE
--> this should be fixed (fix in place for 2018-patches) and for the sake of a clean stack, the FT bug in the SS...BTag_Global.BTaggingTool ERROR BTaggingTool:: FlavourTaggingTaggerID info already set: erasing it StatusCode=FAILURE
--> this should be fixed (fix in place for 2018-patches) and for the sake of a clean stack, the FT bug in the SSPi and SSP taggers should be addressed as well in 2017-patches (Stripping29 branch)https://gitlab.cern.ch/lhcb/Stripping/-/issues/14Fix BCharmless lines in all Run-2 stripping campaigns2019-04-08T03:29:16+02:00Carlos Vazquez SierraFix BCharmless lines in all Run-2 stripping campaigns* First fix to run2-patches (to be picked up by the end-of-the-year stripping), see https://gitlab.cern.ch/lhcb/Stripping/merge_requests/813
* To be propagated to run2 legacy re-stripping.
Requested by @pluca .* First fix to run2-patches (to be picked up by the end-of-the-year stripping), see https://gitlab.cern.ch/lhcb/Stripping/merge_requests/813
* To be propagated to run2 legacy re-stripping.
Requested by @pluca .Carlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/15Automatic checks2019-07-04T17:47:52+02:00Stefanie ReichertAutomatic checks* if MDSTFlag=True
* if old streams are used
* if ERRORS appear when creating dbase and archives
@cvazquez - could use Gitlab CI for the first two. The third is just a matter of updating create_archives.py* if MDSTFlag=True
* if old streams are used
* if ERRORS appear when creating dbase and archives
@cvazquez - could use Gitlab CI for the first two. The third is just a matter of updating create_archives.pyCarlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/16Create documentation for Stripping322018-10-30T17:00:20+01:00Carlos Vazquez SierraCreate documentation for Stripping32Create documentation for Stripping32 campaign.Create documentation for Stripping32 campaign.pNe 2017 & pp 5 TeV 2017 campaigns (Stripping29 branch)Nicole SkidmoreNicole Skidmorehttps://gitlab.cern.ch/lhcb/Stripping/-/issues/17Prepare Stripping33r12018-11-23T13:03:58+01:00Carlos Vazquez SierraPrepare Stripping33r1Prepare Stripping 33r1 (pNe SMOG 2017):
* https://its.cern.ch/jira/browse/LBOPG-97
* Full re-stripping of Stripping33 due to missing lines.
* Update selections and settings as desired, can add new lines.
* Use Reco17aSmog_Run202253.
* Us...Prepare Stripping 33r1 (pNe SMOG 2017):
* https://its.cern.ch/jira/browse/LBOPG-97
* Full re-stripping of Stripping33 due to missing lines.
* Update selections and settings as desired, can add new lines.
* Use Reco17aSmog_Run202253.
* Use Stripping29 and DV v42r8:
```
LbLogin -c x86_64-slc6-gcc62-opt
lb-dev DaVinci/v42r8
cd DaVinciDev_v42r8
git lb-use Stripping
git lb-checkout Stripping/Stripping29 Phys/StrippingSelections
git lb-checkout Stripping/Stripping29 Phys/StrippingSettings
make configure && make
```
**First deadline for testing and developing lines is set to 14th October.**pNe 2017 & pp 5 TeV 2017 campaigns (Stripping29 branch)Carlos Vazquez SierraEmilie Amandine MauriceNicole SkidmoreDaniele MarangottoCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/18Fix failing tests in the nightlies2019-07-04T17:47:27+02:00Carlos Vazquez SierraFix failing tests in the nightliesAlso see: https://gitlab.cern.ch/lhcb/Phys/merge_requests/435
* [ ] Clean up options file in DaVinciTests which are not used anymore (i.e. S33).
**lhcb-2016-patches:**
* DaVinci:
* [ ] stripping.test_stripping28_collision16_reco16
...Also see: https://gitlab.cern.ch/lhcb/Phys/merge_requests/435
* [ ] Clean up options file in DaVinciTests which are not used anymore (i.e. S33).
**lhcb-2016-patches:**
* DaVinci:
* [ ] stripping.test_stripping28_collision16_reco16
* [ ] stripping.test_stripping28r1_collision16_reco16
* [ ] stripping.test_stripping281r1p1_collision16_reco16
* [ ] stripping.test_stripping31_collision15_reco15aLead
**lhcb-2017-patches:**
* DaVinci:
* [ ] stripping.test_stripping29r2_collision17_reco17
**lhcb-2018-patches:**
* DaVinci:
* [ ] stripping.test_stripping34r0p1_collision18_reco18
**lhcb-head:**
* Stripping:
* [ ] StrippingArchive.check-hlt-filters
* [ ] StrippingArchive.instantiate-all-strip
* [ ] StrippingSelections.test_input_output_locations
* DaVinci:
* [x] stripping.test_express_appconfig
* [ ] stripping.test_v0
* [ ] fsrs.davinci-strip-magdown (DisplVertices_Utils)
* [ ] fsrs.davinci-strip-magup (DisplVertices_Utils)Fix failing tests in the nightliesCarlos Vazquez SierraNicole SkidmoreCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/20Deprecate twiki page - documentation in Gitlab wiki2019-07-04T17:47:27+02:00Carlos Vazquez SierraDeprecate twiki page - documentation in Gitlab wikiDeprecate twiki page - documentation in Gitlab wiki Deprecate twiki page - documentation in Gitlab wiki Carlos Vazquez SierraNicole SkidmoreCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/22Analyse results for future restripping campaigns2018-11-07T00:39:46+01:00Nicole SkidmoreAnalyse results for future restripping campaignsDeadline 15th OctoberDeadline 15th OctoberCarlos Vazquez SierraNicole SkidmoreCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/23Prepare IFT repositories for heavy ion runs2018-10-30T16:59:44+01:00Nicole SkidmorePrepare IFT repositories for heavy ion runsCarlos Vazquez SierraNicole SkidmoreCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/24Prepare Stripping 35 (PbPb 2018)2019-01-30T20:01:41+01:00Nicole SkidmorePrepare Stripping 35 (PbPb 2018)* https://its.cern.ch/jira/browse/LBOPG-98
* Use Reco15aLead15_Run169106_PbPb.py
* Use S35_repos and DV v44r6:
```
lb-dev DaVinci/v44r6
cd DaVinciDev_v44r6
git lb-use Stripping
git lb-checkout Stripping/S35_repos Phys/StrippingSelection...* https://its.cern.ch/jira/browse/LBOPG-98
* Use Reco15aLead15_Run169106_PbPb.py
* Use S35_repos and DV v44r6:
```
lb-dev DaVinci/v44r6
cd DaVinciDev_v44r6
git lb-use Stripping
git lb-checkout Stripping/S35_repos Phys/StrippingSelections
make configure && make
```PbPb & PbNe 2018 campaignsCarlos Vazquez SierraEmilie Amandine MauriceNicole SkidmoreDaniele MarangottoCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/25Prepare Stripping S35r1 (PbNe 2018)2019-02-01T13:39:25+01:00Nicole SkidmorePrepare Stripping S35r1 (PbNe 2018)* https://its.cern.ch/jira/browse/LBOPG-99
* Use Reco15aLead15_Run168665_PbAr.py
* Use S35r1_repos and DV v44r6:
```
lb-dev DaVinci/v44r6
cd DaVinciDev_v44r6
git lb-use Stripping
git lb-checkout Stripping/S35r1_repos Phys/StrippingSelec...* https://its.cern.ch/jira/browse/LBOPG-99
* Use Reco15aLead15_Run168665_PbAr.py
* Use S35r1_repos and DV v44r6:
```
lb-dev DaVinci/v44r6
cd DaVinciDev_v44r6
git lb-use Stripping
git lb-checkout Stripping/S35r1_repos Phys/StrippingSelections
make configure && make
```PbPb & PbNe 2018 campaignsCarlos Vazquez SierraEmilie Amandine MauriceNicole SkidmoreDaniele MarangottoCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/27Improve StrippingArchives and CommonParticlesArchive2019-07-04T17:47:28+02:00Carlos Vazquez SierraImprove StrippingArchives and CommonParticlesArchiveStrippingArchives contains archived line builders from all the campaigns, as well as CommonParticlesArchives which contains all particle containers from each campaign. This is a really inefficient way to preserve data and makes the Strip...StrippingArchives contains archived line builders from all the campaigns, as well as CommonParticlesArchives which contains all particle containers from each campaign. This is a really inefficient way to preserve data and makes the Stripping project unnecessarily large.
We should explore alternatives during LS2. An idea would be to create a package under DBASE, i.e. StrippingArchives, and add and release a new version every time a Stripping version is archived (DBASE/StrippingArchives/Stripping_XX). Same can be done with CommonParticlesArchives. However this needs some deep modifications to the Stripping code in order to pick up everything in the correct way.
Need to clean up DaVinci tests (if needed!) after doing this.Carlos Vazquez SierraNicole SkidmoreCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/29Merge 2018-patches to master and major clean-up2019-07-04T17:47:28+02:00Carlos Vazquez SierraMerge 2018-patches to master and major clean-upAfter S35 and S35r1 we should merge 2018-patches into master and go through a modernisation of the code. Namely:
* Clean up and fix nightlies tests for Stripping and DaVinci (see #18 ) for *all branches* (master, 2018-patches, Stripping...After S35 and S35r1 we should merge 2018-patches into master and go through a modernisation of the code. Namely:
* Clean up and fix nightlies tests for Stripping and DaVinci (see #18 ) for *all branches* (master, 2018-patches, Stripping-s28, Stripping29).
* Rename Stripping-s28 to 2016-patches and Stripping29 to 2017-patches (see #21 ).
* Fixes for new LoKi functors context (see https://gitlab.cern.ch/lhcb/Analysis/merge_requests/423 and !831 ) for master and 2018-patches:
- Should we fix it for Stripping-s28 and Stripping29 as well?
CC/ @erodrigu @clemenci Fix failing tests in the nightliesCarlos Vazquez SierraNicole SkidmoreCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/30Create documentation for s33r12018-11-23T17:07:23+01:00Carlos Vazquez SierraCreate documentation for s33r1@nskidmor I fully assign this task to you. I close the S33r1 milestone already.@nskidmor I fully assign this task to you. I close the S33r1 milestone already.Nicole SkidmoreNicole Skidmorehttps://gitlab.cern.ch/lhcb/Stripping/-/issues/31Prepare Stripping 21r1p2 (pp 2011) and Stripping 21r0p2 (pp 2012)2019-07-04T17:47:28+02:00Carlos Vazquez SierraPrepare Stripping 21r1p2 (pp 2011) and Stripping 21r0p2 (pp 2012)* https://its.cern.ch/jira/browse/LBOPG-103
* https://its.cern.ch/jira/browse/LBOPG-103
Re-stripping of Run 1 & Run 2 LHCb dataCarlos Vazquez SierraNicole SkidmoreCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/32Prepare Stripping 34r0p1 (pp 2018)2019-04-08T03:02:26+02:00Carlos Vazquez SierraPrepare Stripping 34r0p1 (pp 2018)* https://its.cern.ch/jira/browse/LBOPG-102
* Use Reco18_DataType2018_Run214741.py
* Use 2018-patches and DV v44r7:
```
lb-dev DaVinci/v44r7
cd DaVinciDev_v44r7
git lb-use Stripping
git lb-checkout Stripping/2018-patches Phys/Stripping...* https://its.cern.ch/jira/browse/LBOPG-102
* Use Reco18_DataType2018_Run214741.py
* Use 2018-patches and DV v44r7:
```
lb-dev DaVinci/v44r7
cd DaVinciDev_v44r7
git lb-use Stripping
git lb-checkout Stripping/2018-patches Phys/StrippingSelections
git lb-checkout Stripping/2018-patches Phys/StrippingSettings
make
```Re-stripping of Run 1 & Run 2 LHCb dataCarlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/33Prepare Stripping 24r2 (pp 2015)2019-07-04T17:47:29+02:00Carlos Vazquez SierraPrepare Stripping 24r2 (pp 2015)* https://its.cern.ch/jira/browse/LBOPG-104
* https://its.cern.ch/jira/browse/LBOPG-104
Re-stripping of Run 1 & Run 2 LHCb dataNicole SkidmoreNicole Skidmorehttps://gitlab.cern.ch/lhcb/Stripping/-/issues/34Prepare Stripping 29r2p1 (pp 2017)2019-07-04T17:47:29+02:00Carlos Vazquez SierraPrepare Stripping 29r2p1 (pp 2017)* https://its.cern.ch/jira/browse/LBOPG-106
* https://its.cern.ch/jira/browse/LBOPG-106
Re-stripping of Run 1 & Run 2 LHCb dataNicole SkidmoreNicole Skidmorehttps://gitlab.cern.ch/lhcb/Stripping/-/issues/35Fixes for Stripping21rXp1 campaigns (stripping21-patches)2019-02-13T18:04:51+01:00Carlos Vazquez SierraFixes for Stripping21rXp1 campaigns (stripping21-patches)Repositories for Stripping21rXp1 campaigns (2011 & 2012 re-stripping campaigns) need to be "modernised" in order to have the same structure as Run 2 campaigns.
The branch is ```stripping21-patches```. Please check out the corresponding ...Repositories for Stripping21rXp1 campaigns (2011 & 2012 re-stripping campaigns) need to be "modernised" in order to have the same structure as Run 2 campaigns.
The branch is ```stripping21-patches```. Please check out the corresponding package from this branch, create a new branch and work on it. The main tasks to carry out here are:
## Distribute the line builders per WG
All line builders in Phys/StrippingSelections are mixed together, and this has to be sorted out. To do this, an idea would be to ```grep``` per WG and move the files to the corresponding WG folder (that has to be created). An example in bash (needs to be tested) to classify QEE, B&Q and RD builders (should be done for all WGs) would be (to be ran at python/StrippingSelections):
```
for wg in BandQ QEE RD
do
mkdir Stripping${wg} && grep -l -Z -r "\['${wg}'\]" . | xargs -0 -I{} mv {} Stripping${wg}/
done
```
After the classification is done, auxiliar python files have to be added to the WG folders as it is done for 2018-patches (please use this branch as a guideline). To know which files should be imported and which not, one can check the ```__init__``` file in python/StrippingSelections and reproduce the same imports but per WG (each WG folder needs an ```__init__``` file). More additional files might be needed, i.e. ```Utils.py```, please use 2018-patches as a guideline on what put there (if you have doubts please let me know). Also, please be very careful and always compare to 2018-patches so you are sure you are not missing any file.
**Addendum:** it seems some of the builders do not use the current structure of ```default_config```, hence they are not parseable by the testing scripts. This should be fixed. Also, some of the builders do not include a WG tag. Liaisons should be requested to classify these builders.
## Fix the test scripts to test from Selections
There are two different test scripts, one for Run 1 and another one for Run 2. This is because the structure is different in Selections (see above). Once the Selections are fixed, these scripts need to be updated as well (for both users and liaisons). As before, use 2018-patches as a guideline. You might need to do changes as well to the ```StrippingStream``` logic (or any Configurables that affects the call of any line builder by the dictionary name), which is hosted in the Stripping project as well. Just by having a look to the test script, you will see which Configurables are used and therefore what needs to be updated in case there is a failure when running the script. **Please be sure the tests are running for all WGs.**
## Fix the test scripts to test from Settings
Same as above, but running from Settings instead of Selections. Changes here should be minimal, if Settings needs to be changed, please let me know. You can use Stripping21(r1) settings for this test. Just by having a look to the test script, you will see which Configurables are used and therefore what needs to be updated in case there is a failure when running the script. **Please be sure the tests are running for all WGs.**
## Final clean-up and assure consistency
Clean-up the old test and data files (add new db tags) and utils for liaisons, i.e. dictionaries collection. Also, do a global check to be sure everything is consistent.
## Propagate changes to StrippingArchive
This is the most complicated part, ensure we can run previous Run 1 campaigns Stripping21(rXp0) from the archive and there are zero problems. A similar work as with Selections should be done here but in StrippingArchive (be careful of differences with ```default_config```). Changes to some Configurables may be needed as well. This should be left for the end, as it only affects the AppConfig options and the coordinators tests.
Once a task is completed, please tick it below:
* [x] Distribute the line builders per WG @mmarinan
* [x] Fix the test scripts to test from Selections @ausachov
* [x] Fix the test scripts from test from Settings @ausachov
* [x] Final clean-up @cvazquez
* [x] Propagate changes to StrippingArchive @cvazquez @nskidmor Re-stripping of Run 1 & Run 2 LHCb dataCarlos Vazquez SierraVitalii LisovskyiMatthieu MarinangeliAndrii UsachovCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/36Problems with Run 1 re-stripping campaigns2019-03-20T15:24:03+01:00Carlos Vazquez SierraProblems with Run 1 re-stripping campaigns## Unsolved:
* Overtiming with B2SS lines (@jcidvida ).
## Waiting for action:
* Problems with gluino & jet lines (GenericVertexFinder fails) (@mmarinan ):
* Needs feedback from @wouter .
## Unsolved:
* Overtiming with B2SS lines (@jcidvida ).
## Waiting for action:
* Problems with gluino & jet lines (GenericVertexFinder fails) (@mmarinan ):
* Needs feedback from @wouter .
Re-stripping of Run 1 & Run 2 LHCb dataCarlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/37Prepare Stripping 28r2 (pp 2016)2019-07-04T17:47:29+02:00Carlos Vazquez SierraPrepare Stripping 28r2 (pp 2016)* https://its.cern.ch/jira/browse/LBOPG-105* https://its.cern.ch/jira/browse/LBOPG-105Re-stripping of Run 1 & Run 2 LHCb dataCarlos Vazquez SierraNicole SkidmoreCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Stripping/-/issues/38Clean up stripping logs for run1+2 campaigns2019-07-04T17:47:30+02:00Nicole SkidmoreClean up stripping logs for run1+2 campaignsThe logs are a mess of warnings and errors. A lot of these are well known and can be turned off. Maybe a debug setting?The logs are a mess of warnings and errors. A lot of these are well known and can be turned off. Maybe a debug setting?Nicole SkidmoreNicole Skidmorehttps://gitlab.cern.ch/lhcb/Stripping/-/issues/39segmentation violation during DST writing after selection with `DTF_FUN`2019-12-23T12:24:42+01:00Marian Stahlmarian.stahl@cern.chsegmentation violation during DST writing after selection with `DTF_FUN`# Context
This seg fault happens very rarely, and is holding back the current stripping campaigns. <br>
It was noticed in 2016 data with the `Xic2LambdaKPi` module, but it's likely that also other lines are affected.
# Description
The s...# Context
This seg fault happens very rarely, and is holding back the current stripping campaigns. <br>
It was noticed in 2016 data with the `Xic2LambdaKPi` module, but it's likely that also other lines are affected.
# Description
The seg fault occurs when trying to write the DST after a candidate for `StrippingXic2LambdaKPi_XicpLine` was found. The code runs fine when [both `DTF_FUN` cuts](https://gitlab.cern.ch/lhcb/Stripping/blob/stripping24r2-28r2-patches/Phys/StrippingSelections/python/StrippingSelections/StrippingCharm/StrippingXic2LambdaKPi.py#L83) of the mother combination are removed or replaced by their non-DTF equivalents.
## Possible source of error
It seems as if a vertex has been modified/removed? by the DTF, such that the link provided to the DST writers points nowhere.
## How to move forward?
The quick and easy solution is to remove cuts on `DTF_FUN` functors. This is not a big issue for the `Xic2LambdaKPi` module, but would certainly harm the [`XicToSigmaKPi`](https://gitlab.cern.ch/lhcb/Stripping/blob/2017-patches/Phys/StrippingSelections/python/StrippingSelections/StrippingCharm/StrippingXicToSigmaKPi.py) lines which rely heavily on the DTF (see also the discussion in https://groups.cern.ch/group/lhcb-reconstruction/Lists/Archive/Flat.aspx?RootFolder=%2Fgroup%2Flhcb%2Dreconstruction%2FLists%2FArchive%2FReconstruction%20of%20Sigma%2B%20%2D%20p%20pi0&FolderCTID=0x0120020030FF8979BD9D1640BD2549BA2063796A). I would like to keep the Sigma lines, since they give a hint whether or not it is feasible to write trigger lines for them in Run3.<br>
Having said that, it would be much appreciated if @ibelyaev and @wouter have a look, to possibly find and fix the source of the problem.
## More (random) information
- The event that causes the trouble is a $`\Xi_c^+ \to \Lambda K_S^0 \pi^+`$ candidate. In that event, the $`\Lambda`$ is DD and $`K_S^0`$ LL.
- Switching off the `dstWriter` sequence (as it's done in the users tests) doesn't cause a seg fault.
- Log files:
liaisons testing script on the problematic RDST running only `Xic2LambdaKPi`<br>
[liaisons_Xic2LambdaKPi_only_unmodified_default_verbosity.log](/uploads/bc39b4d3b04c9b7eeeb1bc9027ab68b6/liaisons_Xic2LambdaKPi_only_unmodified_default_verbosity.log)<br>
... same in DEBUG mode<br>
[liaisons_Xic2LambdaKPi_only_unmodified_debug.log](/uploads/f7fc6e3e41e837315e14082cbd59b296/liaisons_Xic2LambdaKPi_only_unmodified_debug.log)<br>
... and switching off `dstWriter` sequence. The selection that passes here is the one triggering the seg fault<br>
[users_Xic2LambdaKPi_KS_LL_L_DD.log](/uploads/6f7ae5180a9db9e6e92569f350c8affc/users_Xic2LambdaKPi_KS_LL_L_DD.log)Marian Stahlmarian.stahl@cern.chMarian Stahlmarian.stahl@cern.chhttps://gitlab.cern.ch/lhcb/Stripping/-/issues/40Warnings about PatDownstream in IFT campaigns2023-05-18T12:03:02+02:00Nicole SkidmoreWarnings about PatDownstream in IFT campaignsWhen building the strippingcaches in DV 2018-patches we get the warning
```
[WARNING] Submodule StrippingArchive.Stripping30r2.StrippingCalib.StrippingTrackEffDownMuon raises the exception "cannot import name PatDownstream" and will be s...When building the strippingcaches in DV 2018-patches we get the warning
```
[WARNING] Submodule StrippingArchive.Stripping30r2.StrippingCalib.StrippingTrackEffDownMuon raises the exception "cannot import name PatDownstream" and will be skipped !
```
for S30r3, S31r2 and S30r2.
We know the origin of this problem (see https://gitlab.cern.ch/lhcb/Stripping/-/merge_requests/1413 for how we fixed it there) but in these particular cases it is harmless, these are IFT campaigns and so dont use Calib lines. However the warnings are annoying.
The quickest remedy is to simply delete the useless archives in these campaigns https://gitlab.cern.ch/lhcb/Stripping/-/tree/2018-patches/Phys/StrippingArchive/python/StrippingArchive/Stripping31r2. This activity should be seen as part of the clean up of redundant archives.Federico Leo RediNathan Allen Griesernathan.allen.grieser@cern.chFederico Leo Redihttps://gitlab.cern.ch/lhcb/Stripping/-/issues/43chore: update default branch and README content2023-03-15T17:24:18+01:00Eduardo Rodrigueschore: update default branch and README contentHi @fredi, @masmith, I was looking around and was surprised to realise that the default branch for Stripping is `2018-branches`. I would have assumed it is `run2-patches` since a while, as the default legacy branch by construction. Can y...Hi @fredi, @masmith, I was looking around and was surprised to realise that the default branch for Stripping is `2018-branches`. I would have assumed it is `run2-patches` since a while, as the default legacy branch by construction. Can you update asap?
I also see that the README does not contain the relevant information and should be updated as well. Have a look at what we're doing in master for Moore or DaVinci, for example.Federico Leo RediMark SmithFederico Leo Redihttps://gitlab.cern.ch/lhcb/Stripping/-/issues/44Various Stripping and DaVinci tests failing in 201X-patches2023-04-05T15:45:46+02:00Eduardo RodriguesVarious Stripping and DaVinci tests failing in 201X-patchesTake https://lhcb-nightlies.web.cern.ch/nightly/lhcb-2018-patches/1230/ as an example. We all know there are some long standing issues being worked on but I see totally independent failures, seems since a while, and these ought to be add...Take https://lhcb-nightlies.web.cern.ch/nightly/lhcb-2018-patches/1230/ as an example. We all know there are some long standing issues being worked on but I see totally independent failures, seems since a while, and these ought to be addressed as soon as feasible to avoid being "blind" with other issues.
Assigning to you 3 for the various matters - @fredi, @ngrieser, @masmith.Federico Leo RediMark SmithNathan Allen Griesernathan.allen.grieser@cern.chFederico Leo Redihttps://gitlab.cern.ch/lhcb/Stripping/-/issues/45Clean up defunct branches2023-04-20T13:05:54+02:00Mark SmithClean up defunct branchesThere are ~1000 branches in Stripping. I guess most are from ancient abandoned attempts or lines that got merged but the branch didn't get deleted. It might be nice to get rid of some.There are ~1000 branches in Stripping. I guess most are from ancient abandoned attempts or lines that got merged but the branch didn't get deleted. It might be nice to get rid of some.https://gitlab.cern.ch/lhcb/Stripping/-/issues/46Update README.md to correctly steer new campaign developments2023-05-30T11:39:25+02:00Nathan Allen Griesernathan.allen.grieser@cern.chUpdate README.md to correctly steer new campaign developmentsThe current README is quite vague. Whether a new campaign comes this summer or not, we should update and steer developments to the correct branch (as this should still be the same whether the campaign is this summer or next year or when...The current README is quite vague. Whether a new campaign comes this summer or not, we should update and steer developments to the correct branch (as this should still be the same whether the campaign is this summer or next year or whenever...)Nathan Allen Griesernathan.allen.grieser@cern.chNathan Allen Griesernathan.allen.grieser@cern.chhttps://gitlab.cern.ch/lhcb/Stripping/-/issues/472017-patches and stripping21-patches user tests uses old data (grid/prod) swt...2023-04-26T10:44:22+02:00Nathan Allen Griesernathan.allen.grieser@cern.ch2017-patches and stripping21-patches user tests uses old data (grid/prod) swtest locationAs was changed in https://gitlab.cern.ch/lhcb/Stripping/-/merge_requests/1712 , the ```2017-patches``` user test xml file uses the test data in ```/eos/lhcb/grid/prod/lhcb/swtest/``` , and this should be updated to use the CERN-SWTEST gr...As was changed in https://gitlab.cern.ch/lhcb/Stripping/-/merge_requests/1712 , the ```2017-patches``` user test xml file uses the test data in ```/eos/lhcb/grid/prod/lhcb/swtest/``` , and this should be updated to use the CERN-SWTEST grid storage space.
The xml file used is : https://gitlab.cern.ch/lhcb/Stripping/-/blob/2017-patches/Phys/StrippingSelections/tests/data/Reco17_DataType2017_Run195969.xml
The error reported when running the test is:
```
Error in <TNetXNGFile::Open>: [ERROR] Server responded with an error: [3011] Unable to open file /eos/lhcb/grid/prod/lhcb/swtest/lhcb/data/2017/RAW/FULL/LHCb/COLLISION17/195969/195969_0000000791.raw; No such file or directory
IODataManager ERROR Error: connectDataIO> Cannot connect to database: PFN=mdf:root://eoslhcb.cern.ch//eos/lhcb/grid/prod/lhcb/swtest/lhcb/data/2017/RAW/FULL/LHCb/COLLISION17/195969/195969_0000000791.raw FID=ba265044-7707-11e7-b20e-001e67ddce9d
IODataManager ERROR Failed to open dsn:ba265044-7707-11e7-b20e-001e67ddce9d Federated file could not be resolved from 1 entries.
```
The case is also the same for ```stripping21-patches``` for Run 1 tests.
The xml file in that case is : https://gitlab.cern.ch/lhcb/Stripping/-/blob/stripping21-patches/Phys/StrippingSelections/tests/data/Reco15a_Run164668.xmlhttps://gitlab.cern.ch/lhcb/Stripping/-/issues/48Clean up of some too-old archives2023-06-16T11:18:51+02:00Eduardo RodriguesClean up of some too-old archivesHey there, while linting the repository I noticed that several subdirectories contain a series of Stripping campaign versions. I would argue that we can get rid of most of them. I see the following:
```
$ ls CommonParticlesArchive/pytho...Hey there, while linting the repository I noticed that several subdirectories contain a series of Stripping campaign versions. I would argue that we can get rid of most of them. I see the following:
```
$ ls CommonParticlesArchive/python/CommonParticlesArchive/
__init__.py Stripping27 Stripping30r2 Stripping31r2 Stripping34r0p1 Stripping35r3
Stripping24r2 Stripping28r2 Stripping30r3 Stripping33r2 Stripping34r0p2
Stripping25 Stripping28r2p1 Stripping31r1 Stripping34 Stripping35r2
$ ls StrippingArchive/python/StrippingArchive/
__init__.py Stripping27 Stripping30r2 Stripping31r2 Stripping34r0p1 Stripping35r3
Stripping24r2 Stripping28r2 Stripping30r3 Stripping33r2 Stripping34r0p2 Utils.py
Stripping25 Stripping28r2p1 Stripping31r1 Stripping34 Stripping35r2
$ ls StrippingSettings/python/StrippingSettings/
__init__.py Stripping25 Stripping28r2p1 Stripping31r1 Stripping34 Stripping35r2
makeDB.py Stripping27 Stripping30r2 Stripping31r2 Stripping34r0p1 Stripping35r3
Stripping24r2 Stripping28r2 Stripping30r3 Stripping33r2 Stripping34r0p2 Utils.py
```
It would be ideal to clean this all up before linting what actually is to be kept. I hope you agree.
This goes for the various legacy branches though I've been only looking at 2018-patches.Federico Leo RediAravindhan VenkateswaranNathan Allen Griesernathan.allen.grieser@cern.chFederico Leo Redihttps://gitlab.cern.ch/lhcb/Stripping/-/issues/49Confusing Behavior in B2OC Definitions2023-07-12T10:19:26+02:00Nathan Allen Griesernathan.allen.grieser@cern.chConfusing Behavior in B2OC DefinitionsAn issue was raised by @alupato about how the different line definitions are working within B2OC modules. Looking specifically at the LB2XBuilder, the intention was to edit the ```AM_MIN``` values. The relevant selector in the config d...An issue was raised by @alupato about how the different line definitions are working within B2OC modules. Looking specifically at the LB2XBuilder, the intention was to edit the ```AM_MIN``` values. The relevant selector in the config dictionaries is the ```B2X``` one [1].
Here you can see for Stripping34 this value was set to 4750 and 7000 MeV, with a comment saying that the Lb2X builder overwrites the min value to 5200 [2].
However, within the make functions of the Lb2XBuilder, there are what seems to be users trying to redefine these values [3,4,5], but this does not seem to be being propagated correctly [6].
Multiple questions arise from this:
- How is a new analyser supposed to define selections for these lines hidden within these makers, when the lineconfig dictionary only carries some top level selection?
- Are the intended selections by analysers (3-5 below) being intentionally overwritten (and if so, why do these lines still exist) or were these ran with the incorrect intended values?
- What is the correct (intended?) way for an analyser to edit this ```AM_MIN``` value for the specific lines housed in this module?
[1] https://gitlab.cern.ch/lhcb/Stripping/-/blob/2018-patches/Phys/StrippingSettings/python/StrippingSettings/Stripping34/LineConfigDictionaries_B2OC.py#L185
[2] https://gitlab.cern.ch/lhcb/Stripping/-/blob/2018-patches/Phys/StrippingSelections/python/StrippingSelections/StrippingB2OC/Beauty2Charm_Lb2XBuilder.py#L804
[3] https://gitlab.cern.ch/lhcb/Stripping/-/blob/2018-patches/Phys/StrippingSelections/python/StrippingSelections/StrippingB2OC/Beauty2Charm_Lb2XBuilder.py#L1503
[4] https://gitlab.cern.ch/lhcb/Stripping/-/blob/2018-patches/Phys/StrippingSelections/python/StrippingSelections/StrippingB2OC/Beauty2Charm_Lb2XBuilder.py#L1517
[5] https://gitlab.cern.ch/lhcb/Stripping/-/blob/2018-patches/Phys/StrippingSelections/python/StrippingSelections/StrippingB2OC/Beauty2Charm_Lb2XBuilder.py#L1529
[6]https://lhcbdoc.web.cern.ch/lhcbdoc/stripping/config/stripping34/bhadron/strippinglb2lcdstkstbeauty2charmline.html2023 Re-Strip CampaignAlessandro BertolinAlessandro Bertolin