Urania merge requestshttps://gitlab.cern.ch/lhcb/Urania/-/merge_requests2021-02-23T14:29:02+01:00https://gitlab.cern.ch/lhcb/Urania/-/merge_requests/298Merge DeltaMs related work2021-02-23T14:29:02+01:00Kevin HeinickeMerge DeltaMs related workBoth, source and target branches are rebased on `cleanup_Urania10`. This contains a large amount of testing/debugging configs which could probably be (re)moved. Main review focus should be on everything inside [/PhysFit/B2DXFitters/src](...Both, source and target branches are rebased on `cleanup_Urania10`. This contains a large amount of testing/debugging configs which could probably be (re)moved. Main review focus should be on everything inside [/PhysFit/B2DXFitters/src](), [/PhysFit/B2DXFitters/scripts](), and [/PhysFit/B2DXFitters/python]().
Let's discuss, @adudziak @jobutter 🙂
I also think noone will really gain anything from keeping 128 commits around. So I would say we can squash this MR. Even more so if we decide to apply `lb-format`.
This MR will fix #34 and #35. While some points of #34 will remain open it probably makes more sense to address them in a dedicated, more general code review.Prepare Urania 10https://gitlab.cern.ch/lhcb/Urania/-/merge_requests/314Add support for Python 32021-02-23T14:03:48+01:00Carlos Vazquez SierraAdd support for Python 3Two first steps of ```futurize``` (https://python-future.org/futurize.html) have been run on ```cleanup_Urania10```:
```
futurize --stage1 -w `find * -name '*.py'`
futurize --stage2 -w `find * -name '*.py'`
```
There are two files wh...Two first steps of ```futurize``` (https://python-future.org/futurize.html) have been run on ```cleanup_Urania10```:
```
futurize --stage1 -w `find * -name '*.py'`
futurize --stage2 -w `find * -name '*.py'`
```
There are two files which are not parseable (the syntax does not make sense, @adudziak @kheinick could you please have a look and fix them? please target this branch instead of ```cleanup_Urania10```):
```
RefactoringTool: Can't parse PhysFit/B2DXFitters/data/Bs2DsK_Run2CPV/Bs2DsPi/BiasedSFit/BiasedDMSFit.py: ParseError: bad input: type=26, value='{', context=(' ', (7, 9))
RefactoringTool: Can't parse PhysFit/B2DXFitters/data/Bs2DsK_Run2CPV/Bs2DsPi/BiasedSFit/MDFit.py: ParseError: bad input: type=26, value='{', context=(' ', (6, 9))
```
@dhill @poluekt @adudziak @kheinick Please check the changes in this MR, most of them are refactoring or adaptations to Py3. It would be desirable if you can run some checks and ensure this code does what is expected (comparing it with Py2 versions in ```cleanup_Urania10```).
Thanks!Prepare Urania 10Carlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Urania/-/merge_requests/312Removal of CalibDataScripts and RooPhysFitter2020-11-19T11:34:25+01:00Carlos Vazquez SierraRemoval of CalibDataScripts and RooPhysFitterPrepare Urania 10Carlos Vazquez SierraCarlos Vazquez Sierrahttps://gitlab.cern.ch/lhcb/Urania/-/merge_requests/310Remove packages to be moved to Alexandria2020-11-19T11:03:46+01:00Carlos Vazquez SierraRemove packages to be moved to AlexandriaPrepare Urania 10https://gitlab.cern.ch/lhcb/Urania/-/merge_requests/307Include legacy changes for DeltaMS works2020-11-06T12:23:53+01:00Carlos Vazquez SierraInclude legacy changes for DeltaMS worksPrepare Urania 10https://gitlab.cern.ch/lhcb/Urania/-/merge_requests/308Fix various problems reported by clang 102020-11-05T20:05:22+01:00Marco Clemencicmarco.clemencic@cern.chFix various problems reported by clang 10@cvazquez, this includes changes to Math/SomeUtils that should be ported there.
Of course, these changes should be ported to master too.@cvazquez, this includes changes to Math/SomeUtils that should be ported there.
Of course, these changes should be ported to master too.Prepare Urania 10https://gitlab.cern.ch/lhcb/Urania/-/merge_requests/300Add missing include of TObjString.h2020-11-04T18:48:29+01:00Marco Clemencicmarco.clemencic@cern.chAdd missing include of TObjString.hthis is a version of !299 for the clean up branchthis is a version of !299 for the clean up branchPrepare Urania 10Carlos Vazquez SierraCarlos Vazquez Sierra