...and only works for orientation_mode = "xyz"
, because the returned vector is interpreted exactly as that in the alignment modules where it is used:
git grep "rotation()" src/ src/core/detector/Detector.hpp: XYZVector rotation() const { return alignment_->orientation(); };
src/modules/AlignmentDUTResidual/AlignmentDUTResidual.cpp: << Units::display(m_detector->rotation(), {"deg"});
src/modules/AlignmentDUTResidual/AlignmentDUTResidual.cpp: residualFitter->SetParameter(3, (name + "_rotationX").c_str(), m_detector->rotation().X(), 0.001, -6.30, 6.30);
src/modules/AlignmentDUTResidual/AlignmentDUTResidual.cpp: residualFitter->SetParameter(3, (name + "_rotationX").c_str(), m_detector->rotation().X(), 0, -6.30, 6.30);
src/modules/AlignmentDUTResidual/AlignmentDUTResidual.cpp: residualFitter->SetParameter(4, (name + "_rotationY").c_str(), m_detector->rotation().Y(), 0.001, -6.30, 6.30);
src/modules/AlignmentDUTResidual/AlignmentDUTResidual.cpp: residualFitter->SetParameter(4, (name + "_rotationY").c_str(), m_detector->rotation().Y(), 0, -6.30, 6.30);
src/modules/AlignmentDUTResidual/AlignmentDUTResidual.cpp: residualFitter->SetParameter(5, (name + "_rotationZ").c_str(), m_detector->rotation().Z(), 0.001, -6.30, 6.30);
src/modules/AlignmentDUTResidual/AlignmentDUTResidual.cpp: residualFitter->SetParameter(5, (name + "_rotationZ").c_str(), m_detector->rotation().Z(), 0, -6.30, 6.30);
Furthermore, histograms in global coordinates (such as AnalysisEfficiency/globalEfficiency) currently do not have rotations applied to the detector, so if rotated by 90deg in the testbeam, parts of the detector are cut off. Rotations should be applied to the Detector::getSize()
results to transform to global coordinates.
This has been solved in !675 (merged) - closing it now
Lennart Huth (0fb384f1) at 20 Mar 11:58
Merge branch 'xrootd_files' of https://gitlab.cern.ch/aloeschc/corr...
... and 1 more commit
Lennart Huth (3be7917d) at 20 Mar 11:53
space
Lennart Huth (c43bbd78) at 05 Mar 10:24
adding a readme
Lennart Huth (301bd0a3) at 20 Feb 14:18
running high
Lennart Huth (3de4a7fa) at 16 Feb 14:47
sorry ruben
Lennart Huth (0f0f66d1) at 15 Feb 14:58
Lennart Huth (82031e4f) at 15 Feb 14:56
only suppress building of axis if there are no pixels defined
MuPix11 identifier added to converter
Lennart Huth (0f0f66d1) at 15 Feb 14:52
adding support of mupix11
Lennart Huth (0acfa8ac) at 13 Feb 19:14
correlate digi-mon and oszi-mon