GitLab

Delete the obsolete legacy `TriggerFlags.configurationSourceList` flag
and related configuration code.

Also delete the following flags:
  -`readLVL1FromJSON`: was only required during the Run-3
  migration while we had to support old and new menus
 - `useRun1CaloEnergyScale`: not used anymore as we don't simulate past
 triggers in this release
 - `doLVL1`: already migrated to new-style `ConfigFlag`
 - `doNavigationSlimming`: migrate remaining code to new-style flag

Deprecate the old `AODEDMSet` and `ESDEDMSet` `TriggerFlags`. Forward
the setting to the new equivalent `ConfigFlags` and migrate the internal
code to use only the new-style flags.

Remove the setup of the legacy `DSConfigSvc`.

Closes ATR-23580.

Changes to `TriggerConfigGetter`:

Move the creation and configuration of the JSON conversion for old data
into `TrigConfigSvcCfg`. Remove the setup of the legacy configuration
services and streamline the configuration of the Run-1&2 and Run-3
setup.

Changes to `TriggerConfigFlags`:
- Delete the following obsolete flags:
   - `Trigger.doConfigVersionConversion`
   - `Trigger.menuVersion`
   - `Trigger.LVL1ConfigFile`
   - `Trigger.L1MenuFile`
   - `Trigger.HLTMenuFile`
   - `Trigger.generateHLTMenu`
- put unit tests conditionally under `__main__`

`recAlgs.doTrigger` is obsolete with the Run-3 trigger. Remove the flag
and remaining references to it in trigger configuration.

Also delete the now unused `TransientBS_DetFlags.py`.

Relates to ATR-22725.

After the removal of the legacy menu support and the migration of all
clients (e.g. using `xAODConfigSvc`), the `TrigConfigSvc` only
functioned as a wrapper to create the LVL1/HLTConfigSvc. This is no
longer needed as these services are created explicitly where needed.

Also delete obsolete `TrigConfigSvcConfig.py`.

Relates to ATR-23102.

The trigger `SliceFlags` to configure the menu are obsolete and
not used anymore (see !46800). Remove all modules and references to
them.

Replacing the trigger slice flag doTrigMuonConfig with the corresponding flag that is part of the ConfigFlags (Muon.MuonTrigger). Replaced all teh places that check the flag in the muon configuration, replaced the setting of the flag in runHLT_standalone (it was also being set in MuonRecoSequences.py, but this isn't needed, so was dropped), and removed the flag from the MuonSLiceFlags (ATR-20389).

Remove unused trigger "SliceFlags". Most of these are no longer needed
and the few relevant ones are already migrated to the new "ConfigFlags".

Use the official `TrigDecisionTool` configuration functions to make sure
the correct config services are setup. Fixes ERRORs seen in q-tests
after removing the legacy menu support in `TrigConfigSvc`.

Closes ATR-24199.

The `TriggerOnlineFlags` are no longer used. Delete file and remove
remaining references to it.

Remove the legacy configuration support `UseNewConfig==False` and
deprecate all interface methods. No client should be using this service
instance anymore. In a second step we can remove the `ITrigConfigSvc`
inheritance and possibly completely delete this service in favor of
instantiating `LVL1/HLTConfigSvc` directly where needed.

Relates to ATR-23102.

Migrate the following `TriggerFlags` to `ConfigFlags`:
- `doID`
- `doCalo`
- `doMuon`
- `doCaloOffsetCorrection`
- `readBS`
- `OnlineCondTag` (delete, was already migrated)
- `OnlineGeoTag` (delete, was already migrated)

Remove `doL1Topo` from both old and new flags as this was a left-over
from Run-2 commissioning.

Also remove some unused "Modifiers".

Remove the following obsolete legacy menu flags:
- `readLVL1configFromXML`
- `inputLVL1configFile`
- `outputLVL1configFile`
- `triggerMenuSetup`
- `menuVersion`

We only support the Phase-1 L1Muon simulation in master. The existing
`Trigger.enableL1MuonPhase1` flag now only drives the configuration of the
data decoding on Run-1&2 data. Remove the usage of this flag for the
purposes of the L1 simulation configuration.

Peter Berta authored Sep 14, 2021 and Atlas Nightlybuild committed Sep 14, 2021

[ATR-24058][ATR-24141] Working to add R2 trigger TE data to R3 JSON structure to enable feature access from R22 AODs created from R2 data

See merge request atlas/athena!46419

(cherry picked from commit 89442554)

6a3c59d7 working to add R2 TE data to R3 JSON structure
b9133381 Add standalone signatures data
86dc0214 do not copy seq list, causes segfault on destruct
f09bf609 Change RAWtoALL/ESD/AOD slimming of R2 trigger navigation structures. Remove...

Migrate the CA-based L1 and HLT job options to use the Phase-1 Muctpi
simulation.

Remove support of obsolete XML trigger configuration in MBTS simulation.

Relates to ATR-21862.

Remove the support of the legacy XML trigger configuration. No
functional change as we were running already with `UseNewConfig=True`
for quite some time.

Relates to ATR-21862.

Updating the trigger conditions used for running on data to CONDBR2-HLTP-2018-02 which includes the folders for the PixelFeMask (ATLASRECTS-6437).