GitLab

Delete the obsolete legacy `TriggerFlags.configurationSourceList` flag
and related configuration code.

Also delete the following flags:
  -`readLVL1FromJSON`: was only required during the Run-3
  migration while we had to support old and new menus
 - `useRun1CaloEnergyScale`: not used anymore as we don't simulate past
 triggers in this release
 - `doLVL1`: already migrated to new-style `ConfigFlag`
 - `doNavigationSlimming`: migrate remaining code to new-style flag

Deprecate the old `AODEDMSet` and `ESDEDMSet` `TriggerFlags`. Forward
the setting to the new equivalent `ConfigFlags` and migrate the internal
code to use only the new-style flags.

Migrate the following `TriggerFlags` to `ConfigFlags`:
- `doID`
- `doCalo`
- `doMuon`
- `doCaloOffsetCorrection`
- `readBS`
- `OnlineCondTag` (delete, was already migrated)
- `OnlineGeoTag` (delete, was already migrated)

Remove `doL1Topo` from both old and new flags as this was a left-over
from Run-2 commissioning.

Also remove some unused "Modifiers".

Peter Berta authored Sep 14, 2021 and Atlas Nightlybuild committed Sep 14, 2021

[ATR-24058][ATR-24141] Working to add R2 trigger TE data to R3 JSON structure to enable feature access from R22 AODs created from R2 data

See merge request atlas/athena!46419

(cherry picked from commit 89442554)

6a3c59d7 working to add R2 TE data to R3 JSON structure
b9133381 Add standalone signatures data
86dc0214 do not copy seq list, causes segfault on destruct
f09bf609 Change RAWtoALL/ESD/AOD slimming of R2 trigger navigation structures. Remove...

Make the HLT result name and ROB IDs configurable in the Run-1&2
`HLTResultByteStreamTool` rather than hard-coding them in the code.
This will make it possible to decode results under non-standard
names (e.g. after remapping them with `AddressRemappingSvc`).

Merge the `EFResultKey` and `HLTResultKey` properties as they serve the
same purpose (final result of EF/HLT processing).

Fix a bug in the `equalize` option. This should only be set to `true` if
reading data with an L2 and EF result (Run-1 data). In all other cases
this is not necessary (but also did not cause any harm as the L2
navigation would have been empty).

Also delete commented code and unused ResultKey properties in
`TrigBStoxAODTool`.

Use the TrigConfigSvc configured in the TrigDecisionTool (xAODConfigSvc) to
access the list of trigger chains. Also make the `xAODConfigSvc` the
default in C++ and rename the property to `TrigConfigSvc`.

The `doMergedHLTResult` was used to distinguish Run-1 where we had a
split-level HLT (L2+EF) from Run-2 and beyond. But the same information
is available via the `EDMVersion` flag.

Also cleanup configuration of Run-2 DataScouting unpacking and always
set L2/EF/HLTResultKeys explicitly instead of relying on defaults.

The L2 `TrigPassBits` name-clash with the ones from the EF result. Before
!43270 they were simply being overwritten. Avoid deserializing them in
the first place. This only affects Run-1 data.

Fixes ATR-23411.

Delete the following obsolete old-style `TriggerFlags`:
  - `writeBS`: not used
  - `doTransientByteStream`: all code using new-style flag
  - `generateMenuDiagnostics`: migrated remaining code to new-style flag
  - `fakeLVL1`: not used
  - `doAlwaysUnpackDSResult`: not used

With the removal of `L1TopoValDataCnv` this flag serves no purpose
anymore.

```
git grep -l EDMDecodingVersion | xargs sed -i 's/EDMDecodingVersion/EDMVersion/g'
```

Convert TrigNavigation thinning to use MT-safe mechanisms.

Update HLTTriggerResultGetter.py - add protection to "Configure DataScouting" when reading from RAW (no metadata)

- Move trigger MT output hacks from reconstruction domain to trigger domain
- Fix python memory allocation error when peeking BS file for ROD version
- Make sure all navigation and metadata is propagated to AOD for all workflows (data and MC)

Tim Martin authored Aug 01, 2019 and Walter Lampl committed Aug 01, 2019

Complete migration of all Navigation collections to start with HLTNav_ by renaming HLTSummary to HLTNav_Summary

Extend the flake8 unit test to the entire package and made the code
compliant. Mostly trivial python code fixes.

Deleted NtupleProdFlags.py which seems unused and an almost identical
copy exists in the TrigTier0 package.

Catrin Bernius authored Jul 26, 2019 and Frank Winklmeier committed Jul 26, 2019

Reorganising TriggerEDM code to have a separate file for Run 2 and the functions, keeping the name TriggerEDM.py for the functions file which is imported in many places the code.

Add a flag to enable/disable the trigger navigation slimming. This
should help for MT jobs to disable the use of the TrigDecisionTool
(ATR-18627).

James Beacham authored Dec 09, 2018 and Atlas Nightlybuild committed Dec 10, 2018

ATR-18864 Add missing configuration for reconstruction of Run-1 bytestream.

See merge request atlas/athena!15893

(cherry picked from commit c6efdd80 [formerly 6f437cc6e922e53e34c9a59a8e763caea9cc7eba])

5fd34ba4 Add missing configuration for reconstruction of Run-1 bytestream.

Former-commit-id: 0775c077d9b727460a0d13a3bad3b6ebded96c25