IOVDbSvc: Prevent potential dereference of end iterator.

See merge request atlas/athena!22383

Fix for ATLASRECTS-4909

See merge request atlas/athena!22346

William Axel Leight authored Apr 04, 2019 and Walter Lampl committed Apr 04, 2019

ATLASRECTS-4909 reports a crash in the IsolationBuilder due to the ParticleCaloExtensionTool being unable to extrapolate an SA muon back through the calorimeter.
In principle, all SA muons should be extrapolated back through the calorimeter already, so this should never happen.
However, investigating this particular case showed that things are not as straightforward as I assumed.
The extrapolation is first done using a guess at the track parameters: after the fit, it is done again, the calo TSOS's updated, and the fit re-done.
In this case, though, the track fit failed after the calo TSOS's were updated.  Not only that, the final extrapolated fit had a worse chi2 than the initial MS track.
The logical fix, then, is to reject extrapolated tracks in such cases.  The corresponding MS tracks can still be used in combined fits, but not turned into SA muons.
This should affect only a handful of muons (0 in a sample of 1000 Z->mumu events, in fact).

LArCellRec: Additional patterns to ignore.

See merge request atlas/athena!22384

Solution to missing move assignment opearator [CID# 113526]

See merge request atlas/athena!22363

Implement SCTLorentzMonAlg (ATLASDQ-679)

See merge request atlas/athena!22334

Susumu Oda authored Apr 04, 2019 and Walter Lampl committed Apr 04, 2019

This reverts commit da763569281e4381f959fc04e4494778be7112df.

Cleanup of PixelPrepDataToxAOD, SCT_PrepDataToxAOD, SCT_RawDataToxAOD for speedup

See merge request atlas/athena!22267

Susumu Oda authored Apr 04, 2019 and Walter Lampl committed Apr 04, 2019

Use universal initialization

Additional patterns to ignore in reference file comparison.
Fixes test failure in master due to changes in calodd handling.

Prevent a potential dereference of the end iterator of a map
in IOVDbParser.  Fixes unit test crash in SCT_ConditionsAlgorithms.

Bytestream bugfix

See merge request atlas/athena!22344

EventView inheritance test

See merge request atlas/athena!22314

Delete TrigCaloCellMakerMT

See merge request atlas/athena!22342

CaloDetDescr: Add CaloDetDescriptor::dump().

See merge request atlas/athena!22352

RootStorageSvc: Fix clang warning.

See merge request atlas/athena!22355

adding chains to the jet menu

See merge request atlas/athena!22283

Remove some tools from ToolSvc

See merge request atlas/athena!22359

Make RunTier0Tests.py project agnostic

See merge request atlas/athena!22165

TRT_ConditionsServices: Fix clang warnings.

See merge request atlas/athena!22356

TRT_ConditionsData: Fix gcc9 warnings.

See merge request atlas/athena!22357

Split bytestream related algs out of OverlayCommonAlgs

See merge request atlas/athena!22284

Refactoring of histogram fillers

See merge request atlas/athena!22130

ComponentAccumulator:  Reorganize deduplication

See merge request atlas/athena!22254

adds 3 decimals eta cut in VP1, closes ATLASVPONE-446

Closes ATLASVPONE-446

See merge request atlas/athena!22335

AthenaKernel: Fix unit tests on clang.

See merge request atlas/athena!22351

Porting RNN tau ID to master

See merge request atlas/athena!22197

AthenaConfiguration: Fix a typo.

See merge request atlas/athena!22354

In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment.  gcc9 now warns
about this by default.
Adjust to avoid the warning.

clang warnings: missing override keywords.

clang warning: unused variable.

Fix a typo in the documentation.

Add dump() to CaloDetDescriptor.  The same as print(), except sends the
output to an arbitrary ostream rather than cout.

In test_checking in errorcheck_test.cxx, suppress printing function names.
They're lambdas here, and print differently in clang vs. gcc.

TrigCaloCellMakerMT was an early prototype and is replaced by
HLTCaloCellMaker. Also avoid repeating link dependencies for component
library.