GitLab

Frank Winklmeier authored May 13, 2019 and Marco Clemencic committed May 13, 2019

Implement a `Gaudi::Timer` class that accumulates its statistics in a
`Counter`:
- `GenericTimer` is a generic timer that can be templated with a
  `std::chrono`-compatible clock and a precision. A timing measurement
  is done via the RAII helper class `ScopeTimer`.
- The Timer can register itself with an owner using the dedicated
  constructor.
- `RdtscClock` is a (non-walltime) clock based on `rdtsc`. Depending on
  the available CPU this can be significantly faster than the default
  clock. Run the `test_GaudiTimer` unit tests for a measurement of the
  overhead of the various clocks.
- `Gaudi/Timers.h` provides a default `Gaudi::Timer` based on wall-clock and
  `Gaudi::FastTimer` based on the `RdtscClock`.

* support both legacy ::Algorithm and Gaudi::Algorithm as base classe for
  Consumer, Producer, FilterPredicate, Transformer, SplittingTransformer
  and MergingTransformer

required for ROOT on SLC6 as of LCG 96

Set `TBB_USE_GLIBCXX_VERSION` explicitly for clang.
Fix for https://github.com/01org/tbb/issues/22.

Closes #65

Make the `StatusCodeSvc` thread-safe:
- use `tbb::concurrent_unordered_map` for storing of counts
- apply the filters during printout in finalize instead of modifying the
  map during initialize
- sort the output in finalize to ensure the same order as in the
  previous version using `std::map`

It's curious though that the script didn't just tweak my new code, but also
a piece of code that I didn't touch at all... :-/

This is because Clang was complaining that the pop command at the
end of the file was not paired with a previous push command.

Clang was warning about that piece of code, that the usage of std::move(...)
prevented it from generating efficient code in that location. Since it's
a temporary value, std::move(...) indeed does not need to be used there.

Instead of disabling the use of DEPFILE with Xcode, switched the logic
to only enable its usage with the Ninja generator. Since that's the only
one that supports it.

Clang, or at least Apple's Clang issued the following warning about that code:

expression with side effects will be evaluated despite being used as an operand to 'typeid'

Taking the de-referencing out into a separate line makes the warning go away.

The Apple Clang compiler pointed out that these variables were not used
for anything in the code anymore...

The Xcode generator relies on the build type specific settings of
CMAKE_RUNTIME_OUTPUT_DIRECTORY and CMAKE_LIBRARY_OUTPUT_DIRECTORY to
select where to put executables and libraries. By default these would
add the build type ("Debug" by default) as an extra directory into the
path. Making the environment setup used by Gaudi invalid.

This update makes sure that under all circumstances the executables
and libraries would be put into the bin/ and lib/ subdirectories of
the build directory respectively.

As it turns out, Xcode does not support the DEPENDS argument of
add_custom_command(...). So I had to disable dependency checking for the
ROOT 6 dictionaries when using Xcode for the build.