Finalization work for the cephfs backups Helm chart
The following discussions from !1 (merged) should be addressed:
-
@alossent started a discussion: Fixed in !6 (merged) grep
is unsafe, please use JSON output andjq
-
@alossent started a discussion: Fixed in !6 (merged), the documentation says we need to send the token in the header https://docs.openstack.org/api-quick-start/api-quick-start.html Use
jq
Do we actually need this?
-
@alossent started a discussion: Fixed in !7 (merged) name: backup-cephfs-volumes
-
@alossent started a discussion: Fixed in !7 (merged) name: backup-cephfs-volumes
name consistency
-
@alossent started a discussion: Fixed in !7 (merged) Why not get this from the manila secret like the rest?
-
@alossent started a discussion: Fixed in !7 (merged) Please remove
namespace
from the Helm values and use the standard.Release.Namespace
instead
Then remove the namespace
Helm value from okd4-install as per https://gitlab.cern.ch/paas-tools/okd4-install/-/merge_requests/222#note_3889366
-
@alossent started a discussion: Fixed in !7 (merged) Do not set the
nodeSelector
in the Helm default values, since it's a dict we cannot override it from a parent Helm chart. Please set default to{}
and set the actual nodeSelector in the ArgoCD application deploying this chart instead. -
@alossent started a discussion: Fixed in !7 (merged) This doesn't look useful. Better set all the final
OS_*
env vars directly in the pod's env var from the Manila secret.Also please don't hardcode any value here:
OS_AUTH_URL
and al must be set from Helm values, and okd4-install must pass the actual values from the global Helm values we have in okd4-install (global.openstack.authUrl
,global.openstack.regionName
etc.)