Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
paas-tools
okd4-deployment
cluster-ingress-operator
Commits
1a718a91
Unverified
Commit
1a718a91
authored
Jun 02, 2021
by
OpenShift Merge Robot
Committed by
GitHub
Jun 02, 2021
Browse files
Merge pull request #610 from miheer/router-canonical
Bug 1901648: Canonical router hostname not correct
parents
010ac081
9bb8cbb1
Changes
2
Hide whitespace changes
Inline
Side-by-side
pkg/operator/controller/ingress/deployment.go
View file @
1a718a91
...
...
@@ -423,7 +423,7 @@ func desiredRouterDeployment(ci *operatorv1.IngressController, ingressController
})
if
len
(
ci
.
Status
.
Domain
)
>
0
{
env
=
append
(
env
,
corev1
.
EnvVar
{
Name
:
"ROUTER_CANONICAL_HOSTNAME"
,
Value
:
ci
.
Status
.
Domain
})
env
=
append
(
env
,
corev1
.
EnvVar
{
Name
:
"ROUTER_CANONICAL_HOSTNAME"
,
Value
:
"router-"
+
ci
.
Name
+
"."
+
ci
.
Status
.
Domain
})
}
if
proxyNeeded
{
...
...
pkg/operator/controller/ingress/deployment_test.go
View file @
1a718a91
...
...
@@ -377,7 +377,7 @@ func TestDesiredRouterDeployment(t *testing.T) {
checkDeploymentHasEnvVar
(
t
,
deployment
,
"ROUTER_H1_CASE_ADJUST"
,
true
,
"Host,Cache-Control"
)
checkDeploymentHasEnvVar
(
t
,
deployment
,
"ROUTER_CANONICAL_HOSTNAME"
,
true
,
ci
.
Status
.
Domain
)
checkDeploymentHasEnvVar
(
t
,
deployment
,
"ROUTER_CANONICAL_HOSTNAME"
,
true
,
"router-"
+
ci
.
Name
+
"."
+
ci
.
Status
.
Domain
)
checkDeploymentHasContainer
(
t
,
deployment
,
operatorv1
.
ContainerLoggingSidecarContainerName
,
true
)
checkDeploymentHasEnvVar
(
t
,
deployment
,
"ROUTER_LOG_FACILITY"
,
false
,
""
)
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment