From 7b4cb17acdd3e57b0afcdeebbdc436a60e5796c3 Mon Sep 17 00:00:00 2001 From: cdikonim <chrysoula.dikonimaki@cern.ch> Date: Tue, 11 Feb 2025 15:56:53 +0100 Subject: [PATCH] update comment --- controllers/operator_methods.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/controllers/operator_methods.go b/controllers/operator_methods.go index 140e085..7718841 100644 --- a/controllers/operator_methods.go +++ b/controllers/operator_methods.go @@ -36,8 +36,9 @@ func (r *GitlabPagesSiteReconciler) getOidcSecret(ctx context.Context, gitlabPag } } - // Ensure we have a valid ApplicationRegistration registration, this only happens when we have exactly one ApplicationRegistration - // with a status set by the authz-operator and this status says provisioning succeeded + // Ensure we have a valid ApplicationRegistration. This can happen when the ApplicationRegistration is `Created` (the website should be up and running) + // or when the ApplicationRegistration has state `DeletedFromAPI` (the website should be blocked). To check if the ApplicationRegistration is in one of those two states, + // we can check if the oidc secret exists. if appReg.Status.ClientCredentialsSecret == "" { meta.SetStatusCondition(&gitlabPagesSite.Status.Conditions, metav1.Condition{ Type: webservicescernchv1alpha1.ConditionTypeGitlabPagesSiteCreated, -- GitLab