landb-operator issueshttps://gitlab.cern.ch/paas-tools/operators/landb-operator/-/issues2020-09-28T17:40:37+02:00https://gitlab.cern.ch/paas-tools/operators/landb-operator/-/issues/6Follow-up from "Added ownership for Sets, refactored Python added basic tests...2020-09-28T17:40:37+02:00Alexandre LossentFollow-up from "Added ownership for Sets, refactored Python added basic tests using operator-ci"The following discussion from !9 should be addressed:
- [ ] @alossent started a [discussion](https://gitlab.cern.ch/paas-tools/operators/landb-operator/-/merge_requests/9#note_3816978):
> I'm a bit confused by this `--unprotected-...The following discussion from !9 should be addressed:
- [ ] @alossent started a [discussion](https://gitlab.cern.ch/paas-tools/operators/landb-operator/-/merge_requests/9#note_3816978):
> I'm a bit confused by this `--unprotected-command` parameter.
>
> Would `--bypass-ownership-check` be a better name maybe?
>
> NB: since this is just for manual operations, let's not block this MR for longer. I'll turn this into a follow-up issue. Sorry for the delay in the MR reviewJoao Esteves MarcalJoao Esteves Marcalhttps://gitlab.cern.ch/paas-tools/operators/landb-operator/-/issues/5Refactor Python script to implement the command patter2020-08-28T17:31:18+02:00Joao Esteves MarcalRefactor Python script to implement the command patterThe LanDB python script that interacts with LanDB SOAP was originally very simple and only meant to do some calls to LanDB. However as things evolved today is not anymore a simple script and it's starting to gain some small complexity, I...The LanDB python script that interacts with LanDB SOAP was originally very simple and only meant to do some calls to LanDB. However as things evolved today is not anymore a simple script and it's starting to gain some small complexity, I'm especially not fond of all the `if...else` that it has nowadays. Hence, I think it would be worth refactoring the script to start using the [command pattern](https://en.wikipedia.org/wiki/Command_pattern#Python), in order to improve maintainability and future improvements.
@alossent I don't see as an immediate task but seems like something to be done in a not so distant future since the problem only aggravates with the passing of timeJoao Esteves MarcalJoao Esteves Marcal