From 20ccc75eb037394267d9fdbc5ad4baa1f94e17ad Mon Sep 17 00:00:00 2001 From: Frank Winklmeier <frank.winklmeier@cern.ch> Date: Tue, 3 Mar 2020 11:20:18 +0100 Subject: [PATCH] InDetEventTPCnv: Fix unchecked StatusCodes --- .../InDetEventTPCnv/test/PixelClusterContainerCnv_p1_test.cxx | 4 ++-- .../InDetEventTPCnv/test/PixelClusterContainerCnv_p2_test.cxx | 4 ++-- .../InDetEventTPCnv/test/PixelClusterContainerCnv_p3_test.cxx | 4 ++-- .../test/PixelGangedClusterAmbiguitiesCnv_p1_test.cxx | 4 ++-- .../InDetEventTPCnv/test/SCT_ClusterContainerCnv_p2_test.cxx | 4 ++-- .../InDetEventTPCnv/test/SCT_ClusterContainerCnv_p3_test.cxx | 4 ++-- .../test/TRT_DriftCircleContainerCnv_p2_test.cxx | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p1_test.cxx b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p1_test.cxx index 8a6de3385b9..7c8ed50418d 100644 --- a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p1_test.cxx +++ b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p1_test.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration */ // $Id$ @@ -163,7 +163,7 @@ makeclusts() cl->setHashAndIndex (hash, i); coll->push_back (std::move (cl)); } - cont->addCollection (coll.release(), hash); + assert( cont->addCollection (coll.release(), hash).isSuccess() ); } // gcc4.9 doesn't allow returning cont directly here; fixed in 5.2. diff --git a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p2_test.cxx b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p2_test.cxx index ae3ff5b5e9e..2bfd784c2f2 100644 --- a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p2_test.cxx +++ b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p2_test.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration */ // $Id$ @@ -159,7 +159,7 @@ makeclusts() cl->setHashAndIndex (hash, i); coll->push_back (std::move (cl)); } - cont->addCollection (coll.release(), hash); + assert( cont->addCollection (coll.release(), hash).isSuccess() ); } // gcc4.9 doesn't allow returning cont directly here; fixed in 5.2. diff --git a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p3_test.cxx b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p3_test.cxx index 69b823d3656..7b5c68d692d 100644 --- a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p3_test.cxx +++ b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelClusterContainerCnv_p3_test.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration */ // $Id$ @@ -159,7 +159,7 @@ makeclusts() cl->setHashAndIndex (hash, i); coll->push_back (std::move (cl)); } - cont->addCollection (coll.release(), hash); + assert( cont->addCollection (coll.release(), hash).isSuccess() ); } // gcc4.9 doesn't allow returning cont directly here; fixed in 5.2. diff --git a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelGangedClusterAmbiguitiesCnv_p1_test.cxx b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelGangedClusterAmbiguitiesCnv_p1_test.cxx index 7f145c719b9..9fef950d547 100644 --- a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelGangedClusterAmbiguitiesCnv_p1_test.cxx +++ b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/PixelGangedClusterAmbiguitiesCnv_p1_test.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration */ // $Id$ @@ -194,7 +194,7 @@ const InDet::PixelClusterContainer& makeclusts (StoreGateSvc* sg) cl->setHashAndIndex (hash, i); coll->push_back (std::move (cl)); } - cont->addCollection (coll.release(), hash); + assert (cont->addCollection (coll.release(), hash).isSuccess()); } const InDet::PixelClusterContainer& ret = *cont; diff --git a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/SCT_ClusterContainerCnv_p2_test.cxx b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/SCT_ClusterContainerCnv_p2_test.cxx index d0d3c4f4444..62f2054ef07 100644 --- a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/SCT_ClusterContainerCnv_p2_test.cxx +++ b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/SCT_ClusterContainerCnv_p2_test.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration */ // $Id$ @@ -136,7 +136,7 @@ makeclusts(const SCT_ID& sct_id) cl->setHashAndIndex (hash, i); coll->push_back (std::move (cl)); } - cont->addCollection (coll.release(), hash); + assert( cont->addCollection (coll.release(), hash).isSuccess() ); } // gcc4.9 doesn't allow returning cont directly here; fixed in 5.2. diff --git a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/SCT_ClusterContainerCnv_p3_test.cxx b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/SCT_ClusterContainerCnv_p3_test.cxx index 057d6148aaf..08909a94cf7 100644 --- a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/SCT_ClusterContainerCnv_p3_test.cxx +++ b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/SCT_ClusterContainerCnv_p3_test.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration */ // $Id$ @@ -136,7 +136,7 @@ makeclusts(const SCT_ID& sct_id) cl->setHashAndIndex (hash, i); coll->push_back (std::move (cl)); } - cont->addCollection (coll.release(), hash); + assert( cont->addCollection (coll.release(), hash).isSuccess() ); } // gcc4.9 doesn't allow returning cont directly here; fixed in 5.2. diff --git a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/TRT_DriftCircleContainerCnv_p2_test.cxx b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/TRT_DriftCircleContainerCnv_p2_test.cxx index 9fa154dc641..cc7c6e00c43 100644 --- a/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/TRT_DriftCircleContainerCnv_p2_test.cxx +++ b/InnerDetector/InDetEventCnv/InDetEventTPCnv/test/TRT_DriftCircleContainerCnv_p2_test.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration */ // $Id$ @@ -112,7 +112,7 @@ makeclusts (const TRT_ID& trt_id) 54321); coll->push_back (std::move (cl)); } - cont->addCollection (coll.release(), hash); + assert( cont->addCollection (coll.release(), hash).isSuccess() ); } // gcc4.9 doesn't allow returning cont directly here; fixed in 5.2. -- GitLab