From 2540865d521c1f1dd360fa89ed6ff3c5431f5cd3 Mon Sep 17 00:00:00 2001
From: scott snyder <scott.snyder@cern.ch>
Date: Tue, 3 Jul 2018 10:53:20 +0200
Subject: [PATCH] ForwardTracker: Fix clang warnings.
clang warnings:
- unused variable.
- class with virtual functions but no virtual dtor.
---
ForwardDetectors/ForwardTracker/ForwardTracker/IBender.h | 3 ++-
ForwardDetectors/ForwardTracker/src/Beamline.cxx | 3 +--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ForwardDetectors/ForwardTracker/ForwardTracker/IBender.h b/ForwardDetectors/ForwardTracker/ForwardTracker/IBender.h
index 715b4efba3d..f95a2395c9f 100644
--- a/ForwardDetectors/ForwardTracker/ForwardTracker/IBender.h
+++ b/ForwardDetectors/ForwardTracker/ForwardTracker/IBender.h
@@ -14,7 +14,8 @@ namespace ForwardTracker {
class IBender {
public:
-
+
+ virtual ~IBender() {}
virtual void bend(IParticle&) const = 0;
typedef boost::shared_ptr<IBender> ConstPtr_t;
diff --git a/ForwardDetectors/ForwardTracker/src/Beamline.cxx b/ForwardDetectors/ForwardTracker/src/Beamline.cxx
index 39c4fdb6ef3..67165ccbce7 100644
--- a/ForwardDetectors/ForwardTracker/src/Beamline.cxx
+++ b/ForwardDetectors/ForwardTracker/src/Beamline.cxx
@@ -45,7 +45,7 @@ namespace ForwardTracker {
public:
- ParticleTracker(IParticle& particle): m_particle(particle), m_element(0) {}
+ ParticleTracker(IParticle& particle): m_particle(particle) {}
bool operator()(const IBeamElement::ConstPtr_t& be) {
@@ -59,7 +59,6 @@ namespace ForwardTracker {
private:
IParticle& m_particle;
- int m_element;
};
void Beamline::track(IParticle& particle) const { // Pass the particle to beam elements until out of aperture or endPlane
--
GitLab