From 2b00c768ea7e7630249b48f8994d5a86edd62f18 Mon Sep 17 00:00:00 2001
From: Frank Winklmeier <frank.winklmeier@cern.ch>
Date: Mon, 14 Oct 2019 18:34:26 +0200
Subject: [PATCH] CondWriterExtAlg: Fix bug in call to dropObject

Call `dropObject` only when the conditions object is being invalidated
and not on every event. Bug was introduced in !15945.
---
 .../DataModelTestDataCommon/src/CondWriterExtAlg.cxx        | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Control/DataModelTest/DataModelTestDataCommon/src/CondWriterExtAlg.cxx b/Control/DataModelTest/DataModelTestDataCommon/src/CondWriterExtAlg.cxx
index 50ff261f7b2..e19babc6a8e 100644
--- a/Control/DataModelTest/DataModelTestDataCommon/src/CondWriterExtAlg.cxx
+++ b/Control/DataModelTest/DataModelTestDataCommon/src/CondWriterExtAlg.cxx
@@ -1,5 +1,5 @@
 /*
-  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "CondWriterExtAlg.h"
@@ -49,12 +49,12 @@ StatusCode CondWriterExtAlg::execute()
     // Set IOV in the past to trigger reload in IOVSvc
     IOVRange iov_range(IOVTime(0, 0), IOVTime(0, 0));
     ATH_CHECK( m_iovSvc->setRange(detStore()->clid(m_attrListKey), m_attrListKey, iov_range, "StoreGateSvc") );
-  }
 
     // Drop folder payload
     ATH_CHECK( m_iovDbSvc->dropObject(m_attrListKey, /*resetCache=*/true), StatusCode::FAILURE );
+  }
 
-    return StatusCode::SUCCESS;
+  return StatusCode::SUCCESS;
 }
 
 } // namespace DMTest
-- 
GitLab