From 2ed6760734e0c81c09759c30bb0919f9961b36fe Mon Sep 17 00:00:00 2001 From: Frank Winklmeier <frank.winklmeier@cern.ch> Date: Tue, 19 Mar 2019 14:46:18 +0100 Subject: [PATCH] Remove abstract virtual overrides in HypoBase/InputMakerBase There is no need to force `execute`, `initialize` and `finalize` to be pure virtual as the Algorithm base class already provides sensible defaults. --- .../DecisionHandling/DecisionHandling/HypoBase.h | 4 ---- .../DecisionHandling/DecisionHandling/InputMakerBase.h | 8 ++------ 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/Trigger/TrigSteer/DecisionHandling/DecisionHandling/HypoBase.h b/Trigger/TrigSteer/DecisionHandling/DecisionHandling/HypoBase.h index dfbb61fcbd8..e7d32cc9307 100644 --- a/Trigger/TrigSteer/DecisionHandling/DecisionHandling/HypoBase.h +++ b/Trigger/TrigSteer/DecisionHandling/DecisionHandling/HypoBase.h @@ -23,10 +23,6 @@ This is a base class for HLT Hypos to reduce boilerplate and enforce the common virtual ~HypoBase(); /// initialise this base class and renounce input decision key handles virtual StatusCode sysInitialize() override; - /// execute to be implemented in derived clas - virtual StatusCode execute(const EventContext&) const override = 0; - virtual StatusCode finalize() override = 0; - virtual StatusCode initialize() override = 0; protected: /// methods for derived classes to access handles of the base class input and output decisions; other read/write handles may be implemented by derived classes diff --git a/Trigger/TrigSteer/DecisionHandling/DecisionHandling/InputMakerBase.h b/Trigger/TrigSteer/DecisionHandling/DecisionHandling/InputMakerBase.h index 10d56a39c90..a2192e62790 100644 --- a/Trigger/TrigSteer/DecisionHandling/DecisionHandling/InputMakerBase.h +++ b/Trigger/TrigSteer/DecisionHandling/DecisionHandling/InputMakerBase.h @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration */ #ifndef DECISIONHANDLING_INPUTMAKERBASE_H @@ -24,11 +24,7 @@ This is a base class for HLT InputMakers to reduce boilerplate and enforce the c virtual ~InputMakerBase(); /// initialise this base class and renounce input decision key handles virtual StatusCode sysInitialize() override; - /// execute to be implemented in derived clas - virtual StatusCode execute(const EventContext&) const override = 0; - virtual StatusCode finalize() override = 0; - virtual StatusCode initialize() override = 0; - + protected: /// methods for derived classes to access handles of the base class input and output decisions; other read/write handles may be implemented by derived classes const SG::ReadHandleKeyArray<TrigCompositeUtils::DecisionContainer>& decisionInputs() const; -- GitLab