From 3e68295032b9a87cf786a4f8ce70db8cbbf66ab0 Mon Sep 17 00:00:00 2001
From: John Chapman <jchapman@cern.ch>
Date: Tue, 1 Sep 2020 17:04:44 +0200
Subject: [PATCH] clang-tidy fixes for the FastCaloSim package
---
.../FastCaloSim/FastCaloSim/FastShowerCellBuilderTool.h | 2 +-
.../FastCaloSim/src/FastShowerCellBuilderTool.cxx | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
mode change 100755 => 100644 Simulation/FastShower/FastCaloSim/FastCaloSim/FastShowerCellBuilderTool.h
mode change 100755 => 100644 Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx
diff --git a/Simulation/FastShower/FastCaloSim/FastCaloSim/FastShowerCellBuilderTool.h b/Simulation/FastShower/FastCaloSim/FastCaloSim/FastShowerCellBuilderTool.h
old mode 100755
new mode 100644
index 8ef69ac05ff..10a80213c54
--- a/Simulation/FastShower/FastCaloSim/FastCaloSim/FastShowerCellBuilderTool.h
+++ b/Simulation/FastShower/FastCaloSim/FastCaloSim/FastShowerCellBuilderTool.h
@@ -96,7 +96,7 @@ public:
typedef std::vector<HepMC::ConstGenParticlePtr> MCparticleCollection ;
private:
- void LoadParametrizationsFromDir(std::string dir);
+ void LoadParametrizationsFromDir(const std::string& dir);
void LoadParametrizationsFromFile(TDirectory& infile,MSG::Level level=MSG::INFO);
StatusCode OpenParamSource(std::string insource);
diff --git a/Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx b/Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx
old mode 100755
new mode 100644
index 7c76326e6f4..488fdbeffb2
--- a/Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx
+++ b/Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx
@@ -195,7 +195,7 @@ FastShowerCellBuilderTool::~FastShowerCellBuilderTool()
}
}
-void FastShowerCellBuilderTool::LoadParametrizationsFromDir(std::string dir)
+void FastShowerCellBuilderTool::LoadParametrizationsFromDir(const std::string& dir)
{
TString curdir=gSystem->pwd();
TString dirname=dir.c_str();
@@ -521,7 +521,7 @@ StatusCode FastShowerCellBuilderTool::OpenParamSource(std::string insource)
}
insource.erase(0,3);
- std::string::size_type strpos=insource.find(":");
+ std::string::size_type strpos=insource.find(':');
if(strpos==std::string::npos) {
ATH_MSG_WARNING("Could not parse string for database entry : "<< insource);
return StatusCode::SUCCESS;
@@ -530,7 +530,7 @@ StatusCode FastShowerCellBuilderTool::OpenParamSource(std::string insource)
ATH_MSG_DEBUG(" folder "<< cool_folder);
insource.erase(0,strpos+1);
- strpos=insource.find(":");
+ strpos=insource.find(':');
std::string str_cool_channel=insource.substr(0,strpos);
if(strpos==std::string::npos) {
ATH_MSG_WARNING("Could not parse string for database entry "<< insource);
--
GitLab