From 5a1102a9e94c3850728203f7670c0eaaf590eaaa Mon Sep 17 00:00:00 2001
From: scott snyder <sss@karma>
Date: Sun, 7 Jun 2020 23:03:46 -0400
Subject: [PATCH] ISF_FastCaloSimParametrization: Fix cppcheck warnings.
- Prefer preincrement to postincrement for user iterators.
---
.../src/FastCaloSimCaloExtrapolation.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization/src/FastCaloSimCaloExtrapolation.cxx b/Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization/src/FastCaloSimCaloExtrapolation.cxx
index ffa904c3e33..994b65cf549 100644
--- a/Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization/src/FastCaloSimCaloExtrapolation.cxx
+++ b/Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization/src/FastCaloSimCaloExtrapolation.cxx
@@ -302,7 +302,7 @@ std::unique_ptr<std::vector<Trk::HitInfo>> FastCaloSimCaloExtrapolation::caloHit
int sample=(*it).detID;
Amg::Vector3D hitPos = (*it).trackParms->position();
ATH_MSG_DEBUG(" HIT: layer="<<sample<<" sample="<<sample-IDCaloBoundary<<" eta="<<hitPos.eta()<<" phi="<<hitPos.phi()<<" d="<<hitPos.mag());
- it++;
+ ++it;
}
}
@@ -311,7 +311,7 @@ std::unique_ptr<std::vector<Trk::HitInfo>> FastCaloSimCaloExtrapolation::caloHit
int sample=(*it2).detID;
Amg::Vector3D hitPos = (*it2).trackParms->position();
ATH_MSG_DEBUG(" HIT: layer="<<sample<<" sample="<<sample-IDCaloBoundary<<" eta="<<hitPos.eta()<<" phi="<<hitPos.phi()<<" r="<<hitPos.perp()<<" z="<<hitPos[Amg::z]);
- it2++;
+ ++it2;
}
// Extrapolation may fail for very low pT charged particles. Enforce charge 0 to prevent this
--
GitLab