From 65a0bbb0085d69bb7ba30a0080f842030c728e83 Mon Sep 17 00:00:00 2001
From: scott snyder <snyder@bnl.gov>
Date: Sun, 30 Sep 2018 16:55:09 +0200
Subject: [PATCH] VP1Utils: Fix gcc8 warnings.
gcc8 warnings: Catching polymorphic exception by value.
Former-commit-id: 49d51d9b6390de2f398aed7e060c611f8e5b35c3
---
graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc | 2 +-
graphics/VP1/VP1Utils/src/VP1SGContentsHelper.cxx | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc b/graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc
index 3daa27c37e2..ebe2342413a 100644
--- a/graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc
+++ b/graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc
@@ -30,7 +30,7 @@ inline const T* VP1SGAccessHelper::retrieve( const QString& key ) const
try {
t = storeGate()->retrieve<const T>(key.toStdString());
exception = false;
- } catch (std::runtime_error e) {
+ } catch (const std::runtime_error& e) {
exception = true;
t = 0;
}
diff --git a/graphics/VP1/VP1Utils/src/VP1SGContentsHelper.cxx b/graphics/VP1/VP1Utils/src/VP1SGContentsHelper.cxx
index 53e8201fbf9..c45bafabe11 100644
--- a/graphics/VP1/VP1Utils/src/VP1SGContentsHelper.cxx
+++ b/graphics/VP1/VP1Utils/src/VP1SGContentsHelper.cxx
@@ -56,7 +56,7 @@ bool VP1SGContentsHelper::contains( const CLID& id, const QString& key ) const
try {
contains = m_sg->contains(id,key.toStdString());
exception = false;
- } catch (std::runtime_error e) {
+ } catch (const std::runtime_error& e) {
exception = true;
}
if (exception) {
@@ -84,7 +84,7 @@ QStringList VP1SGContentsHelper::getKeys(const CLID& id) const
try {
keys = m_sg->keys(id);
exception = false;
- } catch (std::runtime_error e) {
+ } catch (const std::runtime_error& e) {
exception = true;
}
if (exception) {
--
GitLab