diff --git a/HLT/Event/ByteStreamEmonSvc/src/ByteStreamEmonInputSvc.cxx b/HLT/Event/ByteStreamEmonSvc/src/ByteStreamEmonInputSvc.cxx
index 145f1c0df1b90878bc7f164c7c7714dccb8ead41..31c48e5932666fd3e8b6a13a1ee3efe183d738bd 100644
--- a/HLT/Event/ByteStreamEmonSvc/src/ByteStreamEmonInputSvc.cxx
+++ b/HLT/Event/ByteStreamEmonSvc/src/ByteStreamEmonInputSvc.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
*/
//===================================================================
@@ -78,7 +78,7 @@ ByteStreamEmonInputSvc::ByteStreamEmonInputSvc(const std::string& name, ISvcLoca
// Open the first input file and read the first event.
StatusCode ByteStreamEmonInputSvc::initialize()
{
- setProperty("State", "Init");
+ setProperty("State", "Init").ignore();
ATH_CHECK( ByteStreamInputSvc::initialize() );
@@ -132,7 +132,7 @@ StatusCode ByteStreamEmonInputSvc::initialize()
bool ByteStreamEmonInputSvc::getIterator()
{
- setProperty("State", "Init");
+ setProperty("State", "Init").ignore();
if(!IPCCore::isInitialised()) {
char* argv[2] = { 0 };
@@ -250,7 +250,7 @@ bool ByteStreamEmonInputSvc::getIterator()
if(m_readDetectorMask) {
get_runparams();
}
- setProperty("State", "Connected");
+ setProperty("State", "Connected").ignore();
return true;
} catch(ers::Issue& ex) {
ATH_MSG_INFO("Cannot connect to sampler (will wait 20s): " << m_key << "/" << m_value
@@ -310,7 +310,7 @@ const RawEvent* ByteStreamEmonInputSvc::nextEvent()
continue;
}
- setProperty("State", "Processing");
+ setProperty("State", "Processing").ignore();
OFFLINE_FRAGMENTS_NAMESPACE::DataType* buf = new OFFLINE_FRAGMENTS_NAMESPACE::DataType[event.size()];
memcpy(buf, event.data(), event.size() * sizeof(OFFLINE_FRAGMENTS_NAMESPACE::DataType));
@@ -511,14 +511,14 @@ void ByteStreamEmonInputSvc::updateHandler(Property& /* p */)
if(! m_connect) {
m_connect = true;
sleep(2);
- setProperty("State","Reconnect");
+ setProperty("State","Reconnect").ignore();
}
}
StatusCode ByteStreamEmonInputSvc::finalize()
{
- setProperty("State","Shutdown");
+ setProperty("State","Shutdown").ignore();
m_inputMetaDataStore.release().ignore();
m_robProvider.release().ignore();
m_sgSvc.release().ignore();
diff --git a/HLT/Services/JiveXMLServer/src/JiveXMLServer.cxx b/HLT/Services/JiveXMLServer/src/JiveXMLServer.cxx
index d9268f7ea315d08548bd974ac221bad5d58fd514..f9a503fb1834834426287d83d8a964360b2edac5 100644
--- a/HLT/Services/JiveXMLServer/src/JiveXMLServer.cxx
+++ b/HLT/Services/JiveXMLServer/src/JiveXMLServer.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
*/
#include <JiveXMLServer/JiveXMLServer.h>
@@ -42,7 +42,7 @@ namespace JiveXML {
m_runServerThread = false ;
//And then start it
- StartServingThread();
+ StartServingThread().ignore();
//Also register the signal handlers
signal( SIGINT , JiveXMLServer::signalHandler );
@@ -55,7 +55,7 @@ namespace JiveXML {
JiveXMLServer::~JiveXMLServer(){
//Just stop the serving thread
- StopServingThread();
+ StopServingThread().ignore();
}
/**
diff --git a/HLT/Trigger/TrigControl/TrigPSC/src/Psc.cxx b/HLT/Trigger/TrigControl/TrigPSC/src/Psc.cxx
index 12f312530b117e5848ccc6c7a75fd1ed7b7d84c3..5cf7c2c3f15459252a48a2d4a11a49bae13f6a91 100644
--- a/HLT/Trigger/TrigControl/TrigPSC/src/Psc.cxx
+++ b/HLT/Trigger/TrigControl/TrigPSC/src/Psc.cxx
@@ -330,7 +330,7 @@ bool psc::Psc::configure(const ptree& config)
ServiceHandle<IJobOptionsSvc> p_jobOptionSvc("JobOptionsSvc","psc::Psc");
SmartIF<IProperty> jos_propif{&(*p_jobOptionSvc)};
if(m_config->didUserSetLogLevel())
- jos_propif->setProperty("OutputLevel", m_config->getLogLevelAsNumStr());
+ jos_propif->setProperty("OutputLevel", m_config->getLogLevelAsNumStr()).ignore();
// Write Data Flow parameters in JobOptions catalogue
diff --git a/HLT/Trigger/TrigControl/TrigServices/src/HltEventLoopMgr.cxx b/HLT/Trigger/TrigControl/TrigServices/src/HltEventLoopMgr.cxx
index 08826eb18f64d3e2e06c86743a90c3edd6a8d27b..ecda27029d092c63718dec150f064f09b8f9a093 100644
--- a/HLT/Trigger/TrigControl/TrigServices/src/HltEventLoopMgr.cxx
+++ b/HLT/Trigger/TrigControl/TrigServices/src/HltEventLoopMgr.cxx
@@ -337,9 +337,14 @@ StatusCode HltEventLoopMgr::hltUpdateAfterFork(const ptree& /*pt*/)
ATH_MSG_DEBUG("Trying a stop-start of CoreDumpSvc");
SmartIF<IService> svc = serviceLocator()->service("CoreDumpSvc", /*createIf=*/ false);
if (svc.isValid()) {
- svc->stop();
- svc->start();
- ATH_MSG_DEBUG("Done a stop-start of CoreDumpSvc");
+ StatusCode sc = svc->stop();
+ sc &= svc->start();
+ if (sc.isFailure()) {
+ ATH_MSG_WARNING("Could not perform stop/start for CoreDumpSvc");
+ }
+ else {
+ ATH_MSG_DEBUG("Done a stop-start of CoreDumpSvc");
+ }
}
else {
ATH_MSG_WARNING("Could not retrieve CoreDumpSvc");
@@ -1003,7 +1008,7 @@ StatusCode HltEventLoopMgr::failedEvent(HLT::OnlineErrorCode errorCode, const Ev
hltResultPtr = std::make_unique<HLT::HLTResultMT>(*hltResultRH);
SG::WriteHandleKey<HLT::HLTResultMT> hltResultWHK(m_hltResultRHKey.key()+"_FailedEvent");
- hltResultWHK.initialize();
+ ATH_CHECK(hltResultWHK.initialize());
auto hltResultWH = SG::makeHandle(hltResultWHK,eventContext);
if (hltResultWH.record(std::move(hltResultPtr)).isFailure()) {
ATH_MSG_ERROR("Failed to record the HLT Result in event store while handling a failed event."
@@ -1019,16 +1024,16 @@ StatusCode HltEventLoopMgr::failedEvent(HLT::OnlineErrorCode errorCode, const Ev
hltResultWH->addErrorCode(errorCode);
switch (errorCode) {
case HLT::OnlineErrorCode::PROCESSING_FAILURE:
- hltResultWH->addStreamTag({m_algErrorDebugStreamName.value(), eformat::DEBUG_TAG, true});
+ ATH_CHECK(hltResultWH->addStreamTag({m_algErrorDebugStreamName.value(), eformat::DEBUG_TAG, true}));
break;
case HLT::OnlineErrorCode::TIMEOUT:
- hltResultWH->addStreamTag({m_timeoutDebugStreamName.value(), eformat::DEBUG_TAG, true});
+ ATH_CHECK(hltResultWH->addStreamTag({m_timeoutDebugStreamName.value(), eformat::DEBUG_TAG, true}));
break;
case HLT::OnlineErrorCode::RESULT_TRUNCATION:
- hltResultWH->addStreamTag({m_truncationDebugStreamName.value(), eformat::DEBUG_TAG, true});
+ ATH_CHECK(hltResultWH->addStreamTag({m_truncationDebugStreamName.value(), eformat::DEBUG_TAG, true}));
break;
default:
- hltResultWH->addStreamTag({m_fwkErrorDebugStreamName.value(), eformat::DEBUG_TAG, true});
+ ATH_CHECK(hltResultWH->addStreamTag({m_fwkErrorDebugStreamName.value(), eformat::DEBUG_TAG, true}));
break;
}
diff --git a/HLT/Trigger/TrigMonitoring/TrigOnlineMonitor/src/TrigOpMonitor.cxx b/HLT/Trigger/TrigMonitoring/TrigOnlineMonitor/src/TrigOpMonitor.cxx
index dc29c6108c3a0bb0724b045c48548391fbdb6703..c9a5843256730bd6bc7684ea9129e1e4cc83f46a 100644
--- a/HLT/Trigger/TrigMonitoring/TrigOnlineMonitor/src/TrigOpMonitor.cxx
+++ b/HLT/Trigger/TrigMonitoring/TrigOnlineMonitor/src/TrigOpMonitor.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
*/
#include "TrigOpMonitor.h"
@@ -287,7 +287,7 @@ void TrigOpMonitor::fillIOVDbChangeHist(const EventContext& ctx)
("Bytes read for " + info.folderName + ";Data [bytes];Entries").c_str(), 100, 0, 1000);
for (TH1* h : {fh->second.h_time, fh->second.h_bytes}) {
- m_histSvc->regHist(h->GetName(), h);
+ m_histSvc->regHist(h->GetName(), h).ignore();
}
}