From 7104ce4d9c63f3ee94f70978abdfb31119fc70c3 Mon Sep 17 00:00:00 2001
From: Frank Winklmeier <frank.winklmeier@cern.ch>
Date: Mon, 18 May 2020 17:13:59 +0200
Subject: [PATCH] Reconstruction: Move flake8 checking to build stage
---
Reconstruction/DiTauRec/CMakeLists.txt | 6 +-----
Reconstruction/RecExample/RecExAlgs/CMakeLists.txt | 6 +-----
.../RecExAlgs/share/SimpleCookedObjMaker_jobOptions.py | 2 ++
.../RecExAlgs/share/SimpleRawObjMaker_jobOptions.py | 2 ++
4 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/Reconstruction/DiTauRec/CMakeLists.txt b/Reconstruction/DiTauRec/CMakeLists.txt
index 76aefbb839b..c87b9897317 100644
--- a/Reconstruction/DiTauRec/CMakeLists.txt
+++ b/Reconstruction/DiTauRec/CMakeLists.txt
@@ -36,8 +36,4 @@ atlas_add_component( DiTauRec
# Install files from the package:
atlas_install_headers( DiTauRec )
atlas_install_python_modules( python/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} )
-atlas_install_joboptions( share/*.py )
-
-atlas_add_test( flake8_share
- SCRIPT flake8 --select=ATL,F,E7,E9,W6 --ignore=F401,F821,ATL900 ${CMAKE_CURRENT_SOURCE_DIR}/share
- POST_EXEC_SCRIPT nopost.sh )
+atlas_install_joboptions( share/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} --extend-ignore=F401,F821 )
diff --git a/Reconstruction/RecExample/RecExAlgs/CMakeLists.txt b/Reconstruction/RecExample/RecExAlgs/CMakeLists.txt
index f0d80a5c22d..f98544c14ca 100644
--- a/Reconstruction/RecExample/RecExAlgs/CMakeLists.txt
+++ b/Reconstruction/RecExample/RecExAlgs/CMakeLists.txt
@@ -23,8 +23,4 @@ atlas_add_component( RecExAlgs
# Install files from the package:
atlas_install_headers( RecExAlgs )
atlas_install_python_modules( python/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} )
-atlas_install_joboptions( share/*.py )
-
-atlas_add_test( flake8_share
- SCRIPT flake8 --select=ATL,F,E7,E9,W6 ${CMAKE_CURRENT_SOURCE_DIR}/share
- POST_EXEC_SCRIPT nopost.sh )
+atlas_install_joboptions( share/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} --extend-ignore=F401,F821 )
diff --git a/Reconstruction/RecExample/RecExAlgs/share/SimpleCookedObjMaker_jobOptions.py b/Reconstruction/RecExample/RecExAlgs/share/SimpleCookedObjMaker_jobOptions.py
index 081cfaafb38..d2cb925bb74 100755
--- a/Reconstruction/RecExample/RecExAlgs/share/SimpleCookedObjMaker_jobOptions.py
+++ b/Reconstruction/RecExample/RecExAlgs/share/SimpleCookedObjMaker_jobOptions.py
@@ -1,3 +1,5 @@
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+
## get a handle on the algsequence
from AthenaCommon.AlgSequence import AlgSequence
job = AlgSequence()
diff --git a/Reconstruction/RecExample/RecExAlgs/share/SimpleRawObjMaker_jobOptions.py b/Reconstruction/RecExample/RecExAlgs/share/SimpleRawObjMaker_jobOptions.py
index bc9b2935ba5..056daf12f83 100755
--- a/Reconstruction/RecExample/RecExAlgs/share/SimpleRawObjMaker_jobOptions.py
+++ b/Reconstruction/RecExample/RecExAlgs/share/SimpleRawObjMaker_jobOptions.py
@@ -1,3 +1,5 @@
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+
## get a handle on the algsequence
from AthenaCommon.AlgSequence import AlgSequence
job = AlgSequence()
--
GitLab