From 8f02fba5fa5bfbecc6e65a0302c6c4531dd35d89 Mon Sep 17 00:00:00 2001
From: Frank Winklmeier <fwinkl@cern>
Date: Fri, 4 Dec 2020 16:19:48 +0100
Subject: [PATCH] SCT_ConditionsTools: remove initialize/finalize INFO message

---
 .../src/SCT_ConditionsSummaryTool.cxx                    | 7 -------
 .../SCT_ConditionsTools/src/SCT_ConditionsSummaryTool.h  | 1 -
 .../src/SCT_ConfigurationConditionsTool.cxx              | 9 +--------
 .../src/SCT_ConfigurationConditionsTool.h                | 9 ++++-----
 .../SCT_ConditionsTools/src/SCT_LinkMaskingTool.cxx      | 8 +-------
 .../SCT_ConditionsTools/src/SCT_LinkMaskingTool.h        | 3 +--
 6 files changed, 7 insertions(+), 30 deletions(-)

diff --git a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConditionsSummaryTool.cxx b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConditionsSummaryTool.cxx
index 573fee4b9c0..931263fb47d 100644
--- a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConditionsSummaryTool.cxx
+++ b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConditionsSummaryTool.cxx
@@ -33,13 +33,6 @@ SCT_ConditionsSummaryTool::initialize() {
   return sc;
 }
 
-//Finalize
-StatusCode
-SCT_ConditionsSummaryTool::finalize() {
-  ATH_MSG_INFO("Thank-you for using the SCT_ConditionsSummaryTool, version " << PACKAGE_VERSION);
-  return StatusCode::SUCCESS;
-}
-
 bool
 SCT_ConditionsSummaryTool::isActive(const Identifier& elementId, const InDetConditions::Hierarchy h) const {
   return isGood(elementId, h);
diff --git a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConditionsSummaryTool.h b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConditionsSummaryTool.h
index e22a2630e6d..c6baa8060ae 100644
--- a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConditionsSummaryTool.h
+++ b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConditionsSummaryTool.h
@@ -36,7 +36,6 @@ public:
   //@name Gaudi STool Implementation
   //@{
   virtual StatusCode initialize() override;          //!< Tool init
-  virtual StatusCode finalize() override;            //!< Tool finalize
   //@}
   
   //@name reimplemented from IInDetConditionsTool
diff --git a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConfigurationConditionsTool.cxx b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConfigurationConditionsTool.cxx
index 01cb66d16d8..b5640e503f4 100644
--- a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConfigurationConditionsTool.cxx
+++ b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConfigurationConditionsTool.cxx
@@ -17,7 +17,7 @@ SCT_ConfigurationConditionsTool::SCT_ConfigurationConditionsTool(const std::stri
 
 // Initialize
 StatusCode SCT_ConfigurationConditionsTool::initialize() {
-  ATH_MSG_INFO("Initializing configuration");
+  ATH_MSG_DEBUG("Initializing configuration");
 
   ATH_CHECK(detStore()->retrieve(m_pHelper, "SCT_ID"));
 
@@ -28,13 +28,6 @@ StatusCode SCT_ConfigurationConditionsTool::initialize() {
   return StatusCode::SUCCESS;
 }
 
-// Finalize
-StatusCode SCT_ConfigurationConditionsTool::finalize() {
-  ATH_MSG_INFO("Configuration finalize");
-
-  return StatusCode::SUCCESS;
-}
-
 // What level of element can this service report about
 bool SCT_ConfigurationConditionsTool::canReportAbout(InDetConditions::Hierarchy h) const {
   return (h == InDetConditions::SCT_STRIP or
diff --git a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConfigurationConditionsTool.h b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConfigurationConditionsTool.h
index 9f99fd80841..41125f081c1 100644
--- a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConfigurationConditionsTool.h
+++ b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_ConfigurationConditionsTool.h
@@ -1,12 +1,12 @@
 // -*- C++ -*-
 
 /*
-  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 /**
  * @file SCT_ConfigurationConditionsTool.h
- * header file for service which reads SCT configuration from database
+ * header file for tool which reads SCT configuration from database
  * @author shaun.roe@cern.ch, gwilliam@mail.cern.ch
 **/
 
@@ -41,15 +41,14 @@ class SCT_ID;
 class SCT_ConfigurationConditionsTool: public extends<AthAlgTool, ISCT_ConfigurationConditionsTool> {
  public:
 
-  //@name Service methods
+  //@name Tool methods
   //@{
   SCT_ConfigurationConditionsTool(const std::string& type, const std::string& name, const IInterface* parent);
   virtual ~SCT_ConfigurationConditionsTool() = default;
   virtual StatusCode initialize() override;
-  virtual StatusCode finalize() override;
   //@}
   
-  /**Can the service report about the given component? (chip, module...)*/
+  /**Can the tool report about the given component? (chip, module...)*/
   virtual bool                          canReportAbout(InDetConditions::Hierarchy h) const override;
   
   /**Is the detector element good?*/
diff --git a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_LinkMaskingTool.cxx b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_LinkMaskingTool.cxx
index 3f9b5493b2c..79eeb5244ef 100644
--- a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_LinkMaskingTool.cxx
+++ b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_LinkMaskingTool.cxx
@@ -15,7 +15,7 @@ SCT_LinkMaskingTool::SCT_LinkMaskingTool(const std::string& type, const std::str
 
 // Initialize
 StatusCode SCT_LinkMaskingTool::initialize() {
-  ATH_MSG_INFO("Initializing configuration");
+  ATH_MSG_DEBUG("Initializing configuration");
 
   // Retrieve SCT ID helper
   if (detStore()->retrieve(m_sctHelper, "SCT_ID").isFailure()) {
@@ -29,12 +29,6 @@ StatusCode SCT_LinkMaskingTool::initialize() {
   return StatusCode::SUCCESS;
 }
 
-// Finalize
-StatusCode SCT_LinkMaskingTool::finalize() {
-  ATH_MSG_INFO("Configuration finalize");
-  return StatusCode::SUCCESS;
-}
-
 // What level of element can this service report about
 bool SCT_LinkMaskingTool::canReportAbout(InDetConditions::Hierarchy h) const {
   return (h==InDetConditions::SCT_SIDE or h==InDetConditions::DEFAULT); 
diff --git a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_LinkMaskingTool.h b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_LinkMaskingTool.h
index b5ad7ff6f4c..a0c825173fe 100644
--- a/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_LinkMaskingTool.h
+++ b/InnerDetector/InDetConditions/SCT_ConditionsTools/src/SCT_LinkMaskingTool.h
@@ -1,7 +1,7 @@
 // -*- C++ -*-
 
 /*
-  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 /**
@@ -38,7 +38,6 @@ public:
   SCT_LinkMaskingTool(const std::string& type, const std::string& name, const IInterface* parent);
   virtual ~SCT_LinkMaskingTool() = default;
   virtual StatusCode initialize() override;
-  virtual StatusCode finalize() override;
   //@}
   
   /**Can the service report about the given component? (chip, module...)*/
-- 
GitLab