From 8f4cde9c2696064daec3387a6393396115774e63 Mon Sep 17 00:00:00 2001
From: scott snyder <sss@karma>
Date: Wed, 17 Jun 2020 17:07:24 +0200
Subject: [PATCH] TrkParametersBase: Avoid warnings about uninitialized Eigen
objects.
gcc10 warns about uninitialized eigen objects in the ParametersT ctors.
Make sure everything's initialized in the base class.
---
.../TrkParametersBase/ParametersT.icc | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Tracking/TrkEvent/TrkParametersBase/TrkParametersBase/ParametersT.icc b/Tracking/TrkEvent/TrkParametersBase/TrkParametersBase/ParametersT.icc
index 9c6cb0e145b..6c30adc6f5e 100644
--- a/Tracking/TrkEvent/TrkParametersBase/TrkParametersBase/ParametersT.icc
+++ b/Tracking/TrkEvent/TrkParametersBase/TrkParametersBase/ParametersT.icc
@@ -32,7 +32,7 @@ ParametersT<DIM, T, S>::ParametersT(double loc1,
double qop,
const S& surface,
AmgSymMatrix(DIM) * cov)
- : ParametersBase<DIM, T>({}, cov, {}, {}, sgn(qop))
+ : ParametersBase<DIM, T>(AmgVector(DIM)::Zero(), cov, Amg::Vector3D::Zero(), Amg::Vector3D::Zero(), sgn(qop))
, m_surface(nullptr)
{
m_surface.reset((surface.isFree() ? surface.clone() : &surface));
@@ -64,8 +64,8 @@ ParametersT<DIM, T, S>::ParametersT(const AmgVector(DIM) & parameters,
AmgSymMatrix(DIM) * cov)
: ParametersBase<DIM, T>(parameters,
cov,
- {},
- {},
+ Amg::Vector3D::Zero(),
+ Amg::Vector3D::Zero(),
sgn(parameters[Trk::qOverP]))
, m_surface(nullptr)
{
@@ -99,7 +99,7 @@ ParametersT<DIM, T, S>::ParametersT(const Amg::Vector3D& pos,
double charge,
const S& surface,
AmgSymMatrix(DIM) * cov)
- : ParametersBase<DIM, T>({}, cov, pos, mom, charge)
+ : ParametersBase<DIM, T>(AmgVector(DIM)::Zero(), cov, pos, mom, charge)
, m_surface(surface.isFree() ? surface.clone() : &surface)
{
// get the local parameters via the surface
@@ -130,7 +130,7 @@ Trk::ParametersT<DIM, T, S>::ParametersT(const Amg::Vector3D& pos,
double qop,
const S& surface,
AmgSymMatrix(DIM) * cov)
- : ParametersBase<DIM, T>({}, cov, pos, {}, 1.)
+ : ParametersBase<DIM, T>(AmgVector(DIM)::Zero(), cov, pos, Amg::Vector3D::Zero(), 1.)
, m_surface(surface.isFree() ? surface.clone() : &surface)
{
// decide the sign of the charge
--
GitLab