From 9d11dab320f8c6d26b89f71d1d5be5357604eecf Mon Sep 17 00:00:00 2001 From: scott snyder <snyder@bnl.gov> Date: Fri, 20 Nov 2020 16:14:22 +0100 Subject: [PATCH] MuonTGC_CnvTools: Fix clang warnings. Missing override keywords. --- .../MuonTGC_CnvTools/src/TGC_RawDataProviderTool.h | 12 ++++++------ .../MuonTGC_CnvTools/src/TGC_RawDataProviderToolMT.h | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/MuonSpectrometer/MuonCnv/MuonTGC_CnvTools/src/TGC_RawDataProviderTool.h b/MuonSpectrometer/MuonCnv/MuonTGC_CnvTools/src/TGC_RawDataProviderTool.h index 60fe7f01128..b566b842dd9 100644 --- a/MuonSpectrometer/MuonCnv/MuonTGC_CnvTools/src/TGC_RawDataProviderTool.h +++ b/MuonSpectrometer/MuonCnv/MuonTGC_CnvTools/src/TGC_RawDataProviderTool.h @@ -32,17 +32,17 @@ namespace Muon virtual ~TGC_RawDataProviderTool()=default; /** Standard AlgTool method */ - virtual StatusCode initialize(); + virtual StatusCode initialize() override; /** Old decoding method which uses IROBDataProviderSvc in TgcRdoToPrepDataTool */ - virtual StatusCode convert(const ROBFragmentList& vecRobs); + virtual StatusCode convert(const ROBFragmentList& vecRobs) override; /** Old decoding method which uses IROBDataProviderSvc in TgcRdoToPrepDataTool with IdentifierHash vector */ virtual StatusCode convert(const ROBFragmentList& vecRobs, - const std::vector<IdentifierHash>& rdoIdhVect); + const std::vector<IdentifierHash>& rdoIdhVect) override; /** New decoding methods which do not use IROBDataProviderSvc in TgcRdoToPrepDataTool */ - virtual StatusCode convert(); + virtual StatusCode convert() override; /** New decoding methods which do not use IROBDataProviderSvc in TgcRdoToPrepDataTool with ID Hash vector */ - virtual StatusCode convert(const std::vector<IdentifierHash>& rdoIdhVect); + virtual StatusCode convert(const std::vector<IdentifierHash>& rdoIdhVect) override; /** EventContext ones **/ virtual StatusCode convert(const ROBFragmentList&, const EventContext&) const override; @@ -53,7 +53,7 @@ namespace Muon private: /** convert from vector of ROB IDs is not available */ - virtual StatusCode convert(const std::vector<uint32_t>&) {return StatusCode::FAILURE;} + virtual StatusCode convert(const std::vector<uint32_t>&) override {return StatusCode::FAILURE;} /** EventContext ones **/ virtual StatusCode convert(const std::vector<uint32_t>&, const EventContext&) const override {return StatusCode::FAILURE;} diff --git a/MuonSpectrometer/MuonCnv/MuonTGC_CnvTools/src/TGC_RawDataProviderToolMT.h b/MuonSpectrometer/MuonCnv/MuonTGC_CnvTools/src/TGC_RawDataProviderToolMT.h index 1fbada24c00..8eebcdb3d12 100644 --- a/MuonSpectrometer/MuonCnv/MuonTGC_CnvTools/src/TGC_RawDataProviderToolMT.h +++ b/MuonSpectrometer/MuonCnv/MuonTGC_CnvTools/src/TGC_RawDataProviderToolMT.h @@ -31,17 +31,17 @@ namespace Muon virtual ~TGC_RawDataProviderToolMT()=default; /** Standard AlgTool method */ - virtual StatusCode initialize(); + virtual StatusCode initialize() override; /** Old decoding method which uses IROBDataProviderSvc in TgcRdoToPrepDataTool */ - virtual StatusCode convert(const ROBFragmentList& vecRobs); + virtual StatusCode convert(const ROBFragmentList& vecRobs) override; /** Old decoding method which uses IROBDataProviderSvc in TgcRdoToPrepDataTool with IdentifierHash vector */ virtual StatusCode convert(const ROBFragmentList& vecRobs, - const std::vector<IdentifierHash>& rdoIdhVect); + const std::vector<IdentifierHash>& rdoIdhVect) override; /** New decoding methods which do not use IROBDataProviderSvc in TgcRdoToPrepDataTool */ - virtual StatusCode convert(); + virtual StatusCode convert() override; /** New decoding methods which do not use IROBDataProviderSvc in TgcRdoToPrepDataTool with ID Hash vector */ - virtual StatusCode convert(const std::vector<IdentifierHash>& rdoIdhVect); + virtual StatusCode convert(const std::vector<IdentifierHash>& rdoIdhVect) override; /** EventContext ones **/ virtual StatusCode convert(const ROBFragmentList&, const EventContext&) const override; @@ -54,7 +54,7 @@ namespace Muon SG::UpdateHandleKey<TgcRdo_Cache> m_rdoContainerCacheKey ; /** convert from vector of ROB IDs is not available */ - virtual StatusCode convert(const std::vector<uint32_t>&) {return StatusCode::FAILURE;} + virtual StatusCode convert(const std::vector<uint32_t>&) override {return StatusCode::FAILURE;} /** EventContext ones **/ virtual StatusCode convert(const std::vector<uint32_t>&, const EventContext&) const override {return StatusCode::FAILURE;} -- GitLab