diff --git a/MuonSpectrometer/MuonCablings/MuonCablingServers/MuonCablingServers/RPCcablingServerSvc.h b/MuonSpectrometer/MuonCablings/MuonCablingServers/MuonCablingServers/RPCcablingServerSvc.h index 0b5e765dfa1e62bffd5b088af8eca0aecebf789d..ec9d0ac2b929bb3d60a78a71c0ba06bd090973dd 100644 --- a/MuonSpectrometer/MuonCablings/MuonCablingServers/MuonCablingServers/RPCcablingServerSvc.h +++ b/MuonSpectrometer/MuonCablings/MuonCablingServers/MuonCablingServers/RPCcablingServerSvc.h @@ -32,13 +32,13 @@ class RPCcablingServerSvc : public AthService, RPCcablingServerSvc(const std::string& name, ISvcLocator* svc); virtual ~RPCcablingServerSvc() {} - virtual StatusCode queryInterface(const InterfaceID& riid,void** ppvIF); - virtual StatusCode initialize(void); - virtual StatusCode finalize(void); + virtual StatusCode queryInterface(const InterfaceID& riid,void** ppvIF) override; + virtual StatusCode initialize(void) override; + virtual StatusCode finalize(void) override; // Interface implementation - virtual StatusCode giveCabling(const IRPCcablingSvc*&) const; - virtual bool isAtlas(void) const; + virtual StatusCode giveCabling(const IRPCcablingSvc*&) const override; + virtual bool isAtlas(void) const override; // ITagInfoMgr callback virtual void tagInfoUpdated() override final { compareTags().ignore(); } diff --git a/TileCalorimeter/TileTrackingGeometry/TileTrackingGeometry/TileVolumeBuilder.h b/TileCalorimeter/TileTrackingGeometry/TileTrackingGeometry/TileVolumeBuilder.h index 1bee74e537262170d391bce047b4aa70927ed383..863678fc4fdaf6f3c53990712e1f7afe986b2f02 100755 --- a/TileCalorimeter/TileTrackingGeometry/TileTrackingGeometry/TileVolumeBuilder.h +++ b/TileCalorimeter/TileTrackingGeometry/TileTrackingGeometry/TileVolumeBuilder.h @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration */ /////////////////////////////////////////////////////////////////// @@ -72,7 +72,6 @@ namespace Tile { const TileDetDescrManager* m_tileMgr; //!< Calo DetDescrMgr std::string m_tileMgrLocation; //!< Location of the CaloDetDescrMgr - const CaloDetDescrManager* m_calo_dd; ToolHandle<Trk::ITrackingVolumeHelper> m_trackingVolumeHelper; //!< Helper Tool to create TrackingVolumes ToolHandle<Trk::ITrackingVolumeCreator> m_trackingVolumeCreator; //!< Second helper for volume creation diff --git a/TileCalorimeter/TileTrackingGeometry/src/TileVolumeBuilder.cxx b/TileCalorimeter/TileTrackingGeometry/src/TileVolumeBuilder.cxx index ac5c69f10178e9f6882bdc3b4b51138522f1f1a2..6c571e9e7004c794b5ab89676187ee44c8ef78a8 100755 --- a/TileCalorimeter/TileTrackingGeometry/src/TileVolumeBuilder.cxx +++ b/TileCalorimeter/TileTrackingGeometry/src/TileVolumeBuilder.cxx @@ -62,7 +62,6 @@ Tile::TileVolumeBuilder::TileVolumeBuilder(const std::string& t, const std::stri AthAlgTool(t,n,p), m_tileMgr(0), m_tileMgrLocation("Tile"), - m_calo_dd(0), m_trackingVolumeHelper("Trk::TrackingVolumeHelper/TrackingVolumeHelper"), m_trackingVolumeCreator("Trk::CylinderVolumeCreator/TrackingVolumeCreator"), m_tileBarrelEnvelope(25.*mm), diff --git a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/FullLinearizedTrackFactory.h b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/FullLinearizedTrackFactory.h index b86c5ae8728922a7bf9b21dc1cffaf9e6046193e..f6901964d1cc5d68452f7e80a4cd2090dd959e26 100755 --- a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/FullLinearizedTrackFactory.h +++ b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/FullLinearizedTrackFactory.h @@ -77,23 +77,25 @@ namespace Trk * Produces a new PerigeeLinearizedState and stores its pointer as a private * member of VxTrackAtVertex */ - void linearize(VxTrackAtVertex & theTrack,const Amg::Vector3D & linPoint) const; + virtual void linearize(VxTrackAtVertex & theTrack,const Amg::Vector3D & linPoint) const override; /** * Linearization method: * Takes a MeasuredPerigee and a LinearizationPoint. * Creates a new PerigeeLinearizedTrackState and returns its pointer. */ + virtual LinearizedTrack * linearizedTrack(const TrackParameters *param, - const Amg::Vector3D & linPoint) const; + const Amg::Vector3D & linPoint) const override; /** * Linearization method: * Takes a MeasuredPerigee and a LinearizationPoint. * Creates a new PerigeeLinearizedTrackState and returns its pointer. */ + virtual LinearizedTrack * linearizedTrack(const NeutralParameters *param, - const Amg::Vector3D & linPoint) const; + const Amg::Vector3D & linPoint) const override; private: diff --git a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/KalmanVertexTrackUpdator.h b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/KalmanVertexTrackUpdator.h index fe6369ccc351d4dcbefd65472d7e85386d06ba75..f0e86b3253b2b11f67e4833bc8f8afd6b8463cf3 100755 --- a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/KalmanVertexTrackUpdator.h +++ b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/KalmanVertexTrackUpdator.h @@ -56,7 +56,7 @@ namespace Trk /** * Update method */ - void update(VxTrackAtVertex& trk, const xAOD::Vertex& vtx) const; + virtual void update(VxTrackAtVertex& trk, const xAOD::Vertex& vtx) const override; private: diff --git a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/KalmanVertexUpdator.h b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/KalmanVertexUpdator.h index 5e129192a152d928e6220fe1ef17ce52fbbffb8c..bbf9e0ba77fd73176fa05736f6440cdb66792211 100755 --- a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/KalmanVertexUpdator.h +++ b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/KalmanVertexUpdator.h @@ -51,29 +51,29 @@ namespace Trk /** * Method adding a single track to the vertex estimate */ - xAOD::Vertex * add(xAOD::Vertex& vtx, VxTrackAtVertex& trk) const; + virtual xAOD::Vertex * add(xAOD::Vertex& vtx, VxTrackAtVertex& trk) const override; /** * Method removing already added track from the vertex estimate */ - xAOD::Vertex * remove(xAOD::Vertex& vtx, VxTrackAtVertex& trk) const; + virtual xAOD::Vertex * remove(xAOD::Vertex& vtx, VxTrackAtVertex& trk) const override; /** * Position update method. The 'mode' parameter is used to indicate whether we want to add or remove a track. */ - IVertexUpdator::positionUpdateOutcome positionUpdate (const xAOD::Vertex& vtx, const LinearizedTrack * trk, double trackWeight, IVertexUpdator::updateMode mode) const; + virtual IVertexUpdator::positionUpdateOutcome positionUpdate (const xAOD::Vertex& vtx, const LinearizedTrack * trk, double trackWeight, IVertexUpdator::updateMode mode) const override; /** * Method calculating the interstep Chi2 increment */ - float trackParametersChi2(const xAOD::Vertex& new_vtx, const LinearizedTrack * trk) const; - float trackParametersChi2(const IVertexUpdator::positionUpdateOutcome& new_vtx, const LinearizedTrack * trk) const; + virtual float trackParametersChi2(const xAOD::Vertex& new_vtx, const LinearizedTrack * trk) const override; + virtual float trackParametersChi2(const IVertexUpdator::positionUpdateOutcome& new_vtx, const LinearizedTrack * trk) const override; /** * Method calculating the vertex displacement-related part of the chi2 */ - float vertexPositionChi2(const xAOD::Vertex& old_vtx, const xAOD::Vertex& new_vtx) const; - float vertexPositionChi2(const xAOD::Vertex& old_vtx, const IVertexUpdator::positionUpdateOutcome& new_vtx) const; + virtual float vertexPositionChi2(const xAOD::Vertex& old_vtx, const xAOD::Vertex& new_vtx) const override; + virtual float vertexPositionChi2(const xAOD::Vertex& old_vtx, const IVertexUpdator::positionUpdateOutcome& new_vtx) const override; private: diff --git a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/TrackToVertexIPEstimator.h b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/TrackToVertexIPEstimator.h index 7354c548e76e759a073fe9f60efdfc8cc34881b3..d649f5a748b991e5f8f71fa5e3ffe7b023dddb3b 100644 --- a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/TrackToVertexIPEstimator.h +++ b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/TrkVertexFitterUtils/TrackToVertexIPEstimator.h @@ -92,41 +92,47 @@ namespace Trk * Estimate methods returning a d0 and its calculated sigma. * All methods do check whether a track is actually fitted to a vertex */ - const ImpactParametersAndSigma * estimate(const xAOD::TrackParticle * track, const xAOD::Vertex * vtx, bool doRemoval) const; - const ImpactParametersAndSigma * estimate(const TrackParameters * track, const xAOD::Vertex * vtx, bool doRemoval) const; + virtual const ImpactParametersAndSigma * estimate(const xAOD::TrackParticle * track, const xAOD::Vertex * vtx, bool doRemoval) const override; + virtual const ImpactParametersAndSigma * estimate(const TrackParameters * track, const xAOD::Vertex * vtx, bool doRemoval) const override; - const ImpactParametersAndSigma * estimate(const xAOD::TrackParticle * track,const xAOD::TrackParticle * newtrack, const xAOD::Vertex * vtx, bool doRemoval) const; - const ImpactParametersAndSigma * estimate(const TrackParameters * track, const TrackParameters * newtrack, const xAOD::Vertex * vtx, bool doRemoval) const; + virtual const ImpactParametersAndSigma * estimate(const xAOD::TrackParticle * track,const xAOD::TrackParticle * newtrack, const xAOD::Vertex * vtx, bool doRemoval) const override; + virtual const ImpactParametersAndSigma * estimate(const TrackParameters * track, const TrackParameters * newtrack, const xAOD::Vertex * vtx, bool doRemoval) const override; - virtual const xAOD::Vertex * getUnbiasedVertex(const xAOD::TrackParticle * track, const xAOD::Vertex * vtx ) const ; - virtual const xAOD::Vertex * getUnbiasedVertex(const TrackParameters * track, const xAOD::Vertex * vtx ) const ; + virtual const xAOD::Vertex * getUnbiasedVertex(const xAOD::TrackParticle * track, const xAOD::Vertex * vtx ) const override; + virtual const xAOD::Vertex * getUnbiasedVertex(const TrackParameters * track, const xAOD::Vertex * vtx ) const override; - virtual const ImpactParametersAndSigma * estimate(const xAOD::TrackParticle * track, const xAOD::Vertex* vtx)const; - virtual const ImpactParametersAndSigma * estimate(const TrackParameters * track, const xAOD::Vertex* vtx)const; + virtual const ImpactParametersAndSigma * estimate(const xAOD::TrackParticle * track, const xAOD::Vertex* vtx)const override; + virtual const ImpactParametersAndSigma * estimate(const TrackParameters * track, const xAOD::Vertex* vtx)const override; /* Methods which provide the lifetime Sign for the Impact Parameter (2D, Z, 3D) */ + virtual double get3DLifetimeSignOfTrack(const TrackParameters & track, const Amg::Vector3D & jetDirection, - const xAOD::Vertex & primaryVertex) const; + const xAOD::Vertex & primaryVertex) const override; + virtual double get3DLifetimeSignOfTrack(const TrackParameters & track, const CLHEP::Hep3Vector & jetDirection, - const xAOD::Vertex & primaryVertex) const; + const xAOD::Vertex & primaryVertex) const override; + virtual double get2DLifetimeSignOfTrack(const TrackParameters & track, const Amg::Vector3D & jetDirection, - const xAOD::Vertex & primaryVertex) const; + const xAOD::Vertex & primaryVertex) const override; + virtual double get2DLifetimeSignOfTrack(const TrackParameters & track, const CLHEP::Hep3Vector & jetDirection, - const xAOD::Vertex & primaryVertex) const; + const xAOD::Vertex & primaryVertex) const override; + virtual double getZLifetimeSignOfTrack(const TrackParameters & track, const Amg::Vector3D & jetDirection, - const xAOD::Vertex & primaryVertex) const; + const xAOD::Vertex & primaryVertex) const override; + virtual double getZLifetimeSignOfTrack(const TrackParameters & track, const CLHEP::Hep3Vector & jetDirection, - const xAOD::Vertex & primaryVertex) const; + const xAOD::Vertex & primaryVertex) const override; diff --git a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/src/NeutralParticleParameterCalculator.h b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/src/NeutralParticleParameterCalculator.h index f483e52c63740314eb58f67040a48cbe9b198683..aa2e7c30e73b8abf022d703e4cfaf59ab014ca24 100755 --- a/Tracking/TrkVertexFitter/TrkVertexFitterUtils/src/NeutralParticleParameterCalculator.h +++ b/Tracking/TrkVertexFitter/TrkVertexFitterUtils/src/NeutralParticleParameterCalculator.h @@ -58,7 +58,7 @@ namespace Trk /** * method that makes the parameters of a V0 or photon before decay to two tracks */ - NeutralPerigee* createNeutralTrackFromVertex(const xAOD::Vertex& ) const; + virtual NeutralPerigee* createNeutralTrackFromVertex(const xAOD::Vertex& ) const override; private: