diff --git a/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/CscRdoContByteStreamCnv.h b/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/CscRdoContByteStreamCnv.h index e869b2ad0e2a091aa77ae59a338514f427950b7c..c852b3c50bcd76dbc10fc0b5f0055fcd943dc285 100644 --- a/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/CscRdoContByteStreamCnv.h +++ b/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/CscRdoContByteStreamCnv.h @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration */ #ifndef MUONBYTESTREAM_CSCRDOCONTRAWEVENTCNV_H @@ -18,8 +18,6 @@ class StoreGateSvc; // Abstract factory to create the converter template <class TYPE> class CnvFactory; -// Externals -extern long ByteStream_StorageType; /* ByteStream Converter between CSC RDO <---> BYTE STREAM @@ -33,16 +31,16 @@ class CscRdoContByteStreamCnv: public Converter public: CscRdoContByteStreamCnv(ISvcLocator* svcloc); - virtual StatusCode initialize(); - virtual StatusCode createObj(IOpaqueAddress* /*pAddr*/, DataObject*& /*pObj*/){ + virtual StatusCode initialize() override; + virtual StatusCode createObj(IOpaqueAddress* /*pAddr*/, DataObject*& /*pObj*/) override { return StatusCode::FAILURE; } - virtual StatusCode createRep(DataObject* pObj, IOpaqueAddress*& pAddr); + virtual StatusCode createRep(DataObject* pObj, IOpaqueAddress*& pAddr) override; /// Storage type and class ID - virtual long repSvcType() const { return ByteStream_StorageType;} - static long storageType() { return ByteStream_StorageType;} + virtual long repSvcType() const override { return i_repSvcType(); } + static long storageType(); static const CLID& classID(); private: diff --git a/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/MdtCsmContByteStreamCnv.h b/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/MdtCsmContByteStreamCnv.h index 041807a881ba5f1eb62c36b27c5102ecc0f84e67..1dbb6c9a2ed452184020862bf908da449db25195 100644 --- a/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/MdtCsmContByteStreamCnv.h +++ b/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/MdtCsmContByteStreamCnv.h @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration */ #ifndef MUONBYTESTREAM_MDTCSMCONTRAWEVENTCNV_H @@ -25,10 +25,6 @@ class StoreGateSvc; // Abstract factory to create the converter template <class TYPE> class CnvFactory; -// Externals -//extern svcType_t ByteStream_StorageType; -extern long ByteStream_StorageType; - class MdtCsmContByteStreamCnv: public Converter { public: @@ -36,15 +32,15 @@ class MdtCsmContByteStreamCnv: public Converter { typedef Muon::IMDT_RDOtoByteStreamTool BYTESTREAMTOOL ; - virtual StatusCode initialize(); - virtual StatusCode createObj(IOpaqueAddress* /**pAddr*/, DataObject*& /**pObj*/){ + virtual StatusCode initialize() override; + virtual StatusCode createObj(IOpaqueAddress* /**pAddr*/, DataObject*& /**pObj*/) override { return StatusCode::FAILURE; } - virtual StatusCode createRep(DataObject* pObj, IOpaqueAddress*& pAddr); + virtual StatusCode createRep(DataObject* pObj, IOpaqueAddress*& pAddr) override; /// Storage type and class ID - virtual long repSvcType() const { return ByteStream_StorageType;} - static long storageType() { return ByteStream_StorageType; } + virtual long repSvcType() const override { return i_repSvcType(); } + static long storageType(); static const CLID& classID(); private: diff --git a/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/RpcPadContByteStreamCnv.h b/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/RpcPadContByteStreamCnv.h index 9ef2f2440140419c0f2c6f9ed42dee69f82d898b..225c3a6fdaf9f499309ba953399d4ee9ca2b25ba 100644 --- a/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/RpcPadContByteStreamCnv.h +++ b/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/RpcPadContByteStreamCnv.h @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration */ #ifndef MUONBYTESTREAM_RPCPADCONTBYTESTREAMCNV_H @@ -33,9 +33,6 @@ class MsgStream; // Abstract factory to create the converter template <class TYPE> class CnvFactory; -// Externals -extern long ByteStream_StorageType; - class RpcPadContByteStreamCnv: public Converter { public: @@ -43,16 +40,15 @@ class RpcPadContByteStreamCnv: public Converter { typedef Muon::IRPC_RDOtoByteStreamTool BYTESTREAMTOOL ; - virtual StatusCode initialize(); - virtual StatusCode createObj(IOpaqueAddress* /*pAddr*/, DataObject*& /*pObj*/){ + virtual StatusCode initialize() override; + virtual StatusCode createObj(IOpaqueAddress* /*pAddr*/, DataObject*& /*pObj*/) override { return StatusCode::FAILURE; } - virtual StatusCode createRep(DataObject* pObj, IOpaqueAddress*& pAddr); + virtual StatusCode createRep(DataObject* pObj, IOpaqueAddress*& pAddr) override; /// Storage type and class ID - //virtual long repSvcType() const { return ByteStream_StorageType;} - virtual long repSvcType() const { return ByteStream_StorageType;} - static long storageType() { return ByteStream_StorageType; } + virtual long repSvcType() const override { return i_repSvcType(); } + static long storageType(); static const CLID& classID(); private: diff --git a/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/TgcRdoContByteStreamCnv.h b/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/TgcRdoContByteStreamCnv.h index d065adcfc4b52e1cf6bebee54986847cd4fef030..a2e2cbc668a68f9a0060468a4ee1f52b47c40642 100644 --- a/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/TgcRdoContByteStreamCnv.h +++ b/MuonSpectrometer/MuonCnv/MuonByteStream/MuonByteStream/TgcRdoContByteStreamCnv.h @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration */ #ifndef MUONBYTESTREAM_TGCRDOCONTRAWEVENTCNV_H @@ -23,9 +23,6 @@ namespace Muon { // Abstract factory to create the converter template <class TYPE> class CnvFactory; -// Externals -extern long ByteStream_StorageType; - /* ByteStream Converter between TGC bareRDO and BS @@ -38,17 +35,17 @@ class TgcRdoContByteStreamCnv: public Converter public: TgcRdoContByteStreamCnv(ISvcLocator* svcloc); - virtual StatusCode initialize(); + virtual StatusCode initialize() override; - virtual StatusCode createObj(IOpaqueAddress* /**pAddr*/, DataObject*& /**pObj*/){ + virtual StatusCode createObj(IOpaqueAddress* /**pAddr*/, DataObject*& /**pObj*/) override { return StatusCode::FAILURE; } - virtual StatusCode createRep(DataObject* pObj, IOpaqueAddress*& pAddr); + virtual StatusCode createRep(DataObject* pObj, IOpaqueAddress*& pAddr) override; /// Storage type and class ID - virtual long repSvcType() const { return ByteStream_StorageType;} - static long storageType() {return ByteStream_StorageType;} + virtual long repSvcType() const override { return i_repSvcType(); } + static long storageType(); static const CLID& classID(); private: diff --git a/MuonSpectrometer/MuonCnv/MuonByteStream/src/CscRdoContByteStreamCnv.cxx b/MuonSpectrometer/MuonCnv/MuonByteStream/src/CscRdoContByteStreamCnv.cxx index f9906cb0fbf92d52b08b6f6326f150ea0e13b2d5..f5b5d6bf667413bc95a85720c312cac70979f22d 100644 --- a/MuonSpectrometer/MuonCnv/MuonByteStream/src/CscRdoContByteStreamCnv.cxx +++ b/MuonSpectrometer/MuonCnv/MuonByteStream/src/CscRdoContByteStreamCnv.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration */ #include "MuonByteStream/CscRdoContByteStreamCnv.h" @@ -28,7 +28,7 @@ const std::string const_cnvName = "CscRdoContByteStreamCnv"; // constructor CscRdoContByteStreamCnv::CscRdoContByteStreamCnv(ISvcLocator* svcloc) - : Converter(ByteStream_StorageType, classID(), svcloc), + : Converter(storageType(), classID(), svcloc), m_tool("Muon::CscRdoContByteStreamTool"), m_byteStreamEventAccess("ByteStreamCnvSvc", const_cnvName), m_storeGate("StoreGateSvc", const_cnvName) @@ -41,6 +41,10 @@ const CLID& CscRdoContByteStreamCnv::classID() return ClassID_traits<CscRawDataContainer>::ID(); } +long CscRdoContByteStreamCnv::storageType() +{ + return ByteStreamAddress::storageType(); +} // initialize StatusCode CscRdoContByteStreamCnv::initialize() diff --git a/MuonSpectrometer/MuonCnv/MuonByteStream/src/MdtCsmContByteStreamCnv.cxx b/MuonSpectrometer/MuonCnv/MuonByteStream/src/MdtCsmContByteStreamCnv.cxx index e0361c0a62f47a6ae719c206c3729f684e0d7ac5..c7c335bbc0874e14d893db845106b3a0ac1e0b2a 100644 --- a/MuonSpectrometer/MuonCnv/MuonByteStream/src/MdtCsmContByteStreamCnv.cxx +++ b/MuonSpectrometer/MuonCnv/MuonByteStream/src/MdtCsmContByteStreamCnv.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration */ #include "MuonByteStream/MdtCsmContByteStreamCnv.h" @@ -29,7 +29,7 @@ #include <map> MdtCsmContByteStreamCnv::MdtCsmContByteStreamCnv(ISvcLocator* svcloc) : - Converter(ByteStream_StorageType, classID(),svcloc), + Converter(storageType(), classID(),svcloc), m_tool("Muon::MdtCsmContByteStreamTool"), m_byteStreamEventAccess("ByteStreamCnvSvc", "MdtCsmContByteStreamCnv"), m_storeGate("StoreGateSvc", "MdtCsmContByteStreamCnv") @@ -40,6 +40,9 @@ const CLID& MdtCsmContByteStreamCnv::classID(){ return ClassID_traits<MdtCsmContainer>::ID() ; } +long MdtCsmContByteStreamCnv::storageType(){ + return ByteStreamAddress::storageType(); +} StatusCode MdtCsmContByteStreamCnv::initialize() { MsgStream log(msgSvc(), "MdtCsmContByteStreamCnv"); diff --git a/MuonSpectrometer/MuonCnv/MuonByteStream/src/RpcPadContByteStreamCnv.cxx b/MuonSpectrometer/MuonCnv/MuonByteStream/src/RpcPadContByteStreamCnv.cxx index 12b58e33455ee9376aa67884eac3346a00c4b7d3..979e3575ebbbef853f73fcb9f57a9efbde4e6b17 100644 --- a/MuonSpectrometer/MuonCnv/MuonByteStream/src/RpcPadContByteStreamCnv.cxx +++ b/MuonSpectrometer/MuonCnv/MuonByteStream/src/RpcPadContByteStreamCnv.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration */ #include "MuonByteStream/RpcPadContByteStreamCnv.h" @@ -33,7 +33,7 @@ #include <map> RpcPadContByteStreamCnv::RpcPadContByteStreamCnv(ISvcLocator* svcloc) : - Converter(ByteStream_StorageType, classID(),svcloc), + Converter(storageType(), classID(),svcloc), m_tool("Muon::RpcPadContByteStreamTool"), m_byteStreamEventAccess("ByteStreamCnvSvc", "RpcPadContByteStreamCnv"), m_storeGate("StoreGateSvc", "RpcPadContByteStreamCnv") @@ -43,6 +43,9 @@ const CLID& RpcPadContByteStreamCnv::classID(){ return ClassID_traits<RpcPadContainer>::ID() ; } +long RpcPadContByteStreamCnv::storageType(){ + return ByteStreamAddress::storageType(); +} StatusCode RpcPadContByteStreamCnv::initialize() { MsgStream log(msgSvc(), "RpcPadContByteStreamCnv"); diff --git a/MuonSpectrometer/MuonCnv/MuonByteStream/src/TgcRdoContByteStreamCnv.cxx b/MuonSpectrometer/MuonCnv/MuonByteStream/src/TgcRdoContByteStreamCnv.cxx index 50666364ece6dc726cad3b11db5f01d2b00e67f9..f3f4d1136515b85749695fa67c1cc2083a4efc42 100644 --- a/MuonSpectrometer/MuonCnv/MuonByteStream/src/TgcRdoContByteStreamCnv.cxx +++ b/MuonSpectrometer/MuonCnv/MuonByteStream/src/TgcRdoContByteStreamCnv.cxx @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration */ #include "MuonByteStream/TgcRdoContByteStreamCnv.h" @@ -26,7 +26,7 @@ const std::string const_cnvName = "TgcRdoContByteStreamCnv"; // constructor TgcRdoContByteStreamCnv::TgcRdoContByteStreamCnv(ISvcLocator* svcloc) - : Converter(ByteStream_StorageType, classID(), svcloc), + : Converter(storageType(), classID(), svcloc), m_tool("Muon::TgcRdoContByteStreamTool"), m_byteStreamEventAccess("ByteStreamCnvSvc", const_cnvName), m_storeGate("StoreGateSvc", const_cnvName) @@ -39,6 +39,10 @@ const CLID& TgcRdoContByteStreamCnv::classID() return ClassID_traits<TgcRdoContainer>::ID(); } +long TgcRdoContByteStreamCnv::storageType() +{ + return ByteStreamAddress::storageType(); +} // initialize StatusCode TgcRdoContByteStreamCnv::initialize()