From af3fd79254bc984d1a80ec1aea94a1a1f3c15e67 Mon Sep 17 00:00:00 2001
From: christos <christos@cern.ch>
Date: Sun, 19 Jul 2020 05:55:06 +0200
Subject: [PATCH] TrkCaloClusterROI use localToglobalPos to avoid dynamic
allocation
---
Tracking/TrkEvent/TrkCaloClusterROI/src/CaloClusterROI.cxx | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/Tracking/TrkEvent/TrkCaloClusterROI/src/CaloClusterROI.cxx b/Tracking/TrkEvent/TrkCaloClusterROI/src/CaloClusterROI.cxx
index d5c714aafc8..f0ef20cc0fa 100644
--- a/Tracking/TrkEvent/TrkCaloClusterROI/src/CaloClusterROI.cxx
+++ b/Tracking/TrkEvent/TrkCaloClusterROI/src/CaloClusterROI.cxx
@@ -24,7 +24,6 @@ Trk::CaloClusterROI::CaloClusterROI( const Trk::LocalParameters* locpars,
m_etaWidth( widtheta )
{
m_surface = surface.isFree() ? surface.clone() : &surface;
- this->globalPosition();
}
// Destructor:
@@ -78,11 +77,10 @@ Trk::CaloClusterROI& Trk::CaloClusterROI::operator=(const Trk::CaloClusterROI& c
Amg::Vector3D Trk::CaloClusterROI::globalPosition() const
{
if(m_localParams){
- std::unique_ptr<const Amg::Vector3D> tmp_global(m_surface->localToGlobal(*m_localParams));
- return *tmp_global; // return "copy"
+ return m_surface->localToGlobalPos(*m_localParams);
}
if(m_surface){
- return Amg::Vector3D(m_surface->center());
+ return m_surface->center();
}
return Amg::Vector3D();
}
--
GitLab