From d6ff689ea46cfabffa578b5f821aca28e61cf3d7 Mon Sep 17 00:00:00 2001 From: scott snyder <sss@karma> Date: Tue, 18 Aug 2020 22:32:59 -0400 Subject: [PATCH] EventPrimitives: Fix cppcheck warnings. Pass class instances by const reference, not by value. --- .../EventPrimitives/EventPrimitivesToStringConverter.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Event/EventPrimitives/EventPrimitives/EventPrimitivesToStringConverter.h b/Event/EventPrimitives/EventPrimitives/EventPrimitivesToStringConverter.h index 2040d155174..d478ff8764a 100644 --- a/Event/EventPrimitives/EventPrimitives/EventPrimitivesToStringConverter.h +++ b/Event/EventPrimitives/EventPrimitives/EventPrimitivesToStringConverter.h @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration */ /////////////////////////////////////////////////////////////////// @@ -40,7 +40,7 @@ namespace Amg { } - inline std::string toString( const MatrixX& matrix, int precision = 4, std::string offset="" ){ + inline std::string toString( const MatrixX& matrix, int precision = 4, const std::string& offset="" ){ std::ostringstream sout; sout << std::setiosflags(std::ios::fixed) << std::setprecision(precision); @@ -72,7 +72,7 @@ namespace Amg { } #ifndef XAOD_STANDALONE - inline std::string toString( const CLHEP::HepGenMatrix& matrix, int precision = 4, std::string offset="" ){ + inline std::string toString( const CLHEP::HepGenMatrix& matrix, int precision = 4, const std::string& offset="" ){ std::ostringstream sout; sout << std::setiosflags(std::ios::fixed) << std::setprecision(precision); -- GitLab