From e52895faed61d22c4e9cf5a46aff1044c373a543 Mon Sep 17 00:00:00 2001
From: John Chapman <jchapman@cern.ch>
Date: Fri, 28 Aug 2020 15:23:33 +0200
Subject: [PATCH] clang-tidy fixes for CaloSamplingFractionAnalysis package
---
.../src/LArFCalSamplingFraction.cxx | 4 ++--
.../src/LArFCalSamplingFraction.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Simulation/Tools/CaloSamplingFractionAnalysis/src/LArFCalSamplingFraction.cxx b/Simulation/Tools/CaloSamplingFractionAnalysis/src/LArFCalSamplingFraction.cxx
index e4a5321e25f..44cd987084e 100644
--- a/Simulation/Tools/CaloSamplingFractionAnalysis/src/LArFCalSamplingFraction.cxx
+++ b/Simulation/Tools/CaloSamplingFractionAnalysis/src/LArFCalSamplingFraction.cxx
@@ -672,7 +672,7 @@ StatusCode LArFCalSamplingFraction::doCalib()
/// FCal Analysis with Calibration Hits on
/// Added by JPA, June 2005
-void LArFCalSamplingFraction::FCalCalibAnalysis(const std::string name, const CaloCalibrationHit *CalibHit)
+void LArFCalSamplingFraction::FCalCalibAnalysis(const std::string& name, const CaloCalibrationHit *CalibHit)
{
Identifier id = CalibHit->cellID();
double energy = CalibHit->energyTotal();
@@ -751,7 +751,7 @@ void LArFCalSamplingFraction::TruthImpactPosition(McEventCollection::const_itera
// Note: old GenParticles used HepLorentzVectors, now they use HepMC::FourVectors
// Get the kinematic variables
- HepMC::FourVector HMCmom = theParticle->momentum();
+ const HepMC::FourVector& HMCmom = theParticle->momentum();
CLHEP::HepLorentzVector momentum(CLHEP::Hep3Vector(HMCmom.px(), HMCmom.py(), HMCmom.pz()), HMCmom.e());
HepMC::FourVector HMC3vec(0.0,0.0,0.0,0.0);
diff --git a/Simulation/Tools/CaloSamplingFractionAnalysis/src/LArFCalSamplingFraction.h b/Simulation/Tools/CaloSamplingFractionAnalysis/src/LArFCalSamplingFraction.h
index 525b4704501..be3cd13e841 100644
--- a/Simulation/Tools/CaloSamplingFractionAnalysis/src/LArFCalSamplingFraction.h
+++ b/Simulation/Tools/CaloSamplingFractionAnalysis/src/LArFCalSamplingFraction.h
@@ -47,7 +47,7 @@ public:
StatusCode doFCal();
void TruthImpactPosition(McEventCollection::const_iterator);
- void FCalCalibAnalysis(const std::string name, const CaloCalibrationHit *CalibHit);
+ void FCalCalibAnalysis(const std::string& name, const CaloCalibrationHit *CalibHit);
void FCalClusterCenter(const LArHitContainer *container);
void FCalHitCenter(const LArHitContainer *container);
void FillCellInfo(const GeoLArHit &fcalhit, std::vector<double> *cell_E,
--
GitLab