From ff26d53d4eac80f23ae900ca72ca07e510b1a3ea Mon Sep 17 00:00:00 2001
From: Kristian Bjoerke <krbjeork@cern.ch>
Date: Wed, 5 Dec 2018 13:46:07 +0100
Subject: [PATCH] Declare an argument as const if not changes by function
According to ATLAS code guidelines a pointer or reference
arguments, passed to a function, should be declared as const
if the function does not change the object bound to it. [const-arguments]
Former-commit-id: 135c61cde4efb90540f5d8861226b4314dfd4f2d
---
.../SCT_RawDataByteStreamCnv/ISCT_RodEncoder.h | 2 +-
.../SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.cxx | 4 ++--
.../SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.h | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/SCT_RawDataByteStreamCnv/ISCT_RodEncoder.h b/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/SCT_RawDataByteStreamCnv/ISCT_RodEncoder.h
index 46b5a835c59..cc51ee48c43 100644
--- a/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/SCT_RawDataByteStreamCnv/ISCT_RodEncoder.h
+++ b/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/SCT_RawDataByteStreamCnv/ISCT_RodEncoder.h
@@ -33,7 +33,7 @@ class ISCT_RodEncoder : virtual public IAlgTool {
DeclareInterfaceID(ISCT_RodEncoder, 1, 0);
/** convert all collections of RDO's in the current list to vector of 32bit words */
- virtual void fillROD(std::vector<uint32_t>& vec32Data, const uint32_t& robID, vRDOs& vecRDOs) const = 0;
+ virtual void fillROD(std::vector<uint32_t>& vec32Data, const uint32_t& robID, const vRDOs& vecRDOs) const = 0;
};
diff --git a/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.cxx b/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.cxx
index f2259b8aaa4..9f7a51eb3b8 100644
--- a/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.cxx
+++ b/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.cxx
@@ -85,7 +85,7 @@ StatusCode SCT_RodEncoder::finalize() {
///=========================================================================
void SCT_RodEncoder::fillROD(std::vector<uint32_t>& vec32Data, const uint32_t& robID,
- vRDOs_t& vecRDOs) const {
+ const vRDOs_t& vecRDOs) const {
/** retrieve errors from SCT_ByteStreamErrorsSvc */
@@ -275,7 +275,7 @@ void SCT_RodEncoder::addSpecificErrors(const uint32_t& robID, const std::set<Ide
/// Encode Data function
///=========================================================================
-void SCT_RodEncoder::encodeData(std::vector<int>& vecTimeBins, std::vector<uint16_t>& vec16Words, const RDO *rdo, const int& groupSize, const int& strip) const {
+void SCT_RodEncoder::encodeData(const std::vector<int>& vecTimeBins, std::vector<uint16_t>& vec16Words, const RDO *rdo, const int& groupSize, const int& strip) const {
const int encodedSide{side(rdo) << 14};
diff --git a/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.h b/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.h
index 4c4331f2fca..82407534ae0 100644
--- a/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.h
+++ b/InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv/src/SCT_RodEncoder.h
@@ -58,12 +58,12 @@ class SCT_RodEncoder : public extends<AthAlgTool, ISCT_RodEncoder>
virtual StatusCode finalize();
/// convert all collections of RDO's in the current list to vector of 32bit words
- virtual void fillROD(std::vector<uint32_t>& vec32Data, const uint32_t& robID, vRDOs_t& vecRDOs) const;
+ virtual void fillROD(std::vector<uint32_t>& vec32Data, const uint32_t& robID, const vRDOs_t& vecRDOs) const;
private:
/// Encode rdo into the data: called by fillROD(..)
- void encodeData(std::vector<int>& vecTimeBins, std::vector<uint16_t>& vec16Words, const RDO *rdo, const int& groupSize, const int& strip) const;
+ void encodeData(const std::vector<int>& vecTimeBins, std::vector<uint16_t>& vec16Words, const RDO *rdo, const int& groupSize, const int& strip) const;
/// pack 32 bit word: called by encodeData(..)
void packFragments(std::vector<uint16_t>& vec16Words, std::vector<uint32_t>& vec32Words) const;
--
GitLab