From b10b8c03f7079fa282e38d729662e2595b4826ca Mon Sep 17 00:00:00 2001
From: Frank Winklmeier <frank.winklmeier@cern.ch>
Date: Mon, 9 Dec 2024 18:01:02 +0100
Subject: [PATCH] ActsEvent: fix cppcheck defects
Remove error suppression and use initializer list.
---
.../Acts/ActsEvent/test/MultiTrajectoryBasic_test.cxx | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Tracking/Acts/ActsEvent/test/MultiTrajectoryBasic_test.cxx b/Tracking/Acts/ActsEvent/test/MultiTrajectoryBasic_test.cxx
index 16dc8177b83..5a5a85b41cf 100644
--- a/Tracking/Acts/ActsEvent/test/MultiTrajectoryBasic_test.cxx
+++ b/Tracking/Acts/ActsEvent/test/MultiTrajectoryBasic_test.cxx
@@ -107,7 +107,6 @@ struct EmptyTrackStatesAux {
ActsTrk::MutableMultiTrajectory m;
};
-// cppcheck-suppress syntaxError
BOOST_FIXTURE_TEST_CASE(AllMtjStaticxAODVariablesAreKnown, EmptyTrackStatesAux) {
for (auto id : m.trackStatesAux()->getStore()->getAuxIDs()) {
const std::string name = SG::AuxTypeRegistry::instance().getName(id);
@@ -171,9 +170,9 @@ std::default_random_engine rng(31415);
BOOST_AUTO_TEST_SUITE(EventDataMultiTrajectory)
struct EmptyMTJ { // setup empty MTJ
- EmptyMTJ() {
- mtj = std::make_unique<ActsTrk::MutableMultiTrajectory>();
- }
+ EmptyMTJ() :
+ mtj(std::make_unique<ActsTrk::MutableMultiTrajectory>())
+ {}
std::unique_ptr<ActsTrk::MutableMultiTrajectory> mtj;
ActsTrk::MultiTrajectory* ro_mtj() {
@@ -196,7 +195,6 @@ BOOST_AUTO_TEST_CASE(OwningMTJ) {
ActsTrk::MutableMultiTrajectory mtj;
}
-// cppcheck-suppress syntaxError
BOOST_FIXTURE_TEST_CASE(Fill, EmptyMTJ) {
BOOST_CHECK(mtj->has_backends());
constexpr auto kMask = Acts::TrackStatePropMask::Predicted;
--
GitLab