From fbe5f604c539a9f394d6bd8f7bd7d6e43e94ce9c Mon Sep 17 00:00:00 2001
From: Scott Snyder <scott.snyder@cern.ch>
Date: Thu, 5 Dec 2024 13:20:40 +0100
Subject: [PATCH] ActsDataPreparation: Fix cppcheck warnings.
ActsDataPreparation: Fix cppcheck warnings.
Pass containers by const reference, not by value.
---
.../src/CoreStripSpacePointFormationTool.cxx | 6 +++---
.../src/CoreStripSpacePointFormationTool.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Tracking/Acts/ActsDataPreparation/src/CoreStripSpacePointFormationTool.cxx b/Tracking/Acts/ActsDataPreparation/src/CoreStripSpacePointFormationTool.cxx
index d0810d4f5f9..97f3ee44871 100644
--- a/Tracking/Acts/ActsDataPreparation/src/CoreStripSpacePointFormationTool.cxx
+++ b/Tracking/Acts/ActsDataPreparation/src/CoreStripSpacePointFormationTool.cxx
@@ -303,9 +303,9 @@ namespace ActsTrk
StatusCode CoreStripSpacePointFormationTool::fillSpacePoints(const EventContext &ctx,
std::shared_ptr<Acts::SpacePointBuilder<StripSP>> spBuilder,
- std::array<const InDetDD::SiDetectorElement *,nNeighbours> elements,
- std::array<std::vector<std::pair<ATLASUncalibSourceLink, size_t>>,nNeighbours> sourceLinks,
- std::array<double, 14> overlapExtents,
+ const std::array<const InDetDD::SiDetectorElement *,nNeighbours>& elements,
+ const std::array<std::vector<std::pair<ATLASUncalibSourceLink, size_t>>,nNeighbours>& sourceLinks,
+ const std::array<double, 14>& overlapExtents,
const Amg::Vector3D &beamSpotVertex,
std::vector<StripSP>& spacePoints,
std::vector<StripSP>& overlapSpacePoints ) const
diff --git a/Tracking/Acts/ActsDataPreparation/src/CoreStripSpacePointFormationTool.h b/Tracking/Acts/ActsDataPreparation/src/CoreStripSpacePointFormationTool.h
index 7cf5acf92e7..fa9a5905f6a 100644
--- a/Tracking/Acts/ActsDataPreparation/src/CoreStripSpacePointFormationTool.h
+++ b/Tracking/Acts/ActsDataPreparation/src/CoreStripSpacePointFormationTool.h
@@ -60,9 +60,9 @@ namespace ActsTrk {
StatusCode fillSpacePoints(const EventContext& ctx,
std::shared_ptr<Acts::SpacePointBuilder<StripSP>> spBuilder,
- std::array<const InDetDD::SiDetectorElement*,nNeighbours> neighbourElements,
- std::array<std::vector<std::pair<ATLASUncalibSourceLink, size_t>>,nNeighbours> neighbourSourceLinks,
- std::array<double, 14> overlapExtents,
+ const std::array<const InDetDD::SiDetectorElement*,nNeighbours>& neighbourElements,
+ const std::array<std::vector<std::pair<ATLASUncalibSourceLink, size_t>>,nNeighbours>& neighbourSourceLinks,
+ const std::array<double, 14>& overlapExtents,
const Amg::Vector3D& beamSpotVertex,
std::vector<StripSP>& spacePoints,
std::vector<StripSP>& overlapSpacePoints ) const;
--
GitLab