Carina Antunes (bd58c7cd) at 21 Feb 17:17
hotfix: pause posting restrictions check on send notification with ...
Carina Antunes (233ec326) at 21 Feb 17:17
Carina Antunes (8ff1b871) at 21 Feb 17:17
hotfix: pause posting restrictions check on send notification with ...
Jose Semedo (233ec326) at 21 Feb 17:12
Skip posting restrictions.
Posting restrictions are implemented on addition of e-group to channel members and on send notification to direct targets (which adds e-group to members)
Adding to members is only possible via UI. Current implementation checks against authenticated user.
Should be split in 3 tasks:
However for the send-notification action there are a couple of different flows possible:
Current flow is faulty:
refresh in a moment for a summary of status of delivery
, show loading spinner on notification until routing is complete)Besides the mentioned above, currently it seems users can bypass posting restrictions by adding the sender as member to egroup-notification-master
- managed by Natalie Kane.
We do not want to re-implement this functionality, so ideally we'd like to respect membership to this e-group to allow bypassing posting restrictions.
More information on this is needed. A couple of question unanswered so far:
egroup-notification-master
? Do we support secondary/service accounts as channel owners?bypass posting restrictions identity
+ valid flag. This could be any CERN identity (Secondary, Service, or Primary), which is a member of egroup-notification-master
. On save we would need to check authenticated user has permissions on said account (get /identity/upn, check ownerId
field)egroup-notification-master
. On send time (routing/expansion), or we would need a cron job to check if owner/admins still have privileges over all channel groups (members, and bypass posting restrictions identity
)Currently OKD Alerts is owned by Jack Henschel, with admin-egroup openshift-admins
. But it is the service account wwwprot
owned by Andreas Wagner which is a member of egroup-notification-master
. A bit of a difficult scenario, either Jack's account or the openshift-admins
would need to be added to egroup-notification-master
. Alternatively for Jack to set the account wwwprot
as the posting bypass identity, we would need to check if any member of the admin-egroup is the owner of wwwprot
, or Jack would need to ask Andreas to login and set the field.
Jose Semedo (36570083) at 20 Feb 16:35
Allow CERN Library newsletter bypass.
Jose Semedo (9e194648) at 19 Feb 15:25
Add preliminary instrumentation.
Carina Antunes (4aa1a838) at 15 Feb 18:48
hotfix: allow bypassing posting restrictions on okd4 alerts
Carina Antunes (5e878869) at 15 Feb 18:47
Carina Antunes (5e878869) at 15 Feb 18:47
hotfix: allow bypassing posting restrictions on okd4 alerts
Carina Antunes (5e878869) at 15 Feb 18:45
hotfix: allow bypassing posting restrictions on okd4 alerts