notifications-routing merge requestshttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests2024-03-17T17:43:54+01:00https://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/123Struggle with working automatic instrumentation2024-03-17T17:43:54+01:00Jose SemedoStruggle with working automatic instrumentationCloses #
Changes:
-Closes #
Changes:
-Jose SemedoJose Semedohttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/122Draft: [#85] Don't send notifications to NOT OK devices (exclude EXPIRED and ...2023-12-04T09:04:32+01:00Emmanuel OrmanceyDraft: [#85] Don't send notifications to NOT OK devices (exclude EXPIRED and other statuses)Closes #
Changes:
- Add the complete device object to the ActiveMQ message, so the status can be checked at consumer level.
- Adding the complete device object to have consistency accross device types.
Closes #85Closes #
Changes:
- Add the complete device object to the ActiveMQ message, so the status can be checked at consumer level.
- Adding the complete device object to have consistency accross device types.
Closes #85Emmanuel OrmanceyEmmanuel Ormanceyhttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/121[#85] Refactor message handling to queues: Add the complete device object to...2024-01-08T20:03:13+01:00Emmanuel Ormancey[#85] Refactor message handling to queues: Add the complete device object to the ActiveMQ message for consistency across device typesCloses #
Changes:
* Add the complete device object to the ActiveMQ message, so the status can be checked at consumer level.
* Adding the complete device object to have consistency across device types.
Works with https://gitlab.cern.ch/...Closes #
Changes:
* Add the complete device object to the ActiveMQ message, so the status can be checked at consumer level.
* Adding the complete device object to have consistency across device types.
Works with https://gitlab.cern.ch/push-notifications/notifications-consumer/-/merge_requests/122
Closes #85Emmanuel OrmanceyEmmanuel Ormanceyhttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/120[#85] Don't send notifications to NOT OK devices (exclude EXPIRED and other s...2023-11-17T07:50:33+01:00Emmanuel Ormancey[#85] Don't send notifications to NOT OK devices (exclude EXPIRED and other statuses)Closes #
Changes:
- Update device query to get only status=OK devices
Closes #85Closes #
Changes:
- Update device query to get only status=OK devices
Closes #85Emmanuel OrmanceyEmmanuel Ormanceyhttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/119bugfix: log 404 on get group users2023-10-24T10:11:16+02:00Carina Antunesbugfix: log 404 on get group usersCloses #
Changes:
-Closes #
Changes:
-Carina AntunesCarina Antuneshttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/118Update file .gitlab-ci.yml2023-09-18T16:09:59+02:00Jose SemedoUpdate file .gitlab-ci.ymlCloses #
Changes:
-Closes #
Changes:
-https://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/117[#82] Add support for device type phone subtype mail2sms2023-10-17T10:05:59+02:00Jose Semedo[#82] Add support for device type phone subtype mail2smsCloses #
Changes:
-
Closes #82Closes #
Changes:
-
Closes #82Jose SemedoJose Semedohttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/116[#84] Short URL integration2023-07-10T20:23:51+02:00Caetan Tojeiro Carpente[#84] Short URL integrationCloses #84
Changes:
- Added short URLCloses #84
Changes:
- Added short URLCaetan Tojeiro CarpenteCaetan Tojeiro Carpentehttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/115Add apache 2 license.2023-05-17T09:31:09+02:00Jose SemedoAdd apache 2 license.Closes #
Changes:
-Closes #
Changes:
-Jose SemedoJose Semedohttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/114[#83] Move docker image pull to Harbor2023-03-28T15:36:34+02:00Caetan Tojeiro Carpente[#83] Move docker image pull to HarborCloses #83Closes #83Caetan Tojeiro CarpenteCaetan Tojeiro Carpentehttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/113[#75] Auditing fixes2023-01-30T14:45:48+01:00Carina Antunes[#75] Auditing fixesFrom the issue:
- [ ] For users - only audit username and email
- [x] For egroups - audit group identifier (instead of uuid)
- [x] Channel snapshot - avoid calling target groups and users inside (its confusing)
- [x] Computed users for ...From the issue:
- [ ] For users - only audit username and email
- [x] For egroups - audit group identifier (instead of uuid)
- [x] Channel snapshot - avoid calling target groups and users inside (its confusing)
- [x] Computed users for intersection - it's confusing (in reality its duplicated from channel snapshot, so perhaps we can just add the key total to it
- [x] Unsubscribed users is being audited twice
Closes #75
Last comment [merge_requests/110#note_6299000](https://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/110#note_6299000):
> It's still not ready.
I propose we create a new MR with the same branch because it's getting harder and harder to track. Please go over all cases and only mark as ready to review after it's ready.
> I've checked and in the user auditing we're auditing the entire user list (including users from e-groups which we agreed on ommiting for privacy reasons since it's a privacy leak - because someone can add a e-group they don't own and therefor don't have access to the user list but see the info in the auditing), eg [user-audit.json](/uploads/e03554cde619793722aeaf6585605497/user-audit.json). We also agreed for external on only auditing email/username.
> I propose adding thorough test cases to auditing, specially to make sure we don't leak private data in the external audit.
> We're also auditing get group users twice, can we access if we can change the implementation to fetch them only once? eg [internal-direct-group-intersect.json](/uploads/3b92750d0a57e55cffca052a6718c49b/internal-direct-group-intersect.json)Current sprint: Week 34 + 35https://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/112[#81] Fix 404 error on get_group_users for deleted grappa groups2022-12-19T20:13:43+01:00Emmanuel Ormancey[#81] Fix 404 error on get_group_users for deleted grappa groupsCloses #
Changes:
- ignore 404 error on get_group_users
Closes #81Closes #
Changes:
- ignore 404 error on get_group_users
Closes #81Emmanuel OrmanceyEmmanuel Ormanceyhttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/111[#78] Use the same specific Postgres image on docker-compose as on prod envir...2022-09-26T19:24:37+02:00Caetan Tojeiro Carpente[#78] Use the same specific Postgres image on docker-compose as on prod environmentCloses #78
Changes:
- Use the same specific Postgres image on docker-compose as on prod environment and removed Fedora guidesCloses #78
Changes:
- Use the same specific Postgres image on docker-compose as on prod environment and removed Fedora guideshttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/110[#75] Auditing fixes2023-01-10T10:47:23+01:00Jose Semedo[#75] Auditing fixesFrom the issue:
- [ ] For users - only audit username and email
- [x] For egroups - audit group identifier (instead of uuid)
- [x] Channel snapshot - avoid calling target groups and users inside (its confusing)
- [x] Computed users for ...From the issue:
- [ ] For users - only audit username and email
- [x] For egroups - audit group identifier (instead of uuid)
- [x] Channel snapshot - avoid calling target groups and users inside (its confusing)
- [x] Computed users for intersection - it's confusing (in reality its duplicated from channel snapshot, so perhaps we can just add the key total to it
- [x] Unsubscribed users is being audited twice
Closes #75Week 22 + 23Jose SemedoJose Semedohttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/109get groups members: further improvements2022-06-14T20:59:16+02:00Carina Antunesget groups members: further improvements
Changes:
- Add source field and further comments for clarity
Changes:
- Add source field and further comments for clarityhttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/108[#72] Fix Authz API calls for group members2022-06-14T13:24:34+02:00Emmanuel Ormancey[#72] Fix Authz API calls for group membersCloses #
Changes:
-
Closes #72Closes #
Changes:
-
Closes #72Emmanuel OrmanceyEmmanuel Ormanceyhttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/107[#68] Resolve "Audit: add public audit to router"2022-05-23T11:23:03+02:00Jose Semedo[#68] Resolve "Audit: add public audit to router"Closes #68Closes #68Week 18 + 19Jose SemedoJose Semedohttps://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/106auth service: Fix get_group_users_api paths2022-04-21T20:04:27+02:00Carina Antunesauth service: Fix get_group_users_api pathsCloses #
Changes:
-Closes #
Changes:
-https://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/105audit group data2022-04-21T15:37:33+02:00Carina Antunesaudit group dataCloses #
Changes:
-Closes #
Changes:
-https://gitlab.cern.ch/push-notifications/notifications-routing/-/merge_requests/104hotfix: paginate groups members api2022-04-21T15:26:05+02:00Carina Antuneshotfix: paginate groups members apiCloses #
Changes:
-Closes #
Changes:
-