This project is mirrored from https://:*****@gitlab.cern.ch/atlas/athena.git. Pull mirroring updated .
  1. 21 Oct, 2021 1 commit
    • Bertrand Martin's avatar
      tauRecTools: remove deprecated functionality in TauTrackFinder · 5af6f174
      Bertrand Martin authored
      Hello,
      
      This MR is removing a deprecated feature in the tau-track association.
      In the old days (non-MT R22 trigger), the track particle container was retrieved elsewhere (TrigTauRec) and passed as an argument to the TauTrackFinder execute method to build the tau tracks.
      Now, the track particle container is retrieved from within TauTrackFinder, and we no longer need to pass it as an argument.
      
      The reconstruction output is unchanged.
      
      Cheers,
      Bertrand
      5af6f174
  2. 22 Apr, 2021 1 commit
    • Bertrand Martin's avatar
      tauRec: tidy up calibration flags · 8b169efd
      Bertrand Martin authored
      Hello,
      
      This MR is defining a few more tauRec flags to avoid hardcoding calibration files in TauAlgorithmsHolder. It makes it easier to change the files via a preExec.
      We also move the default calibration path to "R22_preprod", anticipating the upcoming MRs that will deploy the R22 preliminary tunes to be used for Round2 MC pre-production.
      
      Cheers,
      Bertrand
      8b169efd
  3. 08 Apr, 2021 1 commit
    • Bertrand Martin's avatar
      tauRecTools: set back default path in TauRecToolBase · 37223b0c
      Bertrand Martin authored
      Hello,
      
      Apparently, !42357 removed something that client codes rely on: the default path for calibration tau files.
      That is mostly be an issue for analysis tools, rather than a problem for reconstruction.
      But for the time being, I will put back the default path, until this gets clarified and improved.
      
      Adding the "urgent" label, because unit tests are currently failing due to this problem.
      
      Sorry for the mess.
      Bertrand
      37223b0c
  4. 07 Apr, 2021 1 commit
    • Bertrand Martin's avatar
      tauRec: set calibration path for all tools · 1851dc04
      Bertrand Martin authored
      Hello,
      
      This MR is instructing tauRec to set the calibration path for all tools (even for tools that don't use calibration files) according to the tauRecToolsCVMFSPath flag.
      Currently, if not specified explicitly in TauAlgorithmsHolder, we are picking up some default path set in TauRecToolBase (the default has been changed to an empty string, to make sure we don't pick a wrong default value), and the path must be set for each tool individually, which is error prone.
      
      The only exception that still remains is the RNN tau track classifier, where the path is set for the tool of a tool, rather than the tool directly. This is to be improved.
      
      I also cleaned up deprecated tool configurations and flags that will no longer be used in R22.
      
      This MR does not change the reconstruction output.
      
      Cheers,
      Bertrand
      1851dc04
  5. 23 Mar, 2021 1 commit
  6. 27 Oct, 2020 1 commit
    • Bertrand Martin's avatar
      tauRec: drop unused pi0 container · 4856a455
      Bertrand Martin authored
      Hello,
      
      This MR is hopefully the last in the tau pi0 MR series :-)
      Following the recent reorganisation of our pi0 containers, we are dropping a container that is no longer used.
      We are now left with only 2 pi0 containers in the tau reconstruction: TauInitialPi0Clusters (transient, which results from the topoclustering of cells from the TauCommonPi0Cells container), and TauPi0Clusters (persistent, which are identical except that their cells point to the AllCalo container).
      This MR does not change the reconstruction output.
      
      Cheers,
      Bertrand
      4856a455
  7. 05 Oct, 2020 1 commit
    • Bertrand Martin's avatar
      tauRec: more work on pi0s · cec8526b
      Bertrand Martin authored
      Hello,
      
      This is one more small iteration towards rerunning tau reconstruction from xAOD.
      The tau AOD content has been slightly revised, we keep a new pi0 collection and drop another, but otherwise, this MR does not change the reconstruction output.
      Further changes are expected, as the pi0 cell thinning is still work in progress.
      Some modest memory improvement was made in the bookkeeping of already-processed pi0 cells, replacing a std::vector<CaloCell*> with a boost::dynamic_bitset<>.
      
      Cheers,
      Bertrand
      cec8526b
  8. 16 Sep, 2020 1 commit
  9. 07 Sep, 2020 1 commit
  10. 02 Sep, 2020 1 commit
  11. 14 Aug, 2020 1 commit
  12. 24 Jul, 2020 1 commit
  13. 22 Jul, 2020 1 commit
  14. 21 Jul, 2020 1 commit
  15. 14 Jul, 2020 1 commit
  16. 06 Jul, 2020 1 commit
  17. 09 Jun, 2020 1 commit
  18. 22 May, 2020 1 commit
  19. 08 May, 2020 1 commit
  20. 29 Apr, 2020 1 commit
  21. 24 Feb, 2020 1 commit
  22. 05 Feb, 2020 1 commit
  23. 30 Jan, 2020 1 commit
  24. 23 Jan, 2020 1 commit
  25. 22 Jan, 2020 1 commit
  26. 11 Jan, 2020 1 commit
  27. 24 Feb, 2017 2 commits
  28. 23 Feb, 2017 1 commit
  29. 02 Feb, 2017 1 commit
    • Justin Griffiths's avatar
      path resolver for trigger and offline behave the same (tauRecTools-00-01-32) · a6e249a3
      Justin Griffiths authored
      	* Tagging tauRecTools-00-01-29
      	* Trigger now also uses the calib area
      
      2017-01-17 Justin Griffiths <griffith@cern.ch>
      	* Tagging tauRecTools-00-01-28
      	* Combinedp4 updates
      
      2017-01-09 Justin Griffiths <griffith@cern.ch>
      	* Tagging tauRecTools-00-01-27
      	* Trigger updates for vertex finding
      
      2016-12-08 Dirk Duschinger <dirk.duschinger@cern.ch>
      	* Tagging as tauRecTools-00-01-26
      	* Fixed DEEPCOPY macro in TauProcessorTool
      
      2016-12-01 Justin Griffiths <griffith@cern.ch>
      	* Tagging as tauRecTools-00-01-25
      	* Updated CombinedP4FromRecoTaus.cxx, TauWPDecorator.cxx, MvaTES*.cxx
      
      
      Former-commit-id: 9b98a79cbaf19dbd0931fc5bc598f94c794ac451
      a6e249a3
  30. 26 Nov, 2016 1 commit
  31. 11 Oct, 2016 1 commit
    • Justin Griffiths's avatar
      hide code from AthAnalysisBase (tauRecTools-00-01-10) · 5a5daec0
      Justin Griffiths authored
      	* Removed TMVA from package, using MVAUtils
      	* fixed a crash in TauCalibrateLC::finalize
      	* Tagging tauRecTools-00-01-08
      
      2016-08-25 Attila Krasznahorkay <Attila.Krasznahorkay@cern.ch>
      	* Fixed the package to build correctly with -Wl,--no-undefined
      	  enabled.
      	* Cleaned up the CMakeLists.txt file to only build the code under
      	  Root/ into the installed library. Since headers are only public
      	  for those classes. Sources under src/ are only built into the
      	  component library now.
      	* As it turns out, StoreGateSvc::contains doesn't like const type
      	  declarations. Even if the code worked in standalone mode, it had
      	  to be simplified a bit for the offline build.
      	  (This was in Root/TauProcessorTool.cxx.)
      	* Made src/TauVertexFinder.h only include the
      	  "InDetTrackSelectionTool/IInDetTrackSelectionTool.h" interface
      	  header instead of the
      	  "InDetTrackSelectionTool/InDetTrackSelectionTool.h" implementation
      	  header. As using the latter one lead to linking problems.
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: 39ddfdb7
      5a5daec0
  32. 27 May, 2016 1 commit
    • Justin Griffiths's avatar
      fix ATLASRECTS-3165 (tauRecTools-00-00-13) · 3cf49bd8
      Justin Griffiths authored
      	* Updating configuration files for analysis mode tools
      	* Adding configuration file support to TauProcessorTool in analysis mode
      	* Cleanup unused dependencies and cmt/requirements file
      
      
      Former-commit-id: 695b35b22f8070f7202e90155b54ba39a332d285
      3cf49bd8
  33. 13 Nov, 2015 1 commit
    • Justin Griffiths's avatar
      "suppress warning messages for calib file retrival while online" (tauRecTools-00-00-08) · de0f0e97
      Justin Griffiths authored
      	* Adding declareProp to all tools 'inTrigger'
      	* ToDo: remove inTrigger from TauEventData?
      	* Read config files from release only when inTrigger to prevent Warning messages
      	* tagging 00-00-08
      2015 30-10-2015: matthew.beckingham@cern.ch
      	* Adding functionality to copy to TrigCaloOnly four vetor when running online
      2015 29-10-2015: griffith@cern.ch
      	* Use TFormula rather than TF1, allow for 2D corrections in TauIDPileupCorrection
      	* tagging 00-00-06
      
      2015 09-10-2015: griffith@cern.ch
      	* minor coverity fixes, set default val of class memebers in constructor/header
      
      2015 10-16-2015: blake.burghgrave@cern.ch
      	* Add text conf files for some dual-use tools (for ASG-mode)
      
      2015 10-12-2015: blake.burghgrave@cern.ch
      	* TauProcessorTool fix for running in ASG mode
      de0f0e97
  34. 10 Oct, 2015 1 commit