This project is mirrored from https://:*****@gitlab.cern.ch/atlas/athena.git. Pull mirroring updated .
  1. 21 Oct, 2021 1 commit
    • Bertrand Martin's avatar
      tauRecTools: remove deprecated functionality in TauTrackFinder · 5af6f174
      Bertrand Martin authored
      Hello,
      
      This MR is removing a deprecated feature in the tau-track association.
      In the old days (non-MT R22 trigger), the track particle container was retrieved elsewhere (TrigTauRec) and passed as an argument to the TauTrackFinder execute method to build the tau tracks.
      Now, the track particle container is retrieved from within TauTrackFinder, and we no longer need to pass it as an argument.
      
      The reconstruction output is unchanged.
      
      Cheers,
      Bertrand
      5af6f174
  2. 02 Aug, 2021 1 commit
  3. 26 Jun, 2021 1 commit
    • Bertrand Martin's avatar
      tauRecTools: use ghost matching by default for tau-track association · 385f4ee3
      Bertrand Martin authored
      Hello,
      
      This MR is a follow-up of !44662 that introduced ghost matching in the tau-track association procedure (ATLTAU-1442).
      Ghost matching is now activated by default in the offline tau reconstruction (won't be used in the trigger).
      
      In addition, tracks beyond R=0.25 of the tau axis and which are not ghost matched are now kept if the jet closest to the track is the seed jet of the current tau.
      This condition was introduced to recover tau-track association efficiency for low-pt 3p taus, where tracks from the tau decay are not always ghost-matched with the seed jet.
      This scheme will be used for the R22 reprocessing after it is carefully validated.
      
      Sorry for adding the urgent flag again, but it would be great to have this MR reviewed and merged quickly, as it will be needed for the final Round of algorithm tuning for the R22 reprocessing.
      
      Cheers and thanks,
      Bertrand
      385f4ee3
  4. 23 Jun, 2021 1 commit
    • Bertrand Martin's avatar
      tauRecTools: use ghost-matching for tau-track association · c5ef4bb8
      Bertrand Martin authored
      Hello,
      
      This MR is implementing a hybrid tau-track association that accepts all tracks within a cone of radius 0.25, and beyond 0.25, tracks are required to be ghost-matched with the seed jet.
      The ghost matching requirement prevents from using tracks from another tau (a situation that leads to very problematic behaviour of tau substructure reconstruction, ATLTAU-1442).
      The motivations are explained in [this talk](https://indico.cern.ch/event/1051117/contributions/4420815/attachments/2269038/3853037/TauCP_Martin_22Jun21.pdf)
      
      The hybrid cone/ghost scheme is meant to replace the R=0.4 cone association, but it's currently disabled in tauRec.
      
      I am adding the urgent flag because we need to validate the new scheme urgently and use it for upcoming retunings of tau algorithms for the R22 reprocessing.
      
      Cheers,
      Bertrand
      c5ef4bb8
  5. 18 Jun, 2021 1 commit
  6. 28 May, 2021 1 commit
  7. 27 May, 2021 1 commit
  8. 12 Apr, 2021 1 commit
  9. 24 Mar, 2021 1 commit
    • Bertrand Martin Dit Latour's avatar
      tauRecTools: replace Decorator with Accessor in TauTrackFinder · 9b042043
      Bertrand Martin Dit Latour authored and Adam Edward Barton's avatar Adam Edward Barton committed
      Hello,
      
      As discussed in ATLASRECTS-6106 and ATLASRECTS-6104, we make an unnecessary and inappropriate use of Decorator on non-const objects, and we should have used Accessor instead.
      Now fixed in TauTrackFinder.
      Note for later: this could be a bit more streamlined by using the TauTrack::setDetail functionality of the EDM, extending the TrackDetail enum in TauDefs.h.
      
      This MR does not change the reconstruction output.
      
      Cheers,
      Bertrand
      9b042043
  10. 23 Mar, 2021 1 commit
  11. 02 Feb, 2021 1 commit
  12. 01 Feb, 2021 1 commit
    • Bertrand Martin Dit Latour's avatar
      tauRecTools: add tau track flag to identify LRTs more easily · 8a57e9fc
      Bertrand Martin Dit Latour authored and Walter Lampl's avatar Walter Lampl committed
      Hello,
      
      This MR is adding a tau track flag to identify large radius tracks more easily, when LRTs are enabled in the tau reconstruction.
      We can now retrieve specifically the LRTs associated with the tau via tau->tracks(xAOD::TauJetParameters::TauTrackFlag::LargeRadiusTrack).
      This flag is agnostic w.r.t. the track classification, it is only used to tag LRTs, which will be useful e.g. to count LRTs within 0.4 of the tau axis.
      
      As LRTs are not used by default, this MR does not change the reconstruction output.
      
      Cheers,
      Bertrand
      8a57e9fc
  13. 05 Jan, 2021 1 commit
    • Bertrand Martin's avatar
      xAODTau: protection against tau track thinning · 14511df7
      Bertrand Martin authored
      Hello,
      
      This MR is mostly importing !26767 from 21.2 to master, with the original MR description pasted below.
      
      A protection is added against invalid TauTrack links when retrieving the tau tracks or the number of tau tracks.
      This is required to support tau track thinning, used e.g. in DAOD_PHYS.
      Now, only the tau tracks that have a valid link are considered in the TauJets interface class.
      In particular, the behaviour of nAllTracks() had to be changed to be consistent with allTracks().size().
      If one only keeps e.g. classifiedCharged tau tracks by thinning away the other tracks, nAllTracks() will now return the number of classifiedCharged tracks.
      
      Something new compared to the R21 MR: to keep track of the total number of tracks associated with the tau in the reconstruction, a new Aux variable is introduced (mapped to xAOD::TauJetParameters::nAllTracks). So the user is now able to tell if tracks were thinned in the AOD->DAOD step, by comparing tau->nAllTracks() to tau->detail(xAOD::TauJetParameters::nAllTracks, nTracksTot).
      
      Cheers,
      Bertrand
      14511df7
  14. 26 Oct, 2020 1 commit
  15. 05 Oct, 2020 1 commit
    • Bertrand Martin Dit Latour's avatar
      auRecTools: use consistently tau track IP w.r.t. tau vertex · 1e4cfb41
      Bertrand Martin Dit Latour authored and Vakhtang Tsulaia's avatar Vakhtang Tsulaia committed
      Hello,
      
      This MR is harmonising the use of tau track IP and IP significance parameters across the tau reconstruction.
      We now use everywhere the impact parameters w.r.t. the tau vertex instead of w.r.t. beam line (relevant for d0).
      New methods are introduced to retrieve the track IP and IP significances directly from the tau track (before, we would use e.g. d0 from the associated TrackParticle, i.e. d0 w.r.t. the beam line).
      
      Because we need track IPs early in the reconstruction (right after tau vertex finding and tau track association, and before tau track classification), I had to move the track IP calculation from TauVertexVariables to TauTrackFinder, as TauVertexVariables is scheduled late in the reconstruction chain.
      
      Two variables have been discontinued: TauJetsAux.ipSigLeadTrk TauJetsAux.ipZ0SinThetaSigLeadTrk. These are track IPs defined for the leading track. Now that we compute these for all tau tracks, we can drop these "leading track" variables.
      
      Using standalone tau reconstruction from ESD, I have checked that the tau reconstruction output is unchanged if I fall back to the "old" calculations for track IPs, i.e. if I set d0TJVA = track()->d0(), and z0sinthetaTJVA = z0sinThetaTJVA(tau) in Track_v1.
      Meaning, this MR is mostly code reorganisation. The only modification that changes the reconstruction is the new definition of d0TJVA and z0sinthetaTJVA.
      With these new definitions, we get slight changes on the BDT ID score and the RNN ID score, as well as the track classification scores, as expected.
      
      Cheers,
      Bertrand
      1e4cfb41
  16. 22 Sep, 2020 1 commit
    • Xiaozhong Huang's avatar
      tauRecTools: use consistent treatments of vertex correction (ATLTAU-1716) · e5ef5283
      Xiaozhong Huang authored and Edward Moyse's avatar Edward Moyse committed
      The vertex correction is not applied consistently in the tau
      reconstruction. In addition, it is applied to the four momentum already
      corrected by PV0, indicating an over correction.
      
      Ideally, we could apply the vertex correction to the four momentum
      before the origin correction in jet reconstruction. But it is not
      straight forward to obtain this information. Alternatively, we
      apply the vertex correction relative to the jet vertex to fix
      this bug.
      e5ef5283
  17. 09 Sep, 2020 1 commit
    • Bertrand Martin Dit Latour's avatar
      drop unused tau variable · d4d7a35e
      Bertrand Martin Dit Latour authored and Vakhtang Tsulaia's avatar Vakhtang Tsulaia committed
      Hello,
      
      This MR is dropping a variable that is not used anywhere (anymore) in the tau reconstruction.
      We now use a Et-resolution weighted average between calo and substructure pt as input to the MVA pt, no longer an interpolation.
      I have checked it does not change the reconstruction output, besides this variable that is now gone.
      Minor code cleanup was done.
      
      Cheers,
      Bertrand
      d4d7a35e
  18. 06 Jul, 2020 1 commit
  19. 09 Jun, 2020 1 commit
  20. 21 Apr, 2020 1 commit
  21. 01 Apr, 2020 1 commit
  22. 29 Feb, 2020 1 commit
  23. 24 Feb, 2020 1 commit
  24. 30 Jan, 2020 1 commit
  25. 24 Jan, 2020 1 commit
    • Xiaozhong Huang's avatar
      tauRecTools: remove unused properties · 4e3c7243
      Xiaozhong Huang authored and Vakhtang Tsulaia's avatar Vakhtang Tsulaia committed
      The property of container name are replaced by ReadHandleKey, thus not
      used any more. They are now removed.
      
      We use three diferent property ( "CellCorrection", "AxisCorrection",
      and "VertexCorrection") to decide whether to perform the same operation,
      e.g. tau vertex correction of the cell. Now, only "VertexCorrection" is
      used.
      4e3c7243
  26. 22 Jan, 2020 1 commit
  27. 20 Jan, 2020 1 commit
  28. 18 Dec, 2019 1 commit
  29. 14 Nov, 2019 1 commit
  30. 30 Oct, 2019 2 commits
  31. 29 Oct, 2019 1 commit
  32. 18 Apr, 2019 1 commit
  33. 16 Nov, 2018 1 commit
  34. 17 Sep, 2018 1 commit
  35. 20 Aug, 2018 1 commit
  36. 13 Jun, 2018 1 commit
  37. 15 Feb, 2017 1 commit
    • Justin Griffiths's avatar
      fix FPE (tauRecTools-00-02-03) · 876a8bc4
      Justin Griffiths authored
      	* Tagging 00-02-03
      	* Fix FPE CombinedP4, don't set a TLV with eta=-1111
      
      2017-02-09 Justin Griffiths <griffith@cern.ch>
      	* Tagging 00-02-02
      	* Fix bug in TauCommonCalcVars I recently introduced (IntermediateAxis is invalid in trigger)
      
      2017-02-09 Justin Griffiths <griffith@cern.ch>
      	* Tagging 00-02-01
      	* CombinedP4: downgrade warnings
      
      2017-02-08 Will Davey <will.davey@cern.ch>
      	* TauWPDecorator.cxx: bugfix boundaries in score flattening
      
      2017-02-08 Justin Griffiths <griffith@cern.ch>
      	* Moving tools from TauDiscriminant to here: TauIDVarCalculator and TauEleOLRDecorator
      	* Setting all wide tracks as isolation and modifiedIsolation in TauTrackFinder, bits
      	properly set in TauTrackClassifier--done for benefit of trigger
      	* update CMakeLists, requirements, Makefile.RootCore including xAODEgamma
      	* update MvaEvauator from Terry (use combined pt)
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: ce80600162c2cc203efc18167f0f43c27b6d87b9
      876a8bc4
  38. 26 Nov, 2016 1 commit
  39. 01 Nov, 2016 1 commit
    • Justin Griffiths's avatar
      fix duplicate properties (tauRecTools-00-01-19) · fa9ec9f0
      Justin Griffiths authored
      	* Taught the package how to build in standalone mode with CMake.
      	* Tagging as tauRecTools-00-01-18
      
      2016-10-12 Will Davey <will.davey@cern.ch>
      	* tagging tauRecTools-00-01-15
      	* Switch to standalone CaloVertexedTopoCluster in TauPi0ClusterScaler
      	(difference on level of 0.0005 units in eta)
      	* Move TauPi0ClusterScaler, TauPi0ScoreCalcualtor, TauPi0Selector to Root/
      
      2016-10-11 Will Davey <will.davey@cern.ch>
      	* temporarily moving TauPi0ClusterScaler, TauPi0ScoreCalcualtor,
      	TauPi0Selector back to src/ until we solve standalone vertex correction
      	issue
      
      2016-10-11 Will Davey <will.davey@cern.ch>
      	* Extrapolate to EM+Had layers in TauTrackFinder and store in
      	"TrackDetail"
      	* Integrated pi0 bugfix in TauPi0ClusterScaler and converted to use
      	decorated extrapolation positions
      	* Convert TauPi0ClusterScaler, TauPi0ScoreCalcualtor, TauPi0Selector to
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: 785f5bfb3f4d0d07ca464d6301adf2d2e7ff02b6
      fa9ec9f0