GitLab

    
Don't use references in a range-for if the object must be copied.

New compiler, new set of warnings...

The main theme here is that clang now checks for range-based for loops
whether it introduces unneeded temporaries, i.e. if the user asks for
a reference for the loop variable, but the iterator doesn't return a
reference or a reference of a different type, or conversely if the
user asked for `const auto`, but could have been `const auto&`.

In practice that usually hits us as:
```
for (const auto& jet : jetContainer)
```
which should be:
```
for (const auto *jet : jetContainer)
```

Also a couple of places like this (which miss the `const` qualifier on
the first template parameter):
```
std::map<std::string,std::string> stringMap;
for (const std::pair<std::string,std::string>& stringPair : stringMap)
```

For the most part I just replaced the loop variable type with what
seemed correct.  In a few places I put explicit comments as to why I
chose the type.

Also a fair number of warnings for unused member variabl...

Nils Erik Krumnack authored Aug 27, 2020 and Adam Edward Barton committed Aug 27, 2020

Just adding some more dual-use features to get AnalysisBase packages
working.

Albert Kong authored Jul 21, 2020 and Adam Edward Barton committed Jul 21, 2020

Note that this currently generates a compile error since fv.m() is not a valid way to access that component any more

Nils Erik Krumnack authored Dec 13, 2019 and Atlas Nightlybuild committed Dec 14, 2019

Improve Performance of fJVT Tool

See merge request atlas/athena!28824

(cherry picked from commit a4c2b72f)

0bb08c8a Improve performance of fJVT tool

Private data members should start with m_.

Former-commit-id: 7f88ca42932be884871fd449dae6170161ca0f11

Former-commit-id: 8bcb8e79261a185e7e99a9bdc32bba1413f991eb

Plus minor dug fixes and renaming of variables.


Former-commit-id: 93b063885976e656f7e28e05620f59b8225720d6

Former-commit-id: c34cc7f726a79163a45fc57800651dfe8cccd292

        * Root/JetCaloEnergies.cxx: Remove line that calculates UNKNOWN layer energy for pflow jets, which is not stored in jets.
        * ATLASRECTS-3136
        * Tagging as JetMomentTools-00-03-36 (JetMomentTools-00-03-36)

2016-05-06 Mark Hodgkinson
	* Root/JetCaloEnergies.cxx: Remove line that calculates UNKNOWN layer energy for pflow jets, which is not stored in jets.
	* ATLASRECTS-3136
	* Tagging as JetMomentTools-00-03-36
2016-04-25 Mark Hodgkinson
	* Root/JetCaloEnergies.cxx: Update PFlow EMFrac definition and add PFO layer energies
	* Tagging as JetMomentTools-00-03-35

2016-04-16 Attila Krasznahorkay <Attila.Krasznahorkay@cern.ch>
	* Created a new tag that would include a CMakeLists.txt file.
	* Took the opportunity to clean up the file a bit.
	* Removed the executable flag from the requirements file.
	* Tagging as JetMomentTools-00-03-34

2016-03-22    Johannes Elmsheuser
	* python/DefaultTools.py : New configuration module for JetRecConfig
	* ATLJETMET-511
	* Tag JetMomentTools-00-03-33

2016-01-22 Matt Klein
...
(Long ChangeLog diff - truncated)


Former-commit-id: 255c950dd4e345690ef76bfdb90c9a4949f6323f