From 553d4a74e5bfab8ce7b2c7cd310ec27b4e506316 Mon Sep 17 00:00:00 2001
From: Giovanna Lazzari Miotto <giovanna.lazzari.miotto@cern.ch>
Date: Fri, 27 Sep 2024 00:12:51 +0200
Subject: [PATCH] logging: Changes
---
src/OutputByOrbit.cc | 3 ++-
src/orbit_processor.cc | 21 ++++++++++++---------
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/src/OutputByOrbit.cc b/src/OutputByOrbit.cc
index f711b044..e4bbcb20 100644
--- a/src/OutputByOrbit.cc
+++ b/src/OutputByOrbit.cc
@@ -36,7 +36,8 @@ void OutputByOrbitStream::OutputFixedOrbits(Slice &out) {
if (!out.isInitialized()) {
return;
}
-
+ // LOG(TRACE) << "Staging slice with 1st orbit number=" << orbitN
+ // << ", file_index=" << file_index;
output_file_handler_.StageSlice(out.begin(), out.size(), conf_.num_orbits_per_packet_,
run_number, file_index);
diff --git a/src/orbit_processor.cc b/src/orbit_processor.cc
index b7755be5..2f47f972 100644
--- a/src/orbit_processor.cc
+++ b/src/orbit_processor.cc
@@ -27,15 +27,15 @@ bool OrbitProcessor::CheckFrameMultBlock(size_t inputSize, uint16_t nDroppedOrbi
((stats.packet_skipped_inconsistent_size < 10000) &&
(stats.packet_skipped_inconsistent_size % 1000 == 0)) ||
(stats.packet_skipped_inconsistent_size % 10000 == 0)) {
-// LOG(WARNING) << "Frame size not a multiple of block size after headers "
-// "and trailers have been subtracted. Counted "
-// << stats.packet_skipped_inconsistent_size << " packets skipped.";
+ // LOG(WARNING) << "Frame size not a multiple of block size after headers "
+ // "and trailers have been subtracted. Counted "
+ // << stats.packet_skipped_inconsistent_size << " packets skipped.";
}
-// LOG(WARNING) << "Frame size not a multiple of block size after orbit headers "
-// "(32B*nOrbitsPerPacket), orbit trailers (512B*nOrbitsPerPacket), "
-// "and packet trailer (32B) have been subtracted. \n Frame size = "
-// << inputSize << ", block size = " << bsize << ", packet will be skipped";
+ // LOG(WARNING) << "Frame size not a multiple of block size after orbit headers "
+ // "(32B*nOrbitsPerPacket), orbit trailers (512B*nOrbitsPerPacket), "
+ // "and packet trailer (32B) have been subtracted. \n Frame size = "
+ // << inputSize << ", block size = " << bsize << ", packet will be skipped";
return false;
} else {
stats.n_consistent_sized_packets++;
@@ -141,8 +141,9 @@ OrbitProcessor::FillOrbitMetadata OrbitProcessor::FillOrbit(orbit_trailer *trail
MemRegion readable_block(&rd_ptr, rd_end_ptr);
WriteMemRegion writeable_block(&wr_ptr, wr_end_ptr);
-// LOG(DEBUG) << "Writing to memory region: " << std::to_string(writeable_block.GetAvailable())
-// << " bytes available, " << std::to_string(GetPacketSize()) << " needed.";
+ // LOG(DEBUG) << "Writing to memory region: " <<
+ // std::to_string(writeable_block.GetAvailable())
+ // << " bytes available, " << std::to_string(GetPacketSize()) << " needed.";
assert(writeable_block.CheckBounds(GetPacketSize())); // Max size a decoded block can use
BxMetadata meta{orbit_header.second, static_cast<uint32_t>(bx), orbit};
@@ -217,6 +218,8 @@ void OrbitProcessor::ProcessSliceImpl(Slice &input, Slice &out) {
// NOTE: Only relevant for GMT processor, as number of orbits is always 1 in the CALO case.
if (orbit_per_packet_count > nOrbitsPerPacket) {
+ LOG(WARNING) << "Orbit count in packet above prescribed maximum 'nOrbitsPerPacket': "
+ << orbit_per_packet_count << " > " << nOrbitsPerPacket;
stats.excess_orbits_per_packet_count++;
return;
}
--
GitLab