From d76345c4adcdda94661d78ba85140f578abf5311 Mon Sep 17 00:00:00 2001
From: Giovanna Lazzari Miotto <giovanna.lazzari.miotto@cern.ch>
Date: Fri, 14 Feb 2025 14:00:50 +0100
Subject: [PATCH] fix: sink: Move file close call out of assertion
---
src/sink.cc | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/sink.cc b/src/sink.cc
index 319bfb82..ecbbb9fb 100644
--- a/src/sink.cc
+++ b/src/sink.cc
@@ -5,6 +5,14 @@
#include "sink.h"
+#include <tbb/concurrent_queue.h>
+
+#include <cassert>
+#include <fstream>
+
+#include "OutputFile.h"
+#include "log.h"
+
template class Sink<FileOutput>;
template <typename TOutput>
@@ -31,7 +39,8 @@ void Sink<TOutput>::CommitOutput(const TOutput &f) {
auto file = reinterpret_cast<const FileOutput &>(f);
auto filename = file.GetFilename();
LOG(TRACE) << "Closing file '" << filename << "'";
- assert(file.Close());
+ auto is_closed = file.Close();
+ assert(is_closed);
auto from = file.GetWorkingPath() + "/" + filename;
auto to = GetRootPath() + file.GetDestinationDir() + "/" + filename;
if (rename(from.c_str(), to.c_str()) != 0) {
--
GitLab